Skip to content

HLD for ECN and WRED statistics support in SONiC#1273

Merged
zhangyanzhao merged 1 commit intosonic-net:masterfrom
rpmarvell:rpmarvell_ecn_wred_statistics_on_sonic_hld
Feb 5, 2024
Merged

HLD for ECN and WRED statistics support in SONiC#1273
zhangyanzhao merged 1 commit intosonic-net:masterfrom
rpmarvell:rpmarvell_ecn_wred_statistics_on_sonic_hld

Conversation

@rpmarvell
Copy link
Copy Markdown
Contributor

@rpmarvell rpmarvell commented Feb 23, 2023 •
edited
Loading

This document describes the high-level design of

  • ECN-marked queue statistics
  • WRED-drop port statistics
  • WRED-drop queue statistics

Code PR details :

Repo PR title State
sonic-swss-common WRED and ECN stats flexcounter macros and lua script updates for stats capability query Merged
sonic-sairedis Statistics capability query is implemented in sairedis and syncd Merged
sonic-swss WRED and ECN statistics implementation Merged
sonic-buildimage Added new flex counter groups in yang file Merged
sonic-utilities CLI support for WRED and ECN statistics feature Merged

@rpmarvell rpmarvell force-pushed the rpmarvell_ecn_wred_statistics_on_sonic_hld branch from dc71cf1 to 73a7e86 Compare February 28, 2023 14:01
@yxieca yxieca requested a review from neethajohn February 28, 2023 16:50
@zhangyanzhao
Copy link
Copy Markdown
Collaborator

zhangyanzhao commented Feb 28, 2023

Please update the Command Reference document for your new CLI and update/define YANG model for the updated Config_DB

@zhangyanzhao
Copy link
Copy Markdown
Collaborator

zhangyanzhao commented Feb 28, 2023

This is reviewed in sonic community and recording is https://zoom.us/rec/share/ftw0da4bBQdfjGpKWj0KpRUS-Jn0FZiiUCD2Ia3oxByheb02XoJfvsKTgYIbDrRP.MaLAuB2VyRHtcHap

shishao7sxm
shishao7sxm reviewed Mar 1, 2023
View reviewed changes
shishao7sxm
shishao7sxm reviewed Mar 1, 2023
View reviewed changes
@liat-grozovik
Copy link
Copy Markdown
Collaborator

liat-grozovik commented Mar 6, 2023

@stephenxs could you please help to review?
IMO sonic design should take into consideration that SAI will not support part of it and thus it should be used by stat capabilities.
also, need to ensure that the out put of the CLIs is aligned with the fact that some capabilities are not available and what should be the cli output for it

stephenxs
stephenxs reviewed Mar 7, 2023
View reviewed changes
neethajohn
neethajohn reviewed Mar 10, 2023
View reviewed changes
@msosyak
Copy link
Copy Markdown

msosyak commented May 8, 2023

Please update the description with implementation PR references according to pull-request-process

@rpmarvell rpmarvell requested a review from neethajohn May 18, 2023 19:42
@rpmarvell rpmarvell force-pushed the rpmarvell_ecn_wred_statistics_on_sonic_hld branch from 064a451 to c127b2b Compare May 24, 2023 20:39
@rpmarvell
HLD for ECN and WRED statistics support in SONiC
60fb686 
- ECN queue statistics
- WRED queue statistics
- WRED port statistics

Signed-off-by: rpmarvell <[email protected]>

Review comments addressed
@rpmarvell rpmarvell force-pushed the rpmarvell_ecn_wred_statistics_on_sonic_hld branch from a86d824 to 60fb686 Compare May 29, 2023 10:00
stephenxs
stephenxs reviewed Jun 9, 2023
View reviewed changes
@rpmarvell
Copy link
Copy Markdown
Contributor Author

rpmarvell commented Dec 7, 2023

@neethajohn : Could you please help merge this HLD

@zhangyanzhao
Copy link
Copy Markdown
Collaborator

zhangyanzhao commented Feb 5, 2024

@rpmarvell there are open comments to be addressed in the code PRs, can you please help to check and address? Thanks.

@zhangyanzhao
Copy link
Copy Markdown
Collaborator

zhangyanzhao commented Feb 5, 2024

approved by Nvidia and merge

@zhangyanzhao zhangyanzhao merged commit 38c3ec6 into sonic-net:master Feb 5, 2024
@Yuval-Mellanox
Copy link
Copy Markdown
Contributor

Yuval-Mellanox commented Mar 27, 2024

@rpmarvell What is holding merging the code prs?

@rpmarvell
Copy link
Copy Markdown
Contributor Author

rpmarvell commented Mar 27, 2024

@rpmarvell What is holding merging the code prs?

Sonic-sairedis review comments are being addressed. It will be merged as soon as the testing is done for the same.

@zhangyanzhao
Copy link
Copy Markdown
Collaborator

zhangyanzhao commented May 28, 2024

Marvell has no time to work on this feature before 5/30.

@zhangyanzhao
Copy link
Copy Markdown
Collaborator

zhangyanzhao commented Jun 4, 2024

HLD is merged, code PRs have open comments, move to backlog

@zhangyanzhao
Copy link
Copy Markdown
Collaborator

zhangyanzhao commented Dec 10, 2024

code PRs are not merged, move to backlog

@zhangyanzhao zhangyanzhao moved this to ✅ Done in SONiC 202505 Release Jun 6, 2025
@rck-innovium rck-innovium mentioned this pull request Jun 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenxs stephenxs stephenxs approved these changes

@bingwang-ms bingwang-ms Awaiting requested review from bingwang-ms

@shishao7sxm shishao7sxm Awaiting requested review from shishao7sxm

@neethajohn neethajohn Awaiting requested review from neethajohn

Assignees

@rck-innovium rck-innovium

Labels

None yet

Projects

SONiC 202405 Release
Status: MovedToBacklog
SONiC 202411 Release
Status: MovedToBacklog
SONiC 202505 Release
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@rpmarvell @zhangyanzhao @liat-grozovik @msosyak @Yuval-Mellanox @stephenxs @shishao7sxm @neethajohn @rck-innovium