sonic-utilities: WRED stats feature changes on sonic-utilities#2807
Merged
kperumalbfn merged 1 commit intosonic-net:masterfrom Feb 4, 2025
Merged
Conversation
This was referenced Apr 25, 2023
rpmarvell
force-pushed
the
rpmarvell_wred_stats_sonic_utilities
branch
2 times, most recently
from
67af42e to
6438dd6
Compare
10 tasks
rpmarvell
force-pushed
the
rpmarvell_wred_stats_sonic_utilities
branch
2 times, most recently
from
a22be8b to
8e814a4
Compare
msosyak
reviewed
May 9, 2023
rpmarvell
force-pushed
the
rpmarvell_wred_stats_sonic_utilities
branch
2 times, most recently
from
6084f23 to
88db720
Compare
stephenxs
reviewed
May 26, 2023
rpmarvell
force-pushed
the
rpmarvell_wred_stats_sonic_utilities
branch
2 times, most recently
from
4725812 to
2a2bd9f
Compare
stephenxs
reviewed
May 30, 2023
Collaborator
stephenxs
left a comment
stephenxs
left a comment
There was a problem hiding this comment.
Two minor comments.
The rest LGTM.
rpmarvell
force-pushed
the
rpmarvell_wred_stats_sonic_utilities
branch
from
2a2bd9f to
29a097c
Compare
stephenxs
approved these changes
May 30, 2023
rpmarvell
force-pushed
the
rpmarvell_wred_stats_sonic_utilities
branch
from
29a097c to
989748b
Compare
Contributor
|
@rpmarvell Please merge latest master code to trigger Semgrep. |
rpmarvell
force-pushed
the
rpmarvell_wred_stats_sonic_utilities
branch
from
4247129 to
eb034f9
Compare
rpmarvell
force-pushed
the
rpmarvell_wred_stats_sonic_utilities
branch
from
eb034f9 to
17d9c65
Compare
rpmarvell
force-pushed
the
rpmarvell_wred_stats_sonic_utilities
branch
4 times, most recently
from
0fad42d to
9d38aa0
Compare
rpmarvell
force-pushed
the
rpmarvell_wred_stats_sonic_utilities
branch
2 times, most recently
from
cd9018d to
45f3465
Compare
Contributor
|
@rpmarvell Could you resolve the conflicts |
* New script for wredstat CLI commands * portstat script updated to accomodate WRED port stats * counterpoll script updated to support wredport and wredqueue counters * CLi to script mapping changes * UT for the new script changes * CLI command reference document updated Signed-off-by: rpmarvell <[email protected]>
rpmarvell
force-pushed
the
rpmarvell_wred_stats_sonic_utilities
branch
from
c37e76a to
226a8eb
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Resolved the conflicts. |
kperumalbfn
approved these changes
Jan 17, 2025
Contributor
|
Thanks @rpmarvell . Any build or test breakage of this sonic-utilities PR without swss and sairedis changes? If not, we can merge this and have other PRs later.please confirm |
Contributor
Author
|
There should not be any SONiC build issue or UT issue if we merge it without the other branches. |
vmittal-msft
approved these changes
Jan 22, 2025
Contributor
|
@rpmarvell Please share queue command output as well. |
Contributor
Author
|
kperumalbfn
added
Request for msft-202412 Branch
and removed
Request for 202411 Branch
labels
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-utilities.msft#128 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
mssonicbld
added a commit
to mssonicbld/sonic-swss.msft
that referenced
this pull request
Feb 28, 2025
* New flex counter group for per-Queue WRED and ECN statistics * New flex counter group for per-Port WRED and ECN statistics Signed-off-by: [email protected] <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** WRED and ECN statistics support **Why I did it** Implemented as per the HLD : https://github.com/sonic-net/SONiC/blob/master/doc/qos/ECN_and_WRED_statistics_HLD.md **How I verified it** Verfied it using Marvell DUT and SWSS unit tests. **Details if related** - Two new flex counters added for per-Queue and per-Port WRED ECN statistics. Build dependency on sonic-swss-common pull request : sonic-net/sonic-swss-common#777 Expected order of dependent pull-request to be committed : 1) sonic-swss common pull request : sonic-net/sonic-swss-common#777 2) sonic-yang-model pull requests : sonic-net/sonic-buildimage#14758 3) sonic-sairedis pull request : sonic-net/sonic-sairedis#1234 4) sonic-swss : pull request : sonic-net/sonic-swss#2750 5) sonic-utilities pull request : sonic-net/sonic-utilities#2807
mssonicbld
added a commit
to Azure/sonic-swss.msft
that referenced
this pull request
Feb 28, 2025
* New flex counter group for per-Queue WRED and ECN statistics * New flex counter group for per-Port WRED and ECN statistics Signed-off-by: [email protected] <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** WRED and ECN statistics support **Why I did it** Implemented as per the HLD : https://github.com/sonic-net/SONiC/blob/master/doc/qos/ECN_and_WRED_statistics_HLD.md **How I verified it** Verfied it using Marvell DUT and SWSS unit tests. **Details if related** - Two new flex counters added for per-Queue and per-Port WRED ECN statistics. Build dependency on sonic-swss-common pull request : sonic-net/sonic-swss-common#777 Expected order of dependent pull-request to be committed : 1) sonic-swss common pull request : sonic-net/sonic-swss-common#777 2) sonic-yang-model pull requests : sonic-net/sonic-buildimage#14758 3) sonic-sairedis pull request : sonic-net/sonic-sairedis#1234 4) sonic-swss : pull request : sonic-net/sonic-swss#2750 5) sonic-utilities pull request : sonic-net/sonic-utilities#2807
nmoray
pushed a commit
to nmoray/sonic-utilities
that referenced
this pull request
Jun 25, 2025
…-net#2807) sonic-utilities: WRED stats feature changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
CLI support for WRED and ECN statistics feature
How I did it
How to verify it
sonic-utilities UT and Marvell DUT manual testing
Previous command output (if the output of a command-line utility has changed)
root@sonic-dut:~# show interfaces counters detailed Ethernet8
Packets Received 64 Octets..................... 0
Packets Received 65-127 Octets................. 2
Packets Received 128-255 Octets................ 0
Packets Received 256-511 Octets................ 0
Packets Received 512-1023 Octets............... 0
Packets Received 1024-1518 Octets.............. 0
Packets Received 1519-2047 Octets.............. 0
Packets Received 2048-4095 Octets.............. 0
Packets Received 4096-9216 Octets.............. 0
Packets Received 9217-16383 Octets............. 0
Total Packets Received Without Errors.......... 2
Unicast Packets Received....................... 0
Multicast Packets Received..................... 2
Broadcast Packets Received..................... 0
Jabbers Received............................... N/A
Fragments Received............................. N/A
Undersize Received............................. 0
Overruns Received.............................. 0
Packets Transmitted 64 Octets.................. 32,893
Packets Transmitted 65-127 Octets.............. 16,449
Packets Transmitted 128-255 Octets............. 3
Packets Transmitted 256-511 Octets............. 2,387
Packets Transmitted 512-1023 Octets............ 0
Packets Transmitted 1024-1518 Octets........... 0
Packets Transmitted 1519-2047 Octets........... 0
Packets Transmitted 2048-4095 Octets........... 0
Packets Transmitted 4096-9216 Octets........... 0
Packets Transmitted 9217-16383 Octets.......... 0
Total Packets Transmitted Successfully......... 51,732
Unicast Packets Transmitted.................... 0
Multicast Packets Transmitted.................. 18,840
Broadcast Packets Transmitted.................. 32,892
Time Since Counters Last Cleared............... None
New command output (if the output of a command-line utility has changed)
root@sonic-dut:~# show interfaces counters detailed Ethernet8
Packets Received 64 Octets..................... 0
Packets Received 65-127 Octets................. 2
Packets Received 128-255 Octets................ 0
Packets Received 256-511 Octets................ 0
Packets Received 512-1023 Octets............... 0
Packets Received 1024-1518 Octets.............. 0
Packets Received 1519-2047 Octets.............. 0
Packets Received 2048-4095 Octets.............. 0
Packets Received 4096-9216 Octets.............. 0
Packets Received 9217-16383 Octets............. 0
Total Packets Received Without Errors.......... 2
Unicast Packets Received....................... 0
Multicast Packets Received..................... 2
Broadcast Packets Received..................... 0
Jabbers Received............................... N/A
Fragments Received............................. N/A
Undersize Received............................. 0
Overruns Received.............................. 0
Packets Transmitted 64 Octets.................. 32,893
Packets Transmitted 65-127 Octets.............. 16,449
Packets Transmitted 128-255 Octets............. 3
Packets Transmitted 256-511 Octets............. 2,387
Packets Transmitted 512-1023 Octets............ 0
Packets Transmitted 1024-1518 Octets........... 0
Packets Transmitted 1519-2047 Octets........... 0
Packets Transmitted 2048-4095 Octets........... 0
Packets Transmitted 4096-9216 Octets........... 0
Packets Transmitted 9217-16383 Octets.......... 0
Total Packets Transmitted Successfully......... 51,732
Unicast Packets Transmitted.................... 0
Multicast Packets Transmitted.................. 18,840
Broadcast Packets Transmitted.................. 32,892
Time Since Counters Last Cleared............... None
WRED Green Dropped Packets..................... 1
WRED Yellow Dropped Packets.................... 3
WRED RED Dropped Packets....................... 10
WRED Total Dropped Packets..................... 14