Add high power class support for non-CMIS modules in xcvrd#574
Add high power class support for non-CMIS modules in xcvrd#574prgeor merged 8 commits intosonic-net:masterfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for high power class enabling for non‐CMIS modules and updates the SFF manager configuration by renaming the flag from enable_sff_mgr to enable_sff_mgr_controlled_tx. The key changes include:
- Updating the constructor signature and related test cases to reflect the new enable_sff_mgr_controlled_tx parameter.
- Adding a new method (handle_high_power_class) in SffManagerTask to perform high power class enabling.
- Adjusting the daemon initialization and argument parser in xcvrd.py to use the updated parameter name.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sonic-xcvrd/tests/test_xcvrd.py | Updated constructor arguments and added tests for high power class handling. |
| sonic-xcvrd/xcvrd/sff_mgr.py | Renamed the constructor parameter and added the handle_high_power_class method with corresponding logic updates. |
| sonic-xcvrd/xcvrd/xcvrd.py | Updated DaemonXcvrd and argparse handling to use enable_sff_mgr_controlled_tx. |
Comments suppressed due to low confidence (1)
sonic-xcvrd/xcvrd/sff_mgr.py:203
- The word "occured" is misspelled. It should be corrected to "occurred".
self.helper_logger.log_error("Exception occured at {} thread due to {}".format(threading.current_thread().getName(), repr(e)))
prgeor
left a comment
There was a problem hiding this comment.
@longhuan-cisco How are you taking care of the breakout scenario where 4x10G some logical ports are admin down and some UP?
|
@longhuan-cisco Why the SFF manager is calling lpmode for SFF8472 when these SFPs do'nt suppot? See |
…_high_power_class
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The below code was added via #565: sonic-platform-daemons/sonic-xcvrd/xcvrd/sff_mgr.py Lines 444 to 445 in fa41b9c |
admin_status for subports is taken care of by below tx_disable/enable: |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
HLD: sonic-net/SONiC#1867
sonic-platform-common PR: sonic-net/sonic-platform-common#521
Description
Motivation and Context
Without enabling high power class for those modules, the module won't operate properly with power output and link won't come up.
How Has This Been Tested?
Verified the module operate with proper power output.
Additional Information (Optional)