Rename enable_sff_mgr flag to enable_sff_mgr_controlled_tx

[longhuan-cisco]

Why I did it

All platforms/vendors by default should be able to get the benefit of high power class enabling/lpmode toggle/etc from sff_mgr, which is common standard logic.

Work item tracking

• Microsoft ADO (number only):

How I did it

Change enable_sff_mgr flag to enable_sff_mgr_controlled_tx, so that sff_mgr will always get spawned by default, and all platforms/vendors by default can get the benefit of high power class enabling/etc. Only sff_mgr's controlling on module Tx is platform based (enable_sff_mgr_controlled_tx)

How to verify it

# sonic-cfggen -a '{"skip_xcvrd_cmis_mgr": false, "enable_xcvrd_sff_mgr_controlled_tx": true, "delay_xcvrd": false}' -t /usr/share/sonic/templates/docker-pmon.supervisord.conf.j2 | grep "program:xcvrd" -A 1
[program:xcvrd]
command=python3 /usr/local/bin/xcvrd --enable_sff_mgr_controlled_tx

# sonic-cfggen -a '{"skip_xcvrd_cmis_mgr": false, "enable_xcvrd_sff_mgr_controlled_tx": false, "delay_xcvrd": false}' -t /usr/share/sonic/templates/docker-pmon.supervisord.conf.j2 | grep "program:xcvrd" -A 1
[program:xcvrd]
command=python3 /usr/local/bin/xcvrd

# sonic-cfggen -a '{"skip_xcvrd_cmis_mgr": false, "delay_xcvrd": false}' -t /usr/share/sonic/templates/docker-pmon.supervisord.conf.j2 | grep "program:xcvrd" -A 1
[program:xcvrd]
command=python3 /usr/local/bin/xcvrd

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012
• 202106
• 202111
• 202205
• 202211
• 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

[mssonicbld]

/azp run Azure.sonic-buildimage

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[lguohan]

@mihirpat1 , can you check this PR?

[mihirpat1]

@mihirpat1 , can you check this PR?

@lguohan Sure, will look into this

[prgeor]

@longhuan-cisco why the existing flag enable_xcvrd_sff_mgr will not work?

[longhuan-cisco]

According to sonic-net/sonic-platform-daemons#574 (comment), will keep existing flag. This PR is no longer needed.