High power class enabling for SFF-8636 modules#521
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 521 in repo sonic-net/sonic-platform-common |
|
/azpw run Azure.sonic-platform-common |
|
/AzurePipelines run Azure.sonic-platform-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@longhuan-cisco Please help in fixing the built failure |
|
/azpw run Azure.sonic-platform-common |
|
/AzurePipelines run Azure.sonic-platform-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@mihirpat1 It was due to issue in CICD infra. Issue was gone after rerun. |
| if power_class < 5: | ||
| return ret | ||
| elif power_class >= 8: | ||
| ret = self.xcvr_eeprom.write(consts.HIGH_POWER_CLASS_ENABLE_CLASS_8, enable) | ||
| else: # Power class 5, 6, 7 | ||
| ret = self.xcvr_eeprom.write(consts.HIGH_POWER_CLASS_ENABLE_CLASS_5_TO_7, enable) | ||
|
|
There was a problem hiding this comment.
@longhuan-cisco you also need to make sure that the SW is in control for driving the power class. The way to do that is by doing a write of 1 to Byte 93 bit 0 i.e power override. Let do that in sff manager.
There was a problem hiding this comment.
According to sff-8636, no matter whether power_override bit is set or not, enabled power class behaves the same.
Today, override bit is handled separately at the time of turning off lpmode.
There was a problem hiding this comment.
@longhuan-cisco the point you are missing here is if you dont set the power override bit to 1 then LPmode must be de-asserted which is an extra thing to ensure. In SW control, where B93 bit 0 = 1, LPmode is don't care. Anyways, we should discuss this in your SFF manager PR
There was a problem hiding this comment.
Moved this discussion to sff_mgr PR at sonic-net/sonic-platform-daemons#574 (comment)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| if power_class < 5: | ||
| return ret | ||
| elif power_class >= 8: | ||
| ret = self.xcvr_eeprom.write(consts.HIGH_POWER_CLASS_ENABLE_CLASS_8, enable) | ||
| else: # Power class 5, 6, 7 | ||
| ret = self.xcvr_eeprom.write(consts.HIGH_POWER_CLASS_ENABLE_CLASS_5_TO_7, enable) |
There was a problem hiding this comment.
@longhuan-cisco can we simply this as follows
if power_class >= 8:
else if power_class >= 5
There was a problem hiding this comment.
@prgeor
After I updated the code to address this comment. The approval gets dismissed.
could you please re-approve this PR. Thanks
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Add platform common API support for enabling high power class if module's power class is greater or equal to 5 (Refer to SFF-8636 spec
6.2.6 Control Functions (Page 00h, Bytes 86-99)for byte 93 definition)Motivation and Context
Without enabling high power class for those modules, the module won't operate properly with power output and link won't come up.
How Has This Been Tested?
Verified the module operate with proper power output.
Additional Information (Optional)