Take non-CMIS xcvrs out of lpmode in SFF Manager by peterbailey-arista · Pull Request #565 · sonic-net/sonic-platform-daemons

peterbailey-arista · 2024-11-21T19:19:48Z

Description

Fix non-CMIS transceivers in down state by bringing them out of low power mode in the SFF Manager Task.
This is intended to work together with the change in sonic-net/sonic-buildimage#20886.

Motivation and Context

Non-CMIS transceivers were not functioning correctly when put into Low Power mode. So XCVRD now brings them out of lpmode.

How Has This Been Tested?

Loaded an image containing this change alongside the change from sonic-net/sonic-buildimage#20886 on an Arista chassis containing a Clearwater2 linecard.
Verified that without this image some interfaces were in a down state but with the image all interfaces came up as expected.

Additional Information (Optional)

linux-foundation-easycla · 2024-11-21T19:19:52Z

The committers listed above are authorized under a signed CLA.

✅ login: peterbailey-arista / name: Peter Bailey (94b96b6)

kenneth-arista · 2024-11-21T21:20:22Z

@arlakshm @wenyiz2021 for awareness

wenyiz2021

LGTM

kenneth-arista · 2024-11-22T02:51:25Z

Yes, along with enabling the SFF manager in xcvrd per platform config ( sonic-net/sonic-buildimage#20886).

…

On Thu, Nov 21, 2024 at 5:57 PM wenyiz2021 ***@***.***> wrote: do we only need this PR for the LP mode causing links down issue? — Reply to this email directly, view it on GitHub <#565 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWIHIW6M2AJXRJ3DQENRAQ32B2FO3AVCNFSM6AAAAABSHXSQQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJSG4YTGNRQGM> . You are receiving this because you commented.Message ID: ***@***.***>

prgeor · 2024-12-01T14:25:58Z

@mihirpat1 can you please review

prgeor · 2024-12-01T14:39:38Z

sonic-xcvrd/xcvrd/sff_mgr.py

                    # Skip if these essential routines are not available
                    continue

+                sfp.set_lpmode(False)


@peterbailey-arista I would suggest to use sfp.set_lpmode() only for SFPs that follow SFF8472. All other transceivers like QSFP+, QSFP28 can support lpmode via EEPROM write. The above code expects each platform to implement set_lpmode() even thought that is NOT required for QSFP based modules.

if (SFP type module) { sfp.set_lpmode(False) } else { api = set_lpmode(False) }

After discussing with @byu343 I ended up wrapping api.set_lpmode in a try except instead. Please let me know if this update works for you. Thanks!

mihirpat1 · 2024-12-03T01:37:28Z

sonic-xcvrd/xcvrd/sff_mgr.py


+                try:
+                    api = sfp.get_xcvr_api()
+                    api.set_lpmode(False)


@peterbailey-arista Per the below implementation, an exception will not be returned for SFF-8472 modules. Can you please handle this accordingly.
https://github.com/sonic-net/sonic-platform-common/blob/0f2e22faccd093a1e5d18235fe119a860be7855e/sonic_platform_base/sonic_xcvr/api/public/sff8472.py#L308

I've now updated it to use sfp.set_lpmode() for only SFPs implementing SFF8472 as was originally suggested

longhuan-cisco · 2024-12-03T22:28:10Z

sonic-xcvrd/xcvrd/sff_mgr.py

                    continue

+                try:
+                    api = sfp.get_xcvr_api()


api has been already obtained at the code before:

sonic-platform-daemons/sonic-xcvrd/xcvrd/sff_mgr.py

Line 410 in 78d427e

api = sfp.get_xcvr_api()

mihirpat1 · 2024-12-04T22:37:14Z

sonic-xcvrd/xcvrd/sff_mgr.py

                    continue

+                if isinstance(api, Sff8472Api):
+                    sfp.set_lpmode(False)


@peterbailey-arista Can we check for the return value in both the cases and log error if it returns False?
Also, can you please help in fixing the built failure?

I added the check with the new error log. But am not sure how to resolve the build failure, it does not seem to be related to my change. Do you have any suggestions?

kenneth-arista · 2024-12-04T23:44:34Z

/azpw run Azure.sonic-platform-daemons

kenneth-arista · 2024-12-04T23:45:40Z

Above build failure is unrelated to the change in this PR. The failure is caused by:

dpkg: error: cannot access archive 'libnl-3-200_*.deb': No such file or directory

peterbailey-arista · 2024-12-05T00:56:19Z

/azpw run Azure.sonic-platform-daemons

mssonicbld · 2024-12-05T00:56:21Z

/AzurePipelines run Azure.sonic-platform-daemons

azure-pipelines · 2024-12-05T00:56:30Z

Azure Pipelines successfully started running 1 pipeline(s).

longhuan-cisco · 2024-12-05T01:34:20Z

sonic-xcvrd/xcvrd/sff_mgr.py

                    # Skip if these essential routines are not available
                    continue

+                set_lp_success = (


I assume lpmode handling is only needed at module insertion event, right?

Just some minor suggestion:
Maybe adding below condition check can avoid unnecessary lpmode handling in other cases (e.g. the case of admin_status/host_tx_ready getting changed by config interface shutdown/startup)

if xcvr_inserted: <lpmode logic>

The described scenario unfortunately still requires lpmode set False. If you shutdown then startup the interface without bringing it out of lpmode the interface remains down even if it was up before shutdown

I thought lpmode can get reset after module reset (sfputil reset), but interface shut/start (i.e. NPU/PHY/laser tx ON/OFF) wouldn't impact the module on lpmode/etc unless user/platform/vendor explicitly triggers something additional for module as part of the interface shut/start. Is that not the case here?

My mistake, I believe you are correct. I'll add that change, thanks

peterbailey-arista · 2024-12-06T17:33:14Z

/azpw run Azure.sonic-platform-daemons

mssonicbld · 2024-12-06T17:33:18Z

/AzurePipelines run Azure.sonic-platform-daemons

azure-pipelines · 2024-12-06T17:33:27Z

Azure Pipelines successfully started running 1 pipeline(s).

arlakshm · 2024-12-06T21:34:00Z

/Azp Azure.sonic-platform-daemons

azure-pipelines · 2024-12-06T21:34:05Z

Command 'Azure.sonic-platform-daemons' is not supported by Azure Pipelines. Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

Fix non-CMIS transceivers in down state by bringing them out of lpmode in the SFF Manager Task.

arlakshm · 2024-12-13T01:59:06Z

@longhuan-cisco @mihirpat1, Can you please approve this change if all the comments are addressed.

mihirpat1

@peterbailey-arista The changes look good to me. Can you please help in resolving the build failure?

arlakshm · 2024-12-14T01:38:08Z

/Azp run Azure.sonic-platform-daemons

azure-pipelines · 2024-12-14T01:38:17Z

Azure Pipelines successfully started running 1 pipeline(s).

Description Fix non-CMIS transceivers in down state by bringing them out of low power mode in the SFF Manager Task. This is intended to work together with the change in sonic-net/sonic-buildimage#20886. Motivation and Context Non-CMIS transceivers were not functioning correctly when put into Low Power mode. So XCVRD now brings them out of lpmode. How Has This Been Tested? Loaded an image containing this change alongside the change from sonic-net/sonic-buildimage#20886 on an Arista chassis containing a Clearwater2 linecard. Verified that without this image some interfaces were in a down state but with the image all interfaces came up as expected.

mssonicbld · 2024-12-21T04:37:27Z

Cherry-pick PR to 202405: #581

Description Fix non-CMIS transceivers in down state by bringing them out of low power mode in the SFF Manager Task. This is intended to work together with the change in sonic-net/sonic-buildimage#20886. Motivation and Context Non-CMIS transceivers were not functioning correctly when put into Low Power mode. So XCVRD now brings them out of lpmode. How Has This Been Tested? Loaded an image containing this change alongside the change from sonic-net/sonic-buildimage#20886 on an Arista chassis containing a Clearwater2 linecard. Verified that without this image some interfaces were in a down state but with the image all interfaces came up as expected.

…evice is in detaching mode (#546) * Skip logging the warning, if device is in detaching mode * Add detach_info table and unittests * Fix unit tests * Increase code coverage * Remove unused header import * Fix dict get values * Increase code coverage * Increase test coverage * [SmartSwitch] Extend implementation of the DPU chassis daemon. (#563) * Addition of DPU Chassis for thermalctld (#564) * [stormond] Added new dynamic field 'last_sync_time' to STATE_DB (#535) * Added new dynamic field 'last_sync_time' that shows when STORAGE_INFO for disk was last synced to STATE_DB * Moved 'start' message to actual starting point of the daemon * Added functions for formatted and epoch time for user friendly time display * Made changes per prgeor review comments * Pivot to SysLogger for all logging * Increased log level so that they are seen in syslogs * Code coverage improvement * [lag_id] Add lagid to free_list when LC absent for 30 minutes (#542) When LC is absent for 30 minutes, the database cleanup kicks in. When LagId is released, it needs to be appended to the SYSTEM_LAG_IDS_FREE_LIST This PR works with the following 2 PRs: sonic-net/sonic-swss#3303 sonic-net/sonic-buildimage#20369 Signed-off-by: mlok <[email protected]> * Fixed bug in chassisd causing incorrect number of ASICs in CHASSIS_STATE_DB (#560) Fixed the bug in chassisd due to which incorrect number of ASICs were being pushed to CHASSIS_STATE_DB. * thermalctld: Add support for fans on non-CPU modules (#555) * thermalctld: Add support for fans on non-CPU modules * Add module fan to unit tests * Advanced Azure pipeline to Bookworm (#572) Description This PR advances the azure pipeline on sonic_platform_daemons from bullseye to bookworm. This fixes the issue where sonic-platform-daemons azp is having some issues due to upgrade to bookworm. See Pipelines - Run 20241210.8 logs for details. * Take non-CMIS xcvrs out of lpmode in SFF Manager (#565) Description Fix non-CMIS transceivers in down state by bringing them out of low power mode in the SFF Manager Task. This is intended to work together with the change in sonic-net/sonic-buildimage#20886. Motivation and Context Non-CMIS transceivers were not functioning correctly when put into Low Power mode. So XCVRD now brings them out of lpmode. How Has This Been Tested? Loaded an image containing this change alongside the change from sonic-net/sonic-buildimage#20886 on an Arista chassis containing a Clearwater2 linecard. Verified that without this image some interfaces were in a down state but with the image all interfaces came up as expected. * Added SmartSwitch support in chassisd and enabling chassisd (#467) Added SmartSwitch support in chassisd and enabling chassisd * [chassis][psud] Move the PSU parent information generation to the loop run function from the initialization function (#576) Description Move the PSU parent information generation to the loop run function from the initialization function Motivation and Context Fixes #575 How Has This Been Tested? Tested on Cisco chassis, the PHYSICAL_ENTITY_INFO|PSU * can be re-inserted after thermalctld restart. And monitored the stated db for memory for hours, works well: * [chassisd] Address the chassisd crash issue and add UT for it (#573) Description On Nokia platform, slot name of Supervisor is string "A" instead of a number. Using "int" to convert it could cause issue backtrace. We should use slot value to any checking without any conversion. This will fixes sonic-net/sonic-buildimage#21131 Motivation and Context Modify the _get_module_info not to convert "slot" to a string value. And also modify the code not to convert slot value to an to do any checking. Just directly use the returned value of get_slot(). Also add UT test_moduleupdater_check_slot_string() to valid it. How Has This Been Tested? Tested on 202405 branch Signed-off-by: mlok <[email protected]> * Fix a comment --------- Signed-off-by: mlok <[email protected]> Co-authored-by: Oleksandr Ivantsiv <[email protected]> Co-authored-by: Gagan Punathil Ellath <[email protected]> Co-authored-by: Ashwin Srinivasan <[email protected]> Co-authored-by: Marty Y. Lok <[email protected]> Co-authored-by: Vivek Verma <[email protected]> Co-authored-by: Patrick MacArthur <[email protected]> Co-authored-by: Peter Bailey <[email protected]> Co-authored-by: rameshraghupathy <[email protected]> Co-authored-by: Jianquan Ye <[email protected]>

mssonicbld · 2025-05-30T06:31:29Z

Cherry-pick PR to msft-202503: Azure/sonic-platform-daemons.msft#18

peterbailey-arista mentioned this pull request Nov 21, 2024

Enable SFF Manger on Arista linecards by default sonic-net/sonic-buildimage#20886

Merged

11 tasks

kenneth-arista mentioned this pull request Nov 21, 2024

[chassis T2] link issue aristanetworks/sonic#101

Closed

wenyiz2021 approved these changes Nov 22, 2024

View reviewed changes

arlakshm requested a review from prgeor November 22, 2024 21:18

arlakshm added the Request for 202405 Branch label Nov 22, 2024

prgeor requested a review from mihirpat1 December 1, 2024 14:26

prgeor reviewed Dec 1, 2024

View reviewed changes

peterbailey-arista force-pushed the master-sff-lpmode branch from c59fabf to 78d427e Compare December 3, 2024 00:47

mihirpat1 reviewed Dec 3, 2024

View reviewed changes

longhuan-cisco reviewed Dec 3, 2024

View reviewed changes

peterbailey-arista force-pushed the master-sff-lpmode branch from 78d427e to 3d14308 Compare December 4, 2024 22:17

mihirpat1 reviewed Dec 4, 2024

View reviewed changes

peterbailey-arista force-pushed the master-sff-lpmode branch from 3d14308 to 072a3e6 Compare December 4, 2024 23:47

longhuan-cisco reviewed Dec 5, 2024

View reviewed changes

Take non-CMIS xcvrs out of lpmode in SFF Manager

94b96b6

Fix non-CMIS transceivers in down state by bringing them out of lpmode in the SFF Manager Task.

peterbailey-arista force-pushed the master-sff-lpmode branch from 072a3e6 to 94b96b6 Compare December 6, 2024 22:20

mihirpat1 reviewed Dec 13, 2024

View reviewed changes

longhuan-cisco approved these changes Dec 13, 2024

View reviewed changes

longhuan-cisco mentioned this pull request Dec 13, 2024

Update sff_mgr HLD to include high power class enabling and lpmode off sonic-net/SONiC#1867

Open

arlakshm approved these changes Dec 14, 2024

View reviewed changes

arlakshm added the Chassis label Dec 14, 2024

arlakshm merged commit 88d0dd7 into sonic-net:master Dec 14, 2024

rlhui added the Request for 202411 Branch label Dec 14, 2024

bingwang-ms added the Approved for 202405 Branch label Dec 14, 2024

rlhui added Approved for 202405 Branch and removed Approved for 202405 Branch labels Dec 18, 2024

arlakshm added Approved for 202405 Branch and removed Approved for 202405 Branch labels Dec 21, 2024

mssonicbld mentioned this pull request Dec 21, 2024

[action] [PR:565] Take non-CMIS xcvrs out of lpmode in SFF Manager (#565) #581

Merged

mssonicbld added the Created PR to 202405 Branch label Dec 21, 2024

mssonicbld added Included in 202405 Branch and removed Created PR to 202405 Branch labels Dec 21, 2024

arlakshm added Request for msft-202503 Branch Approved for msft-202503 Branch labels May 30, 2025

mssonicbld mentioned this pull request May 30, 2025

[action] [PR:565] Take non-CMIS xcvrs out of lpmode in SFF Manager Azure/sonic-platform-daemons.msft#18

Merged

mssonicbld added the Created PR to msft-202503 Branch label May 30, 2025

longhuan-cisco mentioned this pull request Jul 9, 2025

Add high power class support for non-CMIS modules in xcvrd #574

Merged

Conversation

peterbailey-arista commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

How Has This Been Tested?

Additional Information (Optional)

Uh oh!

linux-foundation-easycla bot commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kenneth-arista commented Nov 21, 2024

Uh oh!

wenyiz2021 left a comment

Choose a reason for hiding this comment

Uh oh!

kenneth-arista commented Nov 22, 2024 via email

Uh oh!

prgeor commented Dec 1, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kenneth-arista commented Dec 4, 2024

Uh oh!

kenneth-arista commented Dec 4, 2024

Uh oh!

peterbailey-arista commented Dec 5, 2024

Uh oh!

mssonicbld commented Dec 5, 2024

Uh oh!

azure-pipelines bot commented Dec 5, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peterbailey-arista commented Dec 6, 2024

Uh oh!

mssonicbld commented Dec 6, 2024

Uh oh!

azure-pipelines bot commented Dec 6, 2024

Uh oh!

arlakshm commented Dec 6, 2024

Uh oh!

azure-pipelines bot commented Dec 6, 2024

Uh oh!

arlakshm commented Dec 13, 2024

Uh oh!

mihirpat1 left a comment

Choose a reason for hiding this comment

Uh oh!

arlakshm commented Dec 14, 2024

Uh oh!

azure-pipelines bot commented Dec 14, 2024

Uh oh!

mssonicbld commented Dec 21, 2024

Uh oh!

mssonicbld commented May 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

peterbailey-arista commented Nov 21, 2024 •

edited

Loading

linux-foundation-easycla bot commented Nov 21, 2024 •

edited

Loading