Skip to content

[deploy] Wait for vEOS to come back after restart#906

Merged
qiluo-msft merged 4 commits intosonic-net:masterfrom
wangxin:wait-for-vm
May 17, 2019
Merged

[deploy] Wait for vEOS to come back after restart#906
qiluo-msft merged 4 commits intosonic-net:masterfrom
wangxin:wait-for-vm

Conversation

@wangxin
Copy link
Collaborator

@wangxin wangxin commented May 8, 2019

Description of PR

Summary:
Fixes # (issue)
The vEOS VM deploy script restart the VM after start-up config is loaded into it. The VMs need some time to start up and be functional. There could be issue if run other tasks like changing topo immediately before the VMs are up. This change is to add some code to wait until the VMs are back after restart.

Type of change

  • Bug fix
  • [] Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

Add code to wait until the VMs are back after restart.

How did you verify/test it?

Used in Mellanox lab.

Any platform specific information?

NA

Supported testbed topology if it's a new test case?

NA

Documentation

[deploy] Wait for vEOS to come back after restart
41948b9 
Signed-off-by: Xin Wang <xinw@mellanox.com>
qiluo-msft
qiluo-msft reviewed May 14, 2019
View reviewed changes
ansible/roles/eos/tasks/main.yml Outdated
notify:
- Restart the box
- Pause for reboot
- Wait for VM to come up
Copy link
Contributor

@qiluo-msft qiluo-msft May 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is dangerous to assume the order of notify items. ref: https://stackoverflow.com/a/35130254/2514803

Suggest use normal tasks in this playbook. #Closed

Copy link
Collaborator Author

@wangxin wangxin May 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiluo-msft
Thanks for the suggestion. Updated and committed. Replaced notifying handlers with tasks.

qiluo-msft
qiluo-msft reviewed May 14, 2019
View reviewed changes
ansible/roles/eos/handlers/main.yml Outdated
pause: seconds=30

- name: Wait for VM to come up
local_action: shell ansible -m ping -i veos {{ inventory_hostname }}
Copy link
Contributor

@qiluo-msft qiluo-msft May 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local_action [](start = 2, length = 12)

Use 'ping' module? #Closed

Copy link
Collaborator Author

@wangxin wangxin May 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure of ping module would cause playbook fail. Replaced the ping command with the ansible wait_for module which is designed for this kind of job.

qiluo-msft
qiluo-msft previously requested changes May 14, 2019
View reviewed changes
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comments

qiluo-msft
qiluo-msft reviewed May 16, 2019
View reviewed changes
ansible/roles/eos/handlers/main.yml Outdated
state: started
delay: 30
timeout: 900
connection: local
Copy link
Contributor

@qiluo-msft qiluo-msft May 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not used, please remove.

Copy link
Collaborator Author

@wangxin wangxin May 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Removed the unused handlers.

@qiluo-msft qiluo-msft dismissed their stale review May 16, 2019 17:30

Unblocked, with one minor comment.

qiluo-msft
qiluo-msft reviewed May 16, 2019
View reviewed changes
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comment

[deploy] Remove unused handlers
cb7b4a0 
Signed-off-by: Xin Wang <xinw@mellanox.com>
@qiluo-msft qiluo-msft merged commit b763d47 into sonic-net:master May 17, 2019
yxieca pushed a commit that referenced this pull request May 20, 2019
@wangxin @yxieca
[deploy] Wait for vEOS to come back after restart (#906)
cc9aa3e 
* [deploy] Wait for vEOS to come back after restart
* [deploy] Replace handlers with tasks to ensure execution sequence
* [deploy] Replace ping cmd with wait_for module
* [deploy] Remove unused handlers
@wangxin wangxin deleted the wait-for-vm branch May 24, 2019 03:31
@prajjwal-arista prajjwal-arista mentioned this pull request Nov 6, 2025
Merged
11 tasks
auspham pushed a commit to auspham/sonic-mgmt that referenced this pull request Feb 3, 2026
@bingwang-ms
[202503] enable test_acl and test_qos_sai for t0-f2-d40u8, t1-f2-d10u…
4418a5b 
…8 topo (sonic-net#906)

Cherry-pick [21472](sonic-net#21472)
into 202503

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit
easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should
reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
enable test_acl and test_qos_sai for t0-f2-d40u8, t1-f2-d10u8 topo

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [ ] Test case improvement


### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [x] 202503

### Approach
#### What is the motivation for this PR?
enable test_acl and test_qos_sai for t0-f2-d40u8, t1-f2-d10u8 topo

#### How did you do it?
Added into supported topo list.

#### How did you verify/test it?
local testbed.  

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@tjchadaga
[202012] sairedis submodule update (sonic-net#9156)
cc3e595 
These changes are included in this PR:

07e1f79 [syncd] Add workaround for warm boot new objects (sonic-net#959)
50fd353 Fix the option missing in kernel config issue (sonic-net#956)
e77503c [syncd] Comparison logic workaround for empty buffer profile (sonic-net#906) (sonic-net#941)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@stcheng
[submodules]: Backport ACL/MIRROR features to 201811 branch (sonic-ne…
b8bdeff 
…t#3112)

0ed90ba - [policerorch]: Fix return code comparison error (sonic-net#968) (1 minutes ago) <Shuotian Cheng)
80fcada -  remove crm acl_counters when acl_table removed (sonic-net#918) (3 hours ago) <JaredLius>
bd3651f - [aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (sonic-net#966) (2 minutes ago) <Shuotian Cheng>
0af226a - [aclorch]: Add MIRROR_DSCP table type (sonic-net#906) (4 weeks ago) <Shuotian Cheng>
9005962 - [vstest]: Update the mirror session state table name (sonic-net#917) (5 weeks ago) <Shuotian Cheng>
c4e3e54 - [policerorch]: Add PolicerOrch to bundle with mirror session (sonic-net#889) (6 weeks ago) <Shuotian Cheng>
ee49926 - [Makefile]: Remove header files from source files (sonic-net#883) (8 weeks ago) <Shuotian Cheng>
f889f80 - [aclorch]: Add ICMP type/code match for v4/v6 (sonic-net#868) (8 weeks ago) <Shuotian Cheng>
9931450 - [aclorch]: Add MIRRORv6 and MIRRORv4v6 support for ACL table (sonic-net#825) (9 weeks ago) <Shuotian Cheng>
a1ab18c - [mirrororch]: Fix comments typo (sonic-net#863) (9 weeks ago) <Shuotian Cheng>

sonic-swss-common
485db07 - [schema]: Add SWITCH_CAPABILITY_TABLE (sonic-net#276) (6 weeks ago) <Shuotian Cheng>        
3f49b20 - [schema]: Add POLICER configuration table (sonic-net#277) (6 weeks ago) <Shuotian Cheng>    
539b87d - [schema]: Add STATE_MIRROR_SESSION_TABLE_NAME (sonic-net#278) (6 weeks ago) <Shuotian Cheng>

sonic-utilities
dc52015 - [Sonic-utilities]: Added commands to view acl and port running configs (sonic-net#557) (6 days ago) <Prem Prakash>
635dc88 - [config]: Add config acl add/remove table command (sonic-net#541) (4 weeks ago) <Shuotian Cheng>
dcdc922 - [show]: Add show policer command (sonic-net#540) (4 weeks ago) <Shuotian Cheng>                                        
128462a - [config]: Add --policer option for mirror session (sonic-net#537) (6 weeks ago) <Shuotian Cheng>                       
38da7f3 - [acl_loader]: Add policer attribute in show mirror_session command (sonic-net#538) (6 weeks ago) <Shuotian Cheng>      
f95ff00 - [acl_loader]: Do not apply default DENY rule for MIRRORV6 table (sonic-net#522) (6 weeks ago) <Shuotian Cheng>

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule sonic-swss-common to the latest HEAD aut…
2bd01f4 
…omatically (sonic-net#20222)

src/sonic-swss-common

* 3d9f52b - (HEAD -> 202311, origin/202311) Account for control character as part of zmq_read_part (sonic-net#906) (sonic-net#910) (6 hours ago) [mssonicbld]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

Assignees

No one assigned

Labels

Included in 201811 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wangxin @qiluo-msft @yxieca