Adding Save & Reload testcase for ACL#486
Merged
lguohan merged 3 commits intosonic-net:masterfrom May 4, 2018
Merged
Conversation
This checkin adds changes to perform save and reload test case for ACL rules
prsunny
reviewed
Mar 9, 2018
ansible/roles/test/tasks/acltb.yml
Outdated
| command_to_run: "acl-loader update full /tmp/acltb_test_rules-del.json" | ||
| errors_expected: false | ||
| include: roles/test/tasks/run_command_with_log_analyzer.yml | ||
| command: acl-loader delete |
Contributor
There was a problem hiding this comment.
Why this change as compared to the previous one?. This will delete the entire set of rules but the previous approach deletes the rules based on the json file.
Contributor
Author
There was a problem hiding this comment.
@prsunny acltb_test_rules-del.json file is a empty file. So using either json or 'delete' command performs the same action. Using acl-loader delete is straight forward and reduces the number of lines of code, so made this change.
Additionally I verified acl-loader delete command doesn't remove the DATAACL applied on the interfaces.
Using 'acl-loader delete' deleted all the ACLs including snmp/vty/data/erspan etc. However using 'acl-loader update <empty file> deletes only the dataacl. So reverting back to old change in always section.
prsunny
approved these changes
May 3, 2018
lguohan
approved these changes
May 4, 2018
praveen-li
pushed a commit
to praveen-li/sonic-mgmt
that referenced
this pull request
Jun 20, 2019
* Adding Save & Reload testcase for ACL This checkin adds changes to perform save and reload test case for ACL rules * modified cleanup section with acl-loader delete command * Change acl-loader delete to old command Using 'acl-loader delete' deleted all the ACLs including snmp/vty/data/erspan etc. However using 'acl-loader update <empty file> deletes only the dataacl. So reverting back to old change in always section.
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Aug 2, 2025
Code sync sonic-net/sonic-mgmt:202411 => 202412 ``` * a1064ff (HEAD -> code-sync-202412, origin/code-sync-202412) r12f 250702:1620 - Merge remote-tracking branch 'base/202411' into code-sync-202412 |\ | * f98c8b2 (base/202411) jingwenxie 250513:1319 - Update logger to non user config table (sonic-net#18250) | * 7958657 Chun'ang Li 250702:1223 - manual cherry pick PR https://github.com/sonic-net/sonic-mgmt/pull/19116/files (sonic-net#19322) | * 14dda64 mssonicbld 250702:0533 - Fix flakiness in pfcwd/test_pfcwd_cli.py (sonic-net#17411) (sonic-net#17619) ```
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-utilities 6b4d1a0..46b5aa8: > [show ip interface] Add support for 'alias' interface naming mode (sonic-net#486) Submodule src/sonic-swss 9c4ae18..a637562: > Suppress storm detect counter increment for ongoing pfc storm case during a warm reboot (sonic-net#869) > Remove *_LEFT fields to allow PFC watchdog to enter fresh into the (sonic-net#897) > Set LAG mtu value based on kernel netlink msg (sonic-net#922) > [warm restart assist] assume vector values could be reordered (sonic-net#921) Signed-off-by: Ying Xie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checkin adds changes to perform save and reload test case for ACL rules
Description of PR
Fixes # (issue)
Type of change
Approach
How did you do it?
Installed the ACL rules in the switch,
pushed the changes to configDB,
performed a reload,
re-run the traffic test
How did you verify/test it?
Using PTF traffic test, verified the desired packets are blocked after save and reload.
Any platform specific information?
Supported testbed topology if it's a new test case?
[t1, t1-lag, t1-64-lag]
aclreload.log
Documentation
successful test run log in T1 topology is attached along with pull request.