[action] [PR:17411] Fix flakiness in pfcwd/test_pfcwd_cli.py#17619
Merged
yxieca merged 1 commit intosonic-net:202411from Jul 1, 2025
Merged
[action] [PR:17411] Fix flakiness in pfcwd/test_pfcwd_cli.py#17619yxieca merged 1 commit intosonic-net:202411from
yxieca merged 1 commit intosonic-net:202411from
Conversation
What is the motivation for this PR? Sometimes the test ends up picking an egress interface which happens to be a member of a LAG. If the LAG has multiple members and only one of them is stormed the drop/forwards expectations don't take into account lag hashing. Some of the traffic is hashed to another LAG member which is not being stormed and no drops will occur. How did you do it? The proposed fix is to shutdown the remaining LAG members. How did you verify/test it? Tested on Arista-7260CX3 with dualtor-120 topology and 202411 image.
11 tasks
Collaborator
Author
|
Original PR: #17411 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Jul 1, 2025
…#17619) What is the motivation for this PR? Sometimes the test ends up picking an egress interface which happens to be a member of a LAG. If the LAG has multiple members and only one of them is stormed the drop/forwards expectations don't take into account lag hashing. Some of the traffic is hashed to another LAG member which is not being stormed and no drops will occur. How did you do it? The proposed fix is to shutdown the remaining LAG members. How did you verify/test it? Tested on Arista-7260CX3 with dualtor-120 topology and 202411 image. Co-authored-by: Vivek Verma <[email protected]>
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Aug 2, 2025
Code sync sonic-net/sonic-mgmt:202411 => 202412 ``` * a1064ff (HEAD -> code-sync-202412, origin/code-sync-202412) r12f 250702:1620 - Merge remote-tracking branch 'base/202411' into code-sync-202412 |\ | * f98c8b2 (base/202411) jingwenxie 250513:1319 - Update logger to non user config table (sonic-net#18250) | * 7958657 Chun'ang Li 250702:1223 - manual cherry pick PR https://github.com/sonic-net/sonic-mgmt/pull/19116/files (sonic-net#19322) | * 14dda64 mssonicbld 250702:0533 - Fix flakiness in pfcwd/test_pfcwd_cli.py (sonic-net#17411) (sonic-net#17619) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix flakiness in pfcwd/test_pfcwd_cli.py
Fixes #383
Type of change
Back port request
Approach
What is the motivation for this PR?
Sometimes the test ends up picking an egress interface which happens to be a member of a LAG. If the LAG has multiple members and only one of them is stormed the drop/forwards expectations don't take into account lag hashing.
Some of the traffic is hashed to another LAG member which is not being stormed and no drops will occur.
How did you do it?
The proposed fix is to shutdown the remaining LAG members.
How did you verify/test it?
Tested on Arista-7260CX3 with dualtor-120 topology and 202411 image.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation