Scrub credential in docker pull command line#869
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Apr 13, 2019
Merged
Conversation
wendani
approved these changes
Apr 13, 2019
yxieca
pushed a commit
that referenced
this pull request
Apr 16, 2019
stepanblyschak
pushed a commit
to stepanblyschak/sonic-mgmt
that referenced
this pull request
Jun 14, 2019
…" into develop
deerao02
pushed a commit
to deerao02/sonic-mgmt
that referenced
this pull request
Dec 18, 2025
sonic-net#869) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: At the end of the snmp/test_snmp_link_local.py test, the test will run a config_reload to clean up the test, then check that the snmp container is up and running before ending the test. Currently, the test gives 60s for the snmp container to come back up after config_reload. This is sufficient for small topos but nowhere enough for large topos such as `qspf t0-d32u32s2` - it takes 7 minutes from running config_reload to seeing interfaces coming back up. Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] msft_202412 - [x] msft_202503 - [x] 202505 ### Approach #### What is the motivation for this PR? Insufficient wait time for snmp container to come back up for large topologies #### How did you do it? Extending the allowed wait time to 300s. #### How did you verify/test it? Test no longer fails on bad snmp container state on qspf t0-d32u32s2. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-utilities 6b4d1a0..46b5aa8: > [show ip interface] Add support for 'alias' interface naming mode (sonic-net#486) Submodule src/sonic-swss 9c4ae18..a637562: > Suppress storm detect counter increment for ongoing pfc storm case during a warm reboot (sonic-net#869) > Remove *_LEFT fields to allow PFC watchdog to enter fresh into the (sonic-net#897) > Set LAG mtu value based on kernel netlink msg (sonic-net#922) > [warm restart assist] assume vector values could be reordered (sonic-net#921) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on sonic-net/sonic-buildimage#2782