Skip to content

Adding Save & Reload testcase for ACL #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lguohan merged 3 commits into from
May 4, 2018
Merged

Adding Save & Reload testcase for ACL #486

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c133962
Adding Save & Reload testcase for ACL
Anandaraj-Maharajan Mar 1, 2018
fd06776
modified cleanup section with acl-loader delete command
Anandaraj-Maharajan Mar 9, 2018
c221258
Change acl-loader delete to old command
Anandaraj-Maharajan Apr 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions ansible/roles/test/tasks/acltb.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,17 +115,8 @@
- testbed_type=\"{{ testbed_type }}\"

always:
# Copy ACL config to the switch
- name: Copy ACL config file to the DUT
copy: src="roles/test/tasks/acl/{{ item }}" dest="/tmp/"
with_items:
- "acltb_test_rules-del.json"

- name: Clean up ACL rules.
vars:
command_to_run: "acl-loader update full /tmp/acltb_test_rules-del.json"
errors_expected: false
include: roles/test/tasks/run_command_with_log_analyzer.yml
command: acl-loader delete

@prsunny prsunny Mar 9, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change as compared to the previous one?. This will delete the entire set of rules but the previous approach deletes the rules based on the json file.

@Anandaraj-Maharajan Anandaraj-Maharajan Mar 9, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prsunny acltb_test_rules-del.json file is a empty file. So using either json or 'delete' command performs the same action. Using acl-loader delete is straight forward and reduces the number of lines of code, so made this change.

Additionally I verified acl-loader delete command doesn't remove the DATAACL applied on the interfaces.


- name: Ensure ConfigDB is cleaned up
command: config save -y