[Platform API][pytest] fix test_platform_info.py::test_thermal_control_load_invalid_value_json#4263
Closed
vdahiya12 wants to merge 1 commit intosonic-net:masterfrom
Closed
[Platform API][pytest] fix test_platform_info.py::test_thermal_control_load_invalid_value_json#4263vdahiya12 wants to merge 1 commit intosonic-net:masterfrom
vdahiya12 wants to merge 1 commit intosonic-net:masterfrom
Conversation
…nvalid_value_json Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
vdahiya12
changed the title
vdahiya12
changed the title
Contributor
|
is this fix for an error not a failure? |
Contributor
Author
For a failure. Actually, it looks like the test test_platform_info.py::test_thermal_control_load_invalid_value_json requires thermalctl to raise an exception when loading an invalid json file(loganalyzer requirement), it seems in Arista they wont run the policy upon load, so I just put a duplicate action which will catch an exception, and fix the test |
Contributor
Author
|
close this because its fixed in image. |
Contributor
Author
|
close this because its fixed in image. |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (#25635) #### Why I did it src/sonic-swss ``` * b2c4e649 - (HEAD -> 202511, origin/202511) [202511][ssw][ha] vnetorch support primary/secondary live update for custom bfd (sonic-net#4228) (6 hours ago) [Jing Zhang] * d317c8f9 - [countersyncd]: Fix cargo bench compiling error (sonic-net#4263) (17 hours ago) [mssonicbld] * 725d6660 - [HFT]: keep STATE_DB session stream_status in sync with profile stream_state (sonic-net#4190) (22 hours ago) [mssonicbld] * fa01e8d2 - [countersyncd]: Modify the exit behavior of the main function (sonic-net#4225) (27 hours ago) [mssonicbld] * 82243e7f - [macsecmgr]: Fix MACsec unconfigure failures due to time out (sonic-net#4233) (2 days ago) [mssonicbld] * 8d476206 - [ci] Install redis from Debian (sonic-net#4251) (3 days ago) [mssonicbld] * 0c11b096 - [Bug] This patch is to fix a major bug in the for loop of the (sonic-net#4173) (3 days ago) [ashishalok-arista] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
Description of PR
Currently Arista Platforms do not support speed setting of fans in the thermalctl script, so in order to apply an invalid value policy what we would do is apply a duplicate policy, in order to raise an exception and hence loganalyzer issue would be fixed.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
Ran the changes on Arista7050cx3 testbed
How did you verify/test it?
Verified that the test case works fine.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation