Skip to content

[test_fgnhg] Add test to validate FG ECMP packet flow when neighbors are not resolved#4225

Merged
prsunny merged 2 commits intosonic-net:masterfrom
anish-n:fgEcmpRifRoute
Nov 23, 2021
Merged

[test_fgnhg] Add test to validate FG ECMP packet flow when neighbors are not resolved#4225
prsunny merged 2 commits intosonic-net:masterfrom
anish-n:fgEcmpRifRoute

Conversation

@anish-n
Copy link
Contributor

@anish-n anish-n commented Sep 9, 2021

Description of PR

Summary:
Test case enhancement for newly added capability in Fine Grained ECMP to handle packet flow upon no ECMP next-hops being neighbor resolved.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

Test case enhancement for newly added capability in Fine Grained ECMP to handle packet flow upon no ECMP next-hops being neighbor resolved

How did you do it?

The test will start off with no neighbors resolved and then send packets to the Fine Grained ECMP destination, we will validate that the packets did make it to the endpoint, and validate that the neighbor entry ended up getting resolved via the normal packet flow.

How did you verify/test it?

Ran the pytest with PTF

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2021

This pull request introduces 12 alerts when merging 8cfd77b into e50cc71 - view on LGTM.com

new alerts:

  • 9 for Unused local variable
  • 2 for Testing equality to None
  • 1 for Unreachable code

@yozhao101
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@anish-n
Copy link
Contributor Author

anish-n commented Nov 4, 2021

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 4225 in repo Azure/sonic-mgmt

@prsunny
Copy link
Contributor

prsunny commented Nov 9, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@anish-n
Copy link
Contributor Author

anish-n commented Nov 23, 2021

/azpw run

@prsunny
Copy link
Contributor

prsunny commented Nov 23, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny merged commit 1d9e4b5 into sonic-net:master Nov 23, 2021
@bingwang-ms
Copy link
Collaborator

@anish-n We are seeing errors in fg_ecmp_test.py possibly caused by typo
"======================================================================", "ERROR: fg_ecmp_test.FgEcmpTest", "----------------------------------------------------------------------", "Traceback (most recent call last):", " File \"ptftests/fg_ecmp_test.py\", line 549, in runTest", " self.fg_ecmp()", " File \"ptftests/fg_ecmp_test.py\", line 277, in fg_ecmp", " src_ip = str(base_ip + i)", "NameError: global name 'base_ip' is not defined", "", "----------------------------------------------------------------------", "Ran 1 test in 3.008s", "", "FAILED (errors=1)"
Can you help take a look? Thanks

@anish-n
Copy link
Contributor Author

anish-n commented Nov 29, 2021

@anish-n We are seeing errors in fg_ecmp_test.py possibly caused by typo "======================================================================", "ERROR: fg_ecmp_test.FgEcmpTest", "----------------------------------------------------------------------", "Traceback (most recent call last):", " File \"ptftests/fg_ecmp_test.py\", line 549, in runTest", " self.fg_ecmp()", " File \"ptftests/fg_ecmp_test.py\", line 277, in fg_ecmp", " src_ip = str(base_ip + i)", "NameError: global name 'base_ip' is not defined", "", "----------------------------------------------------------------------", "Ran 1 test in 3.008s", "", "FAILED (errors=1)" Can you help take a look? Thanks

Thanks for letting me know @bingwang-ms, will fix it today and send a PR.

AntonHryshchuk pushed a commit to AntonHryshchuk/sonic-mgmt that referenced this pull request Jan 4, 2022
…are not resolved (sonic-net#4225)

* Test case enhancement for newly added capability in Fine Grained ECMP to handle packet flow upon no ECMP next-hops being neighbor resolved.
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…lly (#25635)

#### Why I did it
src/sonic-swss
```
* b2c4e649 - (HEAD -> 202511, origin/202511) [202511][ssw][ha] vnetorch support primary/secondary live update for custom bfd (sonic-net#4228) (6 hours ago) [Jing Zhang]
* d317c8f9 - [countersyncd]: Fix cargo bench compiling error (sonic-net#4263) (17 hours ago) [mssonicbld]
* 725d6660 - [HFT]: keep STATE_DB session stream_status in sync with profile stream_state (sonic-net#4190) (22 hours ago) [mssonicbld]
* fa01e8d2 - [countersyncd]: Modify the exit behavior of the main function (sonic-net#4225) (27 hours ago) [mssonicbld]
* 82243e7f - [macsecmgr]: Fix MACsec unconfigure failures due to time out (sonic-net#4233) (2 days ago) [mssonicbld]
* 8d476206 - [ci] Install redis from Debian (sonic-net#4251) (3 days ago) [mssonicbld]
* 0c11b096 - [Bug] This patch is to fix a major bug in the for loop of the (sonic-net#4173) (3 days ago) [ashishalok-arista]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants