Check DHCP servers are routed after link flap in test_dhcp_relay#4251
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Sep 15, 2021
Merged
Check DHCP servers are routed after link flap in test_dhcp_relay#4251bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: bingwang <[email protected]>
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tahmed-dev
approved these changes
Sep 15, 2021
|
|
||
| pytest_assert(wait_until(50, 5, check_link_status, duthost, dhcp_relay['uplink_interfaces'], "up"), | ||
| "Not all uplinks are up") | ||
|
|
Contributor
There was a problem hiding this comment.
is the issue happening if the portchannel consists of one interface and doesn't happen otherwise?
Collaborator
Author
There was a problem hiding this comment.
No, I don't think so. There are two members in each portchannel on this testbed
No. Team Dev Protocol Ports
----- --------------- ----------- ---------------------------
0001 PortChannel0001 LACP(A)(Up) Ethernet0(S) Ethernet4(S)
0002 PortChannel0002 LACP(A)(Up) Ethernet20(S) Ethernet16(S)
0003 PortChannel0003 LACP(A)(Up) Ethernet68(S) Ethernet64(S)
0004 PortChannel0004 LACP(A)(Up) Ethernet84(S) Ethernet80(S)
ghost
approved these changes
Sep 15, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Signed-off-by: bingwang <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (#25635) #### Why I did it src/sonic-swss ``` * b2c4e649 - (HEAD -> 202511, origin/202511) [202511][ssw][ha] vnetorch support primary/secondary live update for custom bfd (sonic-net#4228) (6 hours ago) [Jing Zhang] * d317c8f9 - [countersyncd]: Fix cargo bench compiling error (sonic-net#4263) (17 hours ago) [mssonicbld] * 725d6660 - [HFT]: keep STATE_DB session stream_status in sync with profile stream_state (sonic-net#4190) (22 hours ago) [mssonicbld] * fa01e8d2 - [countersyncd]: Modify the exit behavior of the main function (sonic-net#4225) (27 hours ago) [mssonicbld] * 82243e7f - [macsecmgr]: Fix MACsec unconfigure failures due to time out (sonic-net#4233) (2 days ago) [mssonicbld] * 8d476206 - [ci] Install redis from Debian (sonic-net#4251) (3 days ago) [mssonicbld] * 0c11b096 - [Bug] This patch is to fix a major bug in the for loop of the (sonic-net#4173) (3 days ago) [ashishalok-arista] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang [email protected]
Description of PR
Summary:
Fixes # (issue)
This PR is to fix
test_dhcp_relay_after_link_flapfailure.The root cause for the failure is the default route is not rebuilt after uplink flap when test was running.
This PR addressed the issue by adding a
wait_untilafter link flap to wait until routes to DHCP server are rebuilt.Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to fix
test_dhcp_relay_after_link_flapfailure.How did you do it?
This PR addressed the issue by adding a
wait_untilafter link flap to wait until routes to DHCP server are rebuilt.How did you verify/test it?
Verified on SN4600. All test cases in
test_dhcp_relaypass now.Any platform specific information?
No.
Supported testbed topology if it's a new test case?
No.
Documentation