upgrade cEOS to version 4.25.5.1M, fix the issue of arista endless loop by yejianquan · Pull Request #4228 · sonic-net/sonic-mgmt

yejianquan · 2021-09-10T07:56:19Z

Description of PR

Summary:
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

201911

Approach

What is the motivation for this PR?

cEOS containers' mgmt-ip occasionally unavaillable, upgrade cEOS image version will fix that
cEOS terminal behavior slightly different from vEOS, enhance arista.py to avoid endless loop

How did you do it?

upgrade cEOS image version
break loop if ssh connect returns merely an 'exit', as for other commands who relies on the return e.g. 'show interfaces po1 | json', 'exit' won't appear in input_buffer, so the change won't influence it.

How did you verify/test it?

Run platform_tests/test_advanced_reboot.py test on physical testbed and it didn't stuck again.
Tried run command 'show interfaces po1 | json', it's not influenced.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

wangxin · 2021-09-10T08:25:17Z

ansible/group_vars/all/ceos.yml

-ceos_image_filename: cEOS64-lab-4.23.2F.tar.xz
-ceos_image_orig: ceosimage:4.23.2F
-ceos_image: ceosimage:4.23.2F-1
+ceos_image_filename: cEOS64-lab-4.25.5.1M.tar


The new file is not zipped?

yes, it's docker-importable
It's small, just 8mb bigger than cEOS64-lab-4.23.2F.tar.xz
and in our playbook, we download and import directly without unzip, not sure whether previous one is zipped indeed.

wangxin · 2021-09-10T08:32:08Z

PR test failed:

TASK [vm_set : Download cEOS image] ********************************************
Friday 10 September 2021  08:01:23 +0000 (0:00:00.053)       0:03:21.649 ****** 
fatal: [STR-ACS-VSERV-01]: FAILED! => {"changed": false, "dest": "/home/AzDevOps/veos-vm/images/cEOS64-lab-4.25.5.1M.tar", "elapsed": 0, "msg": "Request failed", "response": "HTTP Error 404: The specified resource does not exist.", "status_code": 404, "url": "https://acsbe.blob.core.windows.net/vmimages/cEOS64-lab-4.25.5.1M.tar?use_own_value"}

yejianquan · 2021-09-10T08:41:45Z

/AZP run

azure-pipelines · 2021-09-10T08:41:54Z

Azure Pipelines successfully started running 1 pipeline(s).

yejianquan · 2021-09-10T08:43:37Z

PR test failed:

TASK [vm_set : Download cEOS image] ********************************************
Friday 10 September 2021  08:01:23 +0000 (0:00:00.053)       0:03:21.649 ****** 
fatal: [STR-ACS-VSERV-01]: FAILED! => {"changed": false, "dest": "/home/AzDevOps/veos-vm/images/cEOS64-lab-4.25.5.1M.tar", "elapsed": 0, "msg": "Request failed", "response": "HTTP Error 404: The specified resource does not exist.", "status_code": 404, "url": "https://acsbe.blob.core.windows.net/vmimages/cEOS64-lab-4.25.5.1M.tar?use_own_value"}

It didn't take right key, I've tried whole add-topo route on a physical server without cEOS images, and it worked well

yxieca · 2021-09-10T16:14:06Z

PR test failed:

TASK [vm_set : Download cEOS image] ********************************************
Friday 10 September 2021  08:01:23 +0000 (0:00:00.053)       0:03:21.649 ****** 
fatal: [STR-ACS-VSERV-01]: FAILED! => {"changed": false, "dest": "/home/AzDevOps/veos-vm/images/cEOS64-lab-4.25.5.1M.tar", "elapsed": 0, "msg": "Request failed", "response": "HTTP Error 404: The specified resource does not exist.", "status_code": 404, "url": "https://acsbe.blob.core.windows.net/vmimages/cEOS64-lab-4.25.5.1M.tar?use_own_value"}

It didn't take right key, I've tried whole add-topo route on a physical server without cEOS images, and it worked well

Check with build team, see how they handles the downloading in public PR tests. The downloading key is not provided. It is likely that they are matching a particular download string and now version changed?

yozhao101 · 2021-09-11T05:59:35Z

/azp run

azure-pipelines · 2021-09-11T05:59:44Z

Azure Pipelines successfully started running 1 pipeline(s).

yejianquan · 2021-09-13T01:59:17Z

/azp run

azure-pipelines · 2021-09-13T01:59:27Z

Azure Pipelines successfully started running 1 pipeline(s).

yejianquan · 2021-09-13T02:34:02Z

/azp run

azure-pipelines · 2021-09-13T02:34:33Z

Azure Pipelines successfully started running 1 pipeline(s).

yejianquan · 2021-09-13T05:40:47Z

/azp run

azure-pipelines · 2021-09-13T05:40:58Z

Azure Pipelines successfully started running 1 pipeline(s).

yejianquan · 2021-09-13T06:22:39Z

/azp run

azure-pipelines · 2021-09-13T06:22:49Z

Azure Pipelines successfully started running 1 pipeline(s).

yejianquan · 2021-09-13T06:53:53Z

/azp run

azure-pipelines · 2021-09-13T06:54:02Z

Azure Pipelines successfully started running 1 pipeline(s).

yejianquan · 2021-09-13T07:25:01Z

/azp run

azure-pipelines · 2021-09-13T07:25:10Z

Azure Pipelines successfully started running 1 pipeline(s).

…dless lopp (#4228)" This reverts commit 81419b8.

…pp (sonic-net#4228) Description of PR Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) Approach What is the motivation for this PR? cEOS containers' mgmt-ip occasionally unavaillable, upgrade cEOS image version will fix that cEOS terminal behavior slightly different from vEOS, enhance arista.py to avoid endless loop How did you do it? upgrade cEOS image version break loop if ssh connect returns merely an 'exit', as for other commands who relies on the return e.g. 'show interfaces po1 | json', 'exit' won't appear in input_buffer, so the change won't influence it. How did you verify/test it? Run platform_tests/test_advanced_reboot.py test on physical testbed and it didn't stuck again. Tried run command 'show interfaces po1 | json', it's not influenced. Co-authored-by: Jianquan Ye <jianquanye@microsoft.com>

…dless lopp (sonic-net#4228)" This reverts commit 81419b8.

…lly (#25635) #### Why I did it src/sonic-swss ``` * b2c4e649 - (HEAD -> 202511, origin/202511) [202511][ssw][ha] vnetorch support primary/secondary live update for custom bfd (sonic-net#4228) (6 hours ago) [Jing Zhang] * d317c8f9 - [countersyncd]: Fix cargo bench compiling error (sonic-net#4263) (17 hours ago) [mssonicbld] * 725d6660 - [HFT]: keep STATE_DB session stream_status in sync with profile stream_state (sonic-net#4190) (22 hours ago) [mssonicbld] * fa01e8d2 - [countersyncd]: Modify the exit behavior of the main function (sonic-net#4225) (27 hours ago) [mssonicbld] * 82243e7f - [macsecmgr]: Fix MACsec unconfigure failures due to time out (sonic-net#4233) (2 days ago) [mssonicbld] * 8d476206 - [ci] Install redis from Debian (sonic-net#4251) (3 days ago) [mssonicbld] * 0c11b096 - [Bug] This patch is to fix a major bug in the for loop of the (sonic-net#4173) (3 days ago) [ashishalok-arista] ``` #### How I did it #### How to verify it #### Description for the changelog

upgrade ceos to version 4.25.5.1M, fix the issue of arista endless lopp

63a2e3c

yejianquan requested review from stepanblyschak, wangxin and yxieca September 10, 2021 07:56

yejianquan requested a review from a team as a code owner September 10, 2021 07:56

wangxin reviewed Sep 10, 2021

View reviewed changes

yejianquan changed the title ~~upgrade cEOS to version 4.25.5.1M, fix the issue of arista endless lopp~~ upgrade cEOS to version 4.25.5.1M, fix the issue of arista endless loop Sep 10, 2021

wangxin approved these changes Sep 13, 2021

View reviewed changes

yejianquan merged commit 81419b8 into sonic-net:master Sep 13, 2021

yxieca added a commit that referenced this pull request Sep 13, 2021

Revert "upgrade ceos to version 4.25.5.1M, fix the issue of arista en…

1719593

…dless lopp (#4228)" This reverts commit 81419b8.

yxieca mentioned this pull request Sep 13, 2021

Revert "upgrade cEOS to version 4.25.5.1M, fix the issue of arista endless loop" #4243

Closed

lguohan added a commit that referenced this pull request Sep 13, 2021

Revert "upgrade ceos to version 4.25.5.1M, fix the issue of arista en…

13a7ea7

…dless lopp (#4228)" This reverts commit 81419b8.

vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021

Revert "upgrade ceos to version 4.25.5.1M, fix the issue of arista en…

038c9fa

…dless lopp (sonic-net#4228)" This reverts commit 81419b8.

Conversation

yejianquan commented Sep 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

wangxin Sep 10, 2021

Choose a reason for hiding this comment

Uh oh!

yejianquan Sep 10, 2021

Choose a reason for hiding this comment

Uh oh!

wangxin commented Sep 10, 2021

Uh oh!

yejianquan commented Sep 10, 2021

Uh oh!

azure-pipelines bot commented Sep 10, 2021

Uh oh!

yejianquan commented Sep 10, 2021

Uh oh!

yxieca commented Sep 10, 2021

Uh oh!

yozhao101 commented Sep 11, 2021

Uh oh!

azure-pipelines bot commented Sep 11, 2021

Uh oh!

yejianquan commented Sep 13, 2021

Uh oh!

azure-pipelines bot commented Sep 13, 2021

Uh oh!

yejianquan commented Sep 13, 2021

Uh oh!

azure-pipelines bot commented Sep 13, 2021

Uh oh!

yejianquan commented Sep 13, 2021

Uh oh!

azure-pipelines bot commented Sep 13, 2021

Uh oh!

yejianquan commented Sep 13, 2021

Uh oh!

azure-pipelines bot commented Sep 13, 2021

Uh oh!

yejianquan commented Sep 13, 2021

Uh oh!

azure-pipelines bot commented Sep 13, 2021

Uh oh!

yejianquan commented Sep 13, 2021

Uh oh!

azure-pipelines bot commented Sep 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yejianquan commented Sep 10, 2021 •

edited

Loading