Remove skip_traffic_test fixture in acl tests#15366
Merged
wangxin merged 2 commits intosonic-net:masterfrom Nov 7, 2024
Merged
Remove skip_traffic_test fixture in acl tests#15366wangxin merged 2 commits intosonic-net:masterfrom
wangxin merged 2 commits intosonic-net:masterfrom
Conversation
wangxin
approved these changes
Nov 7, 2024
veronica-arista
pushed a commit
to veronica-arista/sonic-mgmt
that referenced
this pull request
Nov 7, 2024
What is the motivation for this PR? Currently we are using conditional mark to add marker, then use pytest hook to redirect testutils.verify function to a function always return True to skip traffic test. With this change, the skip_traffic_test fixture is no longer needed in test cases, streamlining the test code and improving clarity. How did you do it? Remove skip_traffic_test in testcases How did you verify/test it?
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
What is the motivation for this PR? Currently we are using conditional mark to add marker, then use pytest hook to redirect testutils.verify function to a function always return True to skip traffic test. With this change, the skip_traffic_test fixture is no longer needed in test cases, streamlining the test code and improving clarity. How did you do it? Remove skip_traffic_test in testcases How did you verify/test it?
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
What is the motivation for this PR? Currently we are using conditional mark to add marker, then use pytest hook to redirect testutils.verify function to a function always return True to skip traffic test. With this change, the skip_traffic_test fixture is no longer needed in test cases, streamlining the test code and improving clarity. How did you do it? Remove skip_traffic_test in testcases How did you verify/test it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Currently we are using conditional mark to add marker, then use pytest hook to redirect testutils.verify function to a function always return True to skip traffic test. With this change, the skip_traffic_test fixture is no longer needed in test cases, streamlining the test code and improving clarity.
How did you do it?
Remove skip_traffic_test in testcases
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation