[minigraph_facts] support PortChannel inside Vlan, improve module fail message#3123
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Mar 10, 2021
Merged
Conversation
|
This pull request fixes 2 alerts when merging 1d96955 into 11ed1e7 - view on LGTM.com fixed alerts:
|
shi-su
reviewed
Mar 10, 2021
|
This pull request fixes 2 alerts when merging 45a73f0 into 42bbc2e - view on LGTM.com fixed alerts:
|
shi-su
approved these changes
Mar 10, 2021
yxieca
approved these changes
Mar 10, 2021
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atically (sonic-net#17849) src/sonic-utilities * 7a7305e9 - (HEAD -> 202205, origin/202205) Fix issue: out of range sflow polling interval is accepted and stored in config_db (sonic-net#2847) (sonic-net#3123) (3 hours ago) [Stephen Sun] * 06d11339 - [config] config reload should generate sysinfo if missing (sonic-net#3031) (sonic-net#3126) (21 hours ago) [jingwenxie] * bef96a1d - [202205] Allow using latest sonic-swss-common build even if tests failed (sonic-net#3127) (4 days ago) [Saikrishna Arcot]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
If there is PortChannel inside Vlan, original code with throw and the module will fail with a short message like
Type of change
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Test
vlan/test_vlan.pywithAny platform specific information?
Supported testbed topology if it's a new test case?
Documentation