Skip to content

[minigraph_facts] support PortChannel inside Vlan, improve module fail message#3123

Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom
qiluo-msft:qiluo/minigraph_po
Mar 10, 2021
Merged

[minigraph_facts] support PortChannel inside Vlan, improve module fail message#3123
qiluo-msft merged 2 commits intosonic-net:masterfrom
qiluo-msft:qiluo/minigraph_po

Conversation

@qiluo-msft
Copy link
Contributor

@qiluo-msft qiluo-msft commented Mar 10, 2021

Description of PR

If there is PortChannel inside Vlan, original code with throw and the module will fail with a short message like

E           RunAnsibleModuleFail: run module minigraph_facts failed, Ansible Results =>
E           {
E               "changed": false,
E               "failed": true,
E               "invocation": {
E                   "module_args": {
E                       "filename": null,
E                       "host": "str-msn2700-20"
E                   }
E               },
E               "msg": "PortChannel101"
E           }

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Test vlan/test_vlan.py with

  1. DUT SKU: Mellanox-SN2700-D48C8
  2. topo: t0-56-po2vlan

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@qiluo-msft qiluo-msft requested a review from a team as a code owner March 10, 2021 03:29
@qiluo-msft qiluo-msft requested review from shi-su and wangxin March 10, 2021 03:29
@lgtm-com
Copy link

lgtm-com bot commented Mar 10, 2021

This pull request fixes 2 alerts when merging 1d96955 into 11ed1e7 - view on LGTM.com

fixed alerts:

  • 2 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Mar 10, 2021

This pull request fixes 2 alerts when merging 45a73f0 into 42bbc2e - view on LGTM.com

fixed alerts:

  • 2 for Unused local variable

@qiluo-msft qiluo-msft merged commit d1f3510 into sonic-net:master Mar 10, 2021
@qiluo-msft qiluo-msft deleted the qiluo/minigraph_po branch March 10, 2021 23:14
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…atically (sonic-net#17849)

src/sonic-utilities

* 7a7305e9 - (HEAD -> 202205, origin/202205) Fix issue: out of range sflow polling interval is accepted and stored in config_db (sonic-net#2847) (sonic-net#3123) (3 hours ago) [Stephen Sun]
* 06d11339 - [config] config reload should generate sysinfo if missing  (sonic-net#3031) (sonic-net#3126) (21 hours ago) [jingwenxie]
* bef96a1d - [202205] Allow using latest sonic-swss-common build even if tests failed (sonic-net#3127) (4 days ago) [Saikrishna Arcot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants