[dualtor] Add neighbor entry orchagent testcase#3031
Merged
lolyu merged 4 commits intosonic-net:masterfrom Apr 15, 2021
Merged
Conversation
lolyu
force-pushed
the
add_test_server_neighbor
branch
2 times, most recently
from
f1e8bb6 to
8006bc4
Compare
lolyu
changed the title
bingwang-ms
reviewed
Mar 3, 2021
bingwang-ms
reviewed
Mar 3, 2021
bingwang-ms
reviewed
Mar 3, 2021
bingwang-ms
reviewed
Mar 3, 2021
lolyu
force-pushed
the
add_test_server_neighbor
branch
from
8006bc4 to
5f16a54
Compare
Collaborator
Author
|
depends on #3098 |
Collaborator
Author
|
/AZP run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
force-pushed
the
add_test_server_neighbor
branch
from
5f16a54 to
b30f474
Compare
Collaborator
Author
|
/AZP run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/AZP run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vaibhavhd
reviewed
Mar 18, 2021
tests/dualtor/test_t1_to_standby.py
Outdated
Contributor
There was a problem hiding this comment.
Would it not be better if we send traffic to all/multiple servers, and then verify that the traffic is dropped only for the server whose neighbor entry has been removed?
tests/dualtor/test_t1_to_standby.py
Outdated
Contributor
There was a problem hiding this comment.
How did we decide to send 10 packets and not more? I think 10 packets are too less to verify close to real operational scenario.
Contributor
|
Please change the filename to be more specific than just |
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
lolyu
force-pushed
the
add_test_server_neighbor
branch
from
b30f474 to
6812e0b
Compare
lolyu
changed the title
| testutils.send(ptfadapter, int(ptf_t1_intf.strip("eth")), pkt, count=10) | ||
|
|
||
| logging.info("send traffic to server %s after removing neighbor entry", server_ipv4) | ||
| tunnel_monitor.existing = False |
Contributor
There was a problem hiding this comment.
Is there a reason we did this instead of just creating a new tunnel_traffic_monitor?
theasianpianist
approved these changes
Apr 14, 2021
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Collaborator
Author
|
Hi @theasianpianist, could you please give another look at the new changes? |
lolyu
force-pushed
the
add_test_server_neighbor
branch
from
900e7e4 to
4cd0ed8
Compare
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
lolyu
force-pushed
the
add_test_server_neighbor
branch
from
4cd0ed8 to
bb574a7
Compare
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Collaborator
Author
|
|
This pull request fixes 1 alert when merging 1c065b1 into 94ffb11 - view on LGTM.com fixed alerts:
|
Contributor
|
lgtm |
Contributor
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saravanansv
pushed a commit
to saravanansv/sonic-mgmt
that referenced
this pull request
May 6, 2021
Approach What is the motivation for this PR? Verify that, for standby ToR, the traffic to the server will be dropped if the neighbor entry of server is removed. How did you do it? Verify that the traffic to server is neither passed to server directly by standby ToR or encapsulated to the active ToR. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Approach What is the motivation for this PR? Verify that, for standby ToR, the traffic to the server will be dropped if the neighbor entry of server is removed. How did you do it? Verify that the traffic to server is neither passed to server directly by standby ToR or encapsulated to the active ToR. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atically (sonic-net#17849) src/sonic-utilities * 7a7305e9 - (HEAD -> 202205, origin/202205) Fix issue: out of range sflow polling interval is accepted and stored in config_db (sonic-net#2847) (sonic-net#3123) (3 hours ago) [Stephen Sun] * 06d11339 - [config] config reload should generate sysinfo if missing (sonic-net#3031) (sonic-net#3126) (21 hours ago) [jingwenxie] * bef96a1d - [202205] Allow using latest sonic-swss-common build even if tests failed (sonic-net#3127) (4 days ago) [Saikrishna Arcot]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify that, for standby ToR, the traffic to the server will be dropped if the neighbor entry of server is removed.
Signed-off-by: Longxiang Lyu lolv@microsoft.com
Description of PR
Summary:
Fixes #2805
Type of change
Approach
What is the motivation for this PR?
Verify that, for standby ToR, the traffic to the server will be dropped if the neighbor entry of server is removed.
How did you do it?
Verify that the traffic to server is neither passed to server directly by standby ToR or encapsulated to the active ToR.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation