Skip to content

[sflow]Remove workaround patch on setup phase because CLI command has been fixed.#2847

Merged
yxieca merged 1 commit intosonic-net:masterfrom
chaoskao:sflow_remove_workaround
Jan 28, 2021
Merged

[sflow]Remove workaround patch on setup phase because CLI command has been fixed.#2847
yxieca merged 1 commit intosonic-net:masterfrom
chaoskao:sflow_remove_workaround

Conversation

@chaoskao
Copy link
Contributor

Description of PR

Summary:
The work around patch should be remove because the CLI command "config vlan member del" has been fixed in PR #1038.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Sflow test always failed causes VLAN 1000 already has this VLAN member, should not add again.

How did you do it?

Remove the workaround patch for add VLAN member.

How did you verify/test it?

  • Check the CLI command has been fixed this issue which mentioned in issue 2665.
  • Execution the sflow pytest and it's show passed.

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

No.

Documentation

No.

@chaoskao chaoskao changed the title Remove workaround patch causes CLI command has been fixed. Remove workaround patch on setup stage because CLI command has been fixed. Jan 22, 2021
@chaoskao chaoskao changed the title Remove workaround patch on setup stage because CLI command has been fixed. [Sflow]Remove workaround patch on setup phase because CLI command has been fixed. Jan 22, 2021
@chaoskao chaoskao changed the title [Sflow]Remove workaround patch on setup phase because CLI command has been fixed. [sflow]Remove workaround patch on setup phase because CLI command has been fixed. Jan 22, 2021
@yxieca yxieca merged commit 1b93be8 into sonic-net:master Jan 28, 2021
@chaoskao chaoskao deleted the sflow_remove_workaround branch January 29, 2021 03:08
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…atically (sonic-net#17849)

src/sonic-utilities

* 7a7305e9 - (HEAD -> 202205, origin/202205) Fix issue: out of range sflow polling interval is accepted and stored in config_db (sonic-net#2847) (sonic-net#3123) (3 hours ago) [Stephen Sun]
* 06d11339 - [config] config reload should generate sysinfo if missing  (sonic-net#3031) (sonic-net#3126) (21 hours ago) [jingwenxie]
* bef96a1d - [202205] Allow using latest sonic-swss-common build even if tests failed (sonic-net#3127) (4 days ago) [Saikrishna Arcot]
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…atically (sonic-net#15422)

#### Why I did it
src/sonic-utilities
```
* 1246bc81 - (HEAD -> 202211, origin/202211) [config reload]Config Reload Enhancement (sonic-net#2693) (sonic-net#2863) (2 days ago) [Sudharsan Dhamal Gopalarathnam]
* d69aae4d - [vlan][dhcp_relay] Clear dhcpv6 relay counter while deleting vlan (sonic-net#2852) (2 days ago) [Yaqiang Zhu]
* 0f6bf8ac - [config]: Dynamically start and stop ndppd (sonic-net#2814) (2 days ago) [Lawrence Lee]
* 48a63ff1 - Fix issue: out of range sflow polling interval is accepted and stored in config_db (sonic-net#2847) (2 days ago) [Junchao-Mellanox]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants