Skip to content

[pfc] Refactor pfc pause test to use existing libs and code cleanup#2863

Merged
neethajohn merged 4 commits intosonic-net:masterfrom
neethajohn:refactor_pfc_pause
Feb 19, 2021
Merged

[pfc] Refactor pfc pause test to use existing libs and code cleanup#2863
neethajohn merged 4 commits intosonic-net:masterfrom
neethajohn:refactor_pfc_pause

Conversation

@neethajohn
Copy link
Contributor

Signed-off-by: Neetha John nejo@microsoft.com

Description of PR

This PR contains the following changes

  • Refactor pfc pause test to use existing helpers for storm generation
  • Enumerate testcase based on priorities for easier debugging
  • Collect all errors and assert at the end to allow test to run on all background priorities
  • Added a debug option in ptftests to allow captured packets to be dumped into a file for post test analysis
  • Cleanup trailing white spaces

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

How did you verify/test it?

Ran the test with the changes on Th and it passed

Signed-off-by: Neetha John <nejo@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2021

This pull request introduces 2 alerts and fixes 3 when merging 75277e2 into 2f0b561 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

fixed alerts:

  • 3 for Unused import

Signed-off-by: Neetha John <nejo@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2021

This pull request introduces 1 alert and fixes 3 when merging 38e7524 into 15793fb - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 3 for Unused import

@yxieca
Copy link
Collaborator

yxieca commented Jan 26, 2021

retest vsimage please

@yxieca
Copy link
Collaborator

yxieca commented Feb 17, 2021

/Azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Neetha John <nejo@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Feb 18, 2021

This pull request introduces 1 alert and fixes 3 when merging 64b2de1 into 856c106 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 3 for Unused import

Signed-off-by: Neetha John <nejo@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Feb 18, 2021

This pull request fixes 3 alerts when merging 0d155a1 into 856c106 - view on LGTM.com

fixed alerts:

  • 3 for Unused import

@neethajohn neethajohn merged commit 33631db into sonic-net:master Feb 19, 2021
@neethajohn neethajohn deleted the refactor_pfc_pause branch February 19, 2021 01:18
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…atically (sonic-net#15422)

#### Why I did it
src/sonic-utilities
```
* 1246bc81 - (HEAD -> 202211, origin/202211) [config reload]Config Reload Enhancement (sonic-net#2693) (sonic-net#2863) (2 days ago) [Sudharsan Dhamal Gopalarathnam]
* d69aae4d - [vlan][dhcp_relay] Clear dhcpv6 relay counter while deleting vlan (sonic-net#2852) (2 days ago) [Yaqiang Zhu]
* 0f6bf8ac - [config]: Dynamically start and stop ndppd (sonic-net#2814) (2 days ago) [Lawrence Lee]
* 48a63ff1 - Fix issue: out of range sflow polling interval is accepted and stored in config_db (sonic-net#2847) (2 days ago) [Junchao-Mellanox]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants