[test_show_ndp] Filter out arp entries with no MAC address#2691
Merged
lolyu merged 1 commit intosonic-net:masterfrom Dec 22, 2020
Merged
[test_show_ndp] Filter out arp entries with no MAC address#2691lolyu merged 1 commit intosonic-net:masterfrom
lolyu merged 1 commit intosonic-net:masterfrom
Conversation
aeea260 to
0121e60
Compare
bingwang-ms
approved these changes
Dec 21, 2020
0121e60 to
f662e49
Compare
As `nbrshow` only shows entries that has `lldaddr`, we need to enforce same behavior to filter out entries without MAC address, to guarantee it will be shown in the output of `show ndp`. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
f662e49 to
bf2b37e
Compare
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…sonic-net#14120) linkmgrd: * 046bdd0 2023-03-06 | [active-active] add state transition handler for (LinkProber: Unknown, MuxState: Active, LinkState: Down) (sonic-net#179) (HEAD -> 202205) [Jing Zhang] * 15ba715 2023-03-06 | loose link down swithcover condition (sonic-net#178) [Jing Zhang] utilities: * 51d9c9f6 2023-03-06 | [warm/fast-reboot] Backup logs from tmpfs to disk during fast/warm shutdown (sonic-net#2714) (HEAD -> 202205) [Vaibhav Hemant Dixit] * 03aa77b3 2023-03-02 | [ci] Fix pipeline issue caused by sonic-slave-* change. (sonic-net#2709) [Liu Shilong] * 4bd7d4f1 2023-03-03 | [db_migrator] Add missing attribute 'weight' to route entries in APPL DB (sonic-net#2691) [Vaibhav Hemant Dixit] * 69a60397 2023-03-01 | removed duplicates and resolved conflicts (sonic-net#2674) (github/202205) [kannankvs] platform-daemon: * 10bc119 2023-03-06 | [ycable] add changes for correcting telemetry values for 'active-active' (sonic-net#341) (HEAD -> 202205) [vdahiya12] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…net#14264) src/sonic-platform-common * 8460721 - (HEAD -> 202205, origin/202205) Fix issues in cmis.get_transceiver_bulk_status (sonic-net#351) (10 hours ago) [Stephen Sun] src/sonic-sairedis * 10f37ef - (HEAD -> 202205, origin/202205) Ignore removing switch for mellanox platform due to known limitation (sonic-net#1216) (10 hours ago) [Junchao-Mellanox] src/sonic-swss * 5f031af - (HEAD -> 202205, origin/202205) [flowcounterrouter] Fix the Route remove flow for non-bound prefixes (sonic-net#2691) (10 hours ago) [Vivek] src/sonic-utilities * f88ca1c9 - (HEAD -> 202205, origin/202205) Improve show acl commands (sonic-net#2667) (10 hours ago) [bingwang-ms] * 738406b7 - Enhance the logic to wait for all buffer tables to be removed in _clear_qos (sonic-net#2720) (10 hours ago) [Stephen Sun] How I did it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
As
nbrshowonly shows entries that haslldaddr, we need to enforcesame behavior to filter out entries without MAC address, to guarantee it
will be shown in the output of
show ndp.Signed-off-by: Longxiang Lyu lolv@microsoft.com
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
The output of
ip neighmight containsFAILEDentries like the following withoutlladdr:And those entries will be excluded by
nbrshow, which will be called byshow nbr.In this case,
test_show_ndpwill fail due to the failure to find a match for thoseFAILEDarp entries.How did you do it?
Let
test_show_ndponly checks entries that haslladdr.How did you verify/test it?
Test
test_show_ndpAny platform specific information?
Arista 7060 T1
Supported testbed topology if it's a new test case?
Documentation