Skip to content

[test_show_ndp] Filter out arp entries with no MAC address#2691

Merged
lolyu merged 1 commit intosonic-net:masterfrom
lolyu:fix_iface_namingmode_ndp
Dec 22, 2020
Merged

[test_show_ndp] Filter out arp entries with no MAC address#2691
lolyu merged 1 commit intosonic-net:masterfrom
lolyu:fix_iface_namingmode_ndp

Conversation

@lolyu
Copy link
Copy Markdown
Collaborator

@lolyu lolyu commented Dec 21, 2020

Description of PR

As nbrshow only shows entries that has lldaddr, we need to enforce
same behavior to filter out entries without MAC address, to guarantee it
will be shown in the output of show ndp.

Signed-off-by: Longxiang Lyu lolv@microsoft.com

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

The output of ip neigh might contains FAILED entries like the following without lladdr:

fe80::2a99:3aff:fe17:1c8c dev Ethernet112  FAILED
fe80::2a99:3aff:fe17:1c8c dev Ethernet80  FAILED
fe80::2a99:3aff:fe17:1c8c dev Ethernet68  FAILED

And those entries will be excluded by nbrshow, which will be called by show nbr.
In this case, test_show_ndp will fail due to the failure to find a match for those FAILED arp entries.

How did you do it?

Let test_show_ndp only checks entries that has lladdr.

How did you verify/test it?

Test test_show_ndp

iface_namingmode/test_iface_namingmode.py::TestNeighbors::test_show_ndp[alias] PASSED                                                                                       [ 50%]
iface_namingmode/test_iface_namingmode.py::TestNeighbors::test_show_ndp[default] PASSED                                                                                     [100%]

Any platform specific information?

Arista 7060 T1

Supported testbed topology if it's a new test case?

Documentation

@lolyu lolyu requested a review from a team December 21, 2020 09:22
@lolyu lolyu force-pushed the fix_iface_namingmode_ndp branch from aeea260 to 0121e60 Compare December 21, 2020 09:23
@lolyu lolyu force-pushed the fix_iface_namingmode_ndp branch from 0121e60 to f662e49 Compare December 22, 2020 03:37
As `nbrshow` only shows entries that has `lldaddr`, we need to enforce
same behavior to filter out entries without MAC address, to guarantee it
will be shown in the output of `show ndp`.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@lolyu lolyu force-pushed the fix_iface_namingmode_ndp branch from f662e49 to bf2b37e Compare December 22, 2020 03:45
@lolyu lolyu merged commit fc9bd4b into sonic-net:master Dec 22, 2020
@lolyu lolyu deleted the fix_iface_namingmode_ndp branch December 22, 2020 06:23
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…sonic-net#14120)

linkmgrd:
* 046bdd0 2023-03-06 | [active-active] add state transition handler for (LinkProber: Unknown, MuxState: Active, LinkState: Down) (sonic-net#179) (HEAD -> 202205) [Jing Zhang]
* 15ba715 2023-03-06 | loose link down swithcover condition (sonic-net#178) [Jing Zhang]

utilities:
* 51d9c9f6 2023-03-06 | [warm/fast-reboot] Backup logs from tmpfs to disk during fast/warm shutdown (sonic-net#2714) (HEAD -> 202205) [Vaibhav Hemant Dixit]
* 03aa77b3 2023-03-02 | [ci] Fix pipeline issue caused by sonic-slave-* change. (sonic-net#2709) [Liu Shilong]
* 4bd7d4f1 2023-03-03 | [db_migrator] Add missing attribute 'weight' to route entries in APPL DB (sonic-net#2691) [Vaibhav Hemant Dixit]
* 69a60397 2023-03-01 | removed duplicates and resolved conflicts (sonic-net#2674) (github/202205) [kannankvs]

platform-daemon:
* 10bc119 2023-03-06 | [ycable] add changes for correcting telemetry values for 'active-active' (sonic-net#341) (HEAD -> 202205) [vdahiya12]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…net#14264)

src/sonic-platform-common

* 8460721 - (HEAD -> 202205, origin/202205) Fix issues in cmis.get_transceiver_bulk_status (sonic-net#351) (10 hours ago) [Stephen Sun]
src/sonic-sairedis

* 10f37ef - (HEAD -> 202205, origin/202205) Ignore removing switch for mellanox platform due to known limitation (sonic-net#1216) (10 hours ago) [Junchao-Mellanox]
src/sonic-swss

* 5f031af - (HEAD -> 202205, origin/202205) [flowcounterrouter] Fix the Route remove flow for non-bound prefixes (sonic-net#2691) (10 hours ago) [Vivek]
src/sonic-utilities

* f88ca1c9 - (HEAD -> 202205, origin/202205) Improve show acl commands (sonic-net#2667) (10 hours ago) [bingwang-ms]
* 738406b7 - Enhance the logic to wait for all buffer tables to be removed in _clear_qos (sonic-net#2720) (10 hours ago) [Stephen Sun]
How I did it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants