Skip to content

[test_fan_drawer_fans] Fix test_fan_drawer_fans on API tests #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangxin merged 2 commits into from
Jan 4, 2021
Merged

[test_fan_drawer_fans] Fix test_fan_drawer_fans on API tests #2668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f579c8d
Fix test_fan_drawer_fans on API test
Dec 14, 2020
6582ed3
Remove "orange" color since we already have "amber"
shlomibitton Dec 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 39 additions & 17 deletions tests/platform_tests/api/test_fan_drawer_fans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
def gather_facts(request, duthost):
# Get platform facts from platform.json file
request.cls.chassis_facts = duthost.facts.get("chassis")
request.cls.asic_type = duthost.facts.get("asic_type")


@pytest.mark.usefixtures("gather_facts")
Expand Down Expand Up @@ -260,30 +261,51 @@ def test_set_fans_speed(self, duthost, localhost, platform_api_conn):
self.assert_expectations()

def test_set_fans_led(self, duthost, localhost, platform_api_conn):
LED_COLOR_LIST = [
"off",
"red",
"amber",
"green",

FAULT_LED_COLOR_LIST = [
STATUS_LED_COLOR_AMBER,
STATUS_LED_COLOR_RED
]

NORMAL_LED_COLOR_LIST = [
STATUS_LED_COLOR_GREEN
]

for j in range(self.num_fan_drawers):
num_fans = fan_drawer.get_num_fans(platform_api_conn, j)
OFF_LED_COLOR_LIST = [
STATUS_LED_COLOR_OFF
]

for i in range(num_fans):
LED_COLOR_TYPES = []
LED_COLOR_TYPES.append(FAULT_LED_COLOR_LIST)
LED_COLOR_TYPES.append(NORMAL_LED_COLOR_LIST)

for color in LED_COLOR_LIST:
# Mellanox is not supporting set leds to 'off'
if self.asic_type != "mellanox":
LED_COLOR_TYPES.append(OFF_LED_COLOR_LIST)

result = fan_drawer_fan.set_status_led(platform_api_conn, j, i, color)
if self.expect(result is not None, "Failed to perform set_status_led"):
self.expect(result is True, "Failed to set status_led for fan drawer {} fan {} to {}".format(j , i, color))
LED_COLOR_TYPES_DICT = {
0: "fault",
1: "normal",
2: "off"
}

color_actual = fan_drawer_fan.get_status_led(platform_api_conn, j, i)
for j in range(self.num_fan_drawers):
num_fans = fan_drawer.get_num_fans(platform_api_conn, j)

if self.expect(color_actual is not None, "Failed to retrieve status_led"):
if self.expect(isinstance(color_actual, STRING_TYPE), "Status LED color appears incorrect"):
self.expect(color == color_actual, "Status LED color incorrect (expected: {}, actual: {} for fan {})".format(
color, color_actual, i))
for i in range(num_fans):
for index, led_type in enumerate(LED_COLOR_TYPES):
led_type_result = False
for color in led_type:
result = fan_drawer_fan.set_status_led(platform_api_conn, j, i, color)
if self.expect(result is not None, "Failed to perform set_status_led"):
led_type_result = result or led_type_result
if ((result is None) or (not result)):
continue
color_actual = fan_drawer_fan.get_status_led(platform_api_conn, j, i)
if self.expect(color_actual is not None, "Failed to retrieve status_led"):
if self.expect(isinstance(color_actual, STRING_TYPE), "Status LED color appears incorrect"):
self.expect(color == color_actual, "Status LED color incorrect (expected: {}, actual: {} for fan {})".format(
color, color_actual, i))
self.expect(result is True, "Failed to set status_led for fan drawer {} fan {} to {}".format(j , i, LED_COLOR_TYPES_DICT[index]))

self.assert_expectations()