Skip to content

[minigraph-gen]Find port alias column by header name if exist#262

Merged
maggiemsft merged 2 commits intosonic-net:masterfrom
maggiemsft:masun/portalias
Oct 2, 2017
Merged

[minigraph-gen]Find port alias column by header name if exist#262
maggiemsft merged 2 commits intosonic-net:masterfrom
maggiemsft:masun/portalias

Conversation

@maggiemsft
Copy link
Contributor

We are adding more columns in port_config.ini file, line port speed, and the location of alias name may change.

else:
self.portmap.append(mapping[2])
index = 0
if re.match('^#', lines[0].strip()):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you refer to this pull request and store all the information in the port_config.ini file accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when building docker-sonic-mgmt, it will install the device package which include all port_config.ini files to the correct location in docker-sonic-mgmt. Is this what you want?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I didn't add the link to my previous comment: https://github.com/Azure/sonic-swss/pull/287/files this pull request has a better logic to parse the port_config.ini file.

Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check comments

@sonic-net sonic-net deleted a comment from msftclas Sep 27, 2017
@jleveque
Copy link
Contributor

jleveque commented Oct 2, 2017

I think the title of this PR would be more accurate as, "[minigraph-gen] Find port alias column by header name if exist"

@maggiemsft maggiemsft changed the title [minigraph-gen]find port name column by header name if exist [minigraph-gen]Find port alias column by header name if exist Oct 2, 2017
@maggiemsft maggiemsft merged commit 1e9f977 into sonic-net:master Oct 2, 2017
@maggiemsft maggiemsft deleted the masun/portalias branch January 4, 2018 06:10
sdszhang pushed a commit to sdszhang/sonic-mgmt that referenced this pull request May 14, 2025
…net#262)

Cherry-pick PR for sonic-net#17861 in sonic-mgmt.

Summary: This is to add a test case to verify that after enabling
proxy_arp, there is no L2 flooding in downstream VLAN even though the
switch does not have a FDB entry to forward a downstream SRv6 packet.
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…atically (sonic-net#16576)

#### Why I did it
src/sonic-snmpagent
```
* 64f0def - (HEAD -> 202012, origin/202012) Support interface speed for PortChannels (sonic-net#262) (2 days ago) [Lukas Stockner]
```
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…atically (sonic-net#16877)

src/sonic-snmpagent

* 17a8bb2 - (HEAD -> 202205, origin/202205) Add ifhighspeed UT (sonic-net#296) (5 minutes ago) [Hua Liu]
* b5a52ff - Fix key missing exception when invalied transiver info in STATE_DB (sonic-net#289) (5 minutes ago) [Hua Liu]
* 09bb0c2 - Fix FdbUpdater crash when SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID attribute missing. (sonic-net#286) (5 minutes ago) [Hua Liu]
* 792e403 - Support interface speed for PortChannels (sonic-net#262) (5 minutes ago) [Lukas Stockner]
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…verlay SNMP (sonic-net#2721)

* [snmpagent][swss-common] advance sub module head to include overlay SNMP

Submodule src/sonic-snmpagent 0f2bbd7..26f0495:
  > Remove verbose feature missing logs (sonic-net#102)
  > Enable overriding interface counters OIDs (sonic-net#98)

Submodule src/sonic-swss-common 5f4abd9..36fd5e9:
  > Add new DB index for SNMP_OVERLAY_DB (sonic-net#262)

Note: overlay DB also requires change in swss-common, which has been
      moved ahead.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [utilities] advance utilities sub-module head

Submodule src/sonic-utilities 9d9aaa0..d1070b2:
  > [warm-reboot] initialize warm reboot state table before warm rebooting (sonic-net#492)
  > Allow config shutdown and startup operations on valid PortChannel interface names (sonic-net#474)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
8b9cab7 2023-10-26 [201911] Fix IfHighSpeed UT issue on 201911 (sonic-net#299) 
622b771 2023-10-13 | Fix backup port rfc2863 UT to 202012 branch issue (sonic-net#298) [Hua Liu]
fa94798 2023-10-11 | Add ifhighspeed UT (sonic-net#296) [Hua Liu]
41789ca 2023-09-14 | Support interface speed for PortChannels (sonic-net#262) [Lukas Stockner]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants