Test TX drop counter on oper down#17014
Open
BYGX-wcr wants to merge 2 commits intosonic-net:masterfrom
Open
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@kevinskwang , can you please review this PR? This is a part of the test gap hackathon. |
Collaborator
|
hi @alawing @kevinwangsk could you help to review the new test case? |
| 'TX_DROP counters should not be incremented when the interface is administratively down') | ||
|
|
||
| # recover the neighbor interface | ||
| nbrhosts[neighbor]['host'].no_shutdown(neighbor_intf) |
Contributor
There was a problem hiding this comment.
It's better to move to intf shut/unshut to a fixture that handles test setup and teardown, that way the intf will be brought back up even if the test fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Add a test case that verifies the TX_DROP counter will not be increased when an interface is oper down.
Fixes #15874 (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation