Added consistency checker to all relevant advanced-reboot cases#16877
Merged
StormLiangMS merged 8 commits intosonic-net:masterfrom Feb 24, 2025
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Ryangwaite
requested review from
ryanzhu706,
saiarcot895 and
vaibhavhd
and removed request for
prgeor
Collaborator
|
/azp run |
|
Pull request contains merge conflicts. |
saiarcot895
reviewed
Feb 12, 2025
saiarcot895
reviewed
Feb 12, 2025
Ryangwaite
force-pushed
the
add-consistency-checker-to-all-advanced-reboot-test-cases
branch
from
4e5ddc9 to
349eaab
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Now need to explicitly state all the attributes you want to get, not the ones you want to omit. This is to make it safer now that it was found that querying some attributes include write operations.
Ryangwaite
force-pushed
the
add-consistency-checker-to-all-advanced-reboot-test-cases
branch
from
349eaab to
66d7d73
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This clarifies what the array actually resembles.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vaibhavhd
reviewed
Feb 19, 2025
vaibhavhd
reviewed
Feb 20, 2025
vaibhavhd
reviewed
Feb 20, 2025
tests/common/fixtures/consistency_checker/consistency_checker.py
Outdated
Show resolved
Hide resolved
vaibhavhd
reviewed
Feb 20, 2025
vaibhavhd
reviewed
Feb 20, 2025
vaibhavhd
reviewed
Feb 20, 2025
vaibhavhd
reviewed
Feb 20, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
An ASIC reset happens during this test case so the consistency check is irrelevant
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vaibhavhd
approved these changes
Feb 21, 2025
saiarcot895
approved these changes
Feb 22, 2025
Contributor
Author
|
@StormLiangMS can you help to merge this? |
nhe-NV
pushed a commit
to nhe-NV/sonic-mgmt
that referenced
this pull request
Feb 26, 2025
…c-net#16877) Description of PR Summary: Added consistency checker to all relevant advanced-reboot cases and added minor improvements including: Ignoring NULL values in ASIC querying Logging ASIC/DB inconsistencies Fixes # (issue)
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
…c-net#16877) Description of PR Summary: Added consistency checker to all relevant advanced-reboot cases and added minor improvements including: Ignoring NULL values in ASIC querying Logging ASIC/DB inconsistencies Fixes # (issue)
This was referenced Apr 28, 2025
Ryangwaite
added a commit
to Ryangwaite/sonic-mgmt
that referenced
this pull request
Apr 28, 2025
…c-net#16877) Description of PR Summary: Added consistency checker to all relevant advanced-reboot cases and added minor improvements including: Ignoring NULL values in ASIC querying Logging ASIC/DB inconsistencies Fixes # (issue)
11 tasks
Ryangwaite
added a commit
to Ryangwaite/sonic-mgmt
that referenced
this pull request
Apr 28, 2025
…c-net#16877) Description of PR Summary: Added consistency checker to all relevant advanced-reboot cases and added minor improvements including: Ignoring NULL values in ASIC querying Logging ASIC/DB inconsistencies Fixes # (issue)
Ryangwaite
added a commit
to Ryangwaite/sonic-mgmt
that referenced
this pull request
Apr 28, 2025
…c-net#16877) Description of PR Summary: Added consistency checker to all relevant advanced-reboot cases and added minor improvements including: Ignoring NULL values in ASIC querying Logging ASIC/DB inconsistencies Fixes # (issue)
Ryangwaite
added a commit
to Ryangwaite/sonic-mgmt
that referenced
this pull request
Apr 28, 2025
…c-net#16877) Description of PR Summary: Added consistency checker to all relevant advanced-reboot cases and added minor improvements including: Ignoring NULL values in ASIC querying Logging ASIC/DB inconsistencies Fixes # (issue)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Added consistency checker to all relevant advanced-reboot cases and added minor improvements including:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation