Closed
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kishanps
reviewed
Jan 30, 2025
tests/gnmi/test_gnoi_system.py
Outdated
| duthost = duthosts[rand_one_dut_hostname] | ||
|
|
||
| # Trigger reboot with invalid method | ||
| ret, msg = gnoi_request(duthost, localhost, "Reboot", '{"method": 2}') |
Contributor
There was a problem hiding this comment.
2 is still a valid method per https://github.com/openconfig/gnoi/blob/0d0e73a9bd74ee5b32b145cb06ac0f613f89ed0c/system/system.proto#L131
cc: @ndas7
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Jan 31, 2025
| pytest_assert(ret == 0, "System.Reboot API reported failure (rc = {}) with message: {}".format(ret, msg)) | ||
| logging.info("System.Reboot API returned msg: {}".format(msg)) | ||
|
|
||
| # Get reboot status |
Contributor
11 tasks
Skip GNMI check during teardown and disable LogAnalyzer for reboot tests
Collaborator
|
/azp run |
|
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vvolam
reviewed
Feb 11, 2025
tests/gnmi/test_gnoi_system.py
Outdated
| pytest_assert("time" in msg_json, "System.Time API did not return time") | ||
|
|
||
|
|
||
| def test_gnoi_system_reboot(duthosts, rand_one_dut_hostname, localhost): |
Contributor
There was a problem hiding this comment.
@hdwhdw Since, all the tests are doing cold reboot, could you rename the tests accordingly to include the cold name? I plan to add similar tests for halt method testing as well.
qiluo-msft
reviewed
Feb 12, 2025
| rollback(duthost, SETUP_ENV_CP) | ||
| recover_cert_config(duthost) | ||
| # Get the skip_gnmi_check flag from duthost options | ||
| skip_gnmi_check = duthost.host.options.get('skip_gnmi_check', False) |
Contributor
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR test the features in:
gNOI Cold Reboot #20709 - Adding the framework docker in the sonic-buildimage
gNOI Cold Reboot - Integrated Rebootbackend changes #20710 - rebootbackend process code inside the framework docker
gNOI Cold Reboot - Integrated tests #20711 - Unit tests for cold reboot in rebootbackend
gNOI Cold Reboot - Integrated gNOI repository #20712 - Adding gNOI submodule as a sub-dir inside framework
gNOI Cold Reboot - Integrated Docker and Makefile changes #20713 - Enabling framework docker and all Makefile changes
sonic-net/sonic-host-services#181 sonic-host-services changes for cold reboot
gNOI Reboot Frontend (gNMI)
gNOI Warm reboot - rebootbackend changes - Enabling warm reboot in rebootbackend process
gNOI warm reboot tests - Adding component tests for warm reboot
sonic-net/sonic-host-services#191 - sonic-host-services changes for warm reboot
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation