[lag 2] parameterize testcase test_lag_2#2439
Merged
yxieca merged 1 commit intosonic-net:masterfrom Oct 31, 2020
Merged
Conversation
Parameterize testcase lag_2 so that we can see which testcase is passing or failing. Also attempted to make it multi-dut ready. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Blueve
approved these changes
Oct 31, 2020
yejianquan
pushed a commit
that referenced
this pull request
Dec 11, 2024
Description of PR Previously we're using sudo ip netns exec asic0 show queue counter for showing the queue counter in multi-asic. However with the new apis, -n is supported natively in show queue counter -n asic0 This PR updates so that in get_egress_queue_count will use the new queue counters. The queue counter support was added in the original PR: suppport multi asic for show queue counter sonic-utilities#2439 Cherry-pick to 202205: Double commit #2439 suppport multi asic for show queue counter sonic-utilities#2647 Summary: Fixes # (issue) #15856 Approach What is the motivation for this PR? How did you do it? Adjust the command to use the new format show queue counter -n asic0 Signed-off-by: Austin Pham <austinpham@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 11, 2024
Description of PR Previously we're using sudo ip netns exec asic0 show queue counter for showing the queue counter in multi-asic. However with the new apis, -n is supported natively in show queue counter -n asic0 This PR updates so that in get_egress_queue_count will use the new queue counters. The queue counter support was added in the original PR: suppport multi asic for show queue counter sonic-utilities#2439 Cherry-pick to 202205: Double commit sonic-net#2439 suppport multi asic for show queue counter sonic-utilities#2647 Summary: Fixes # (issue) sonic-net#15856 Approach What is the motivation for this PR? How did you do it? Adjust the command to use the new format show queue counter -n asic0 Signed-off-by: Austin Pham <austinpham@microsoft.com>
mssonicbld
pushed a commit
that referenced
this pull request
Dec 11, 2024
Description of PR Previously we're using sudo ip netns exec asic0 show queue counter for showing the queue counter in multi-asic. However with the new apis, -n is supported natively in show queue counter -n asic0 This PR updates so that in get_egress_queue_count will use the new queue counters. The queue counter support was added in the original PR: suppport multi asic for show queue counter sonic-utilities#2439 Cherry-pick to 202205: Double commit #2439 suppport multi asic for show queue counter sonic-utilities#2647 Summary: Fixes # (issue) #15856 Approach What is the motivation for this PR? How did you do it? Adjust the command to use the new format show queue counter -n asic0 Signed-off-by: Austin Pham <austinpham@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 2, 2025
Description of PR Previously we're using sudo ip netns exec asic0 show queue counter for showing the queue counter in multi-asic. However with the new apis, -n is supported natively in show queue counter -n asic0 This PR updates so that in get_egress_queue_count will use the new queue counters. The queue counter support was added in the original PR: suppport multi asic for show queue counter sonic-utilities#2439 Cherry-pick to 202205: Double commit sonic-net#2439 suppport multi asic for show queue counter sonic-utilities#2647 Summary: Fixes # (issue) sonic-net#15856 Approach What is the motivation for this PR? How did you do it? Adjust the command to use the new format show queue counter -n asic0 Signed-off-by: Austin Pham <austinpham@microsoft.com>
mssonicbld
pushed a commit
that referenced
this pull request
Jan 3, 2025
Description of PR Previously we're using sudo ip netns exec asic0 show queue counter for showing the queue counter in multi-asic. However with the new apis, -n is supported natively in show queue counter -n asic0 This PR updates so that in get_egress_queue_count will use the new queue counters. The queue counter support was added in the original PR: suppport multi asic for show queue counter sonic-utilities#2439 Cherry-pick to 202205: Double commit #2439 suppport multi asic for show queue counter sonic-utilities#2647 Summary: Fixes # (issue) #15856 Approach What is the motivation for this PR? How did you do it? Adjust the command to use the new format show queue counter -n asic0 Signed-off-by: Austin Pham <austinpham@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…-net#11929) Include following new kernel commits: - 815cb34 [patch]: Add accept_untracked_na kernel param (sonic-net#291) - fbb76cc Remove kernel config SERIAL_8250_RUNTIME_UARTS (sonic-net#286) Introduce following SWSS commits: - eedf59d [intfmgr]: Enable `accept_untracked_na` kernel param (sonic-net#2439) - bbd4eb7 [BFD]Clean up state_db BFD entries on swss restart (sonic-net#2434) (sonic-net#2435) - aa7b546 [FDB] [202012] Fix fbdorch to properly handle syncd FDB FLUSH Notif (sonic-net#2401) - 4190c13 Support for platforms based on Clounix Networks' device (sonic-net#2399) Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Why I did it Submodule advances: sonic-utilities 8e8e6088 - [202211][dhcp_relay] Remove add field of vlanid to DHCP_RELAY table while adding vlan ([201811 sub-module] advance sub-modules: utilities, swss, swss-common sonic-net#2679) (16 hours ago) [Yaqiang Zhu] 1400fb94 - [GCU] Ignore bgpraw in GCU applier (Fix sfputil indexing for 7170-Q59S20 sonic-net#2623) (15 hours ago) [jingwenxie] f76a6364 - [vlan] Refresh dhcpv6_relay config while adding/deleting a vlan ([sonic-py-swsssdk] Update submodule sonic-net#2660) (15 hours ago) [Yaqiang Zhu] 7849e18d - [db_migrator] make LOG_LEVEL_DB migration more robust (Mellanox platform: attach queues 2 and 6 to lossy profile using generic buffer template sonic-net#2651) (16 hours ago) [Stepan Blyshchak] c7df6dfa - Fixed a bug in "show vnet routes all" causing screen overrun. (Add hook to allow customizing link cable lengths sonic-net#2644) (16 hours ago) [siqbal1986] a5505f02 - show logging CLI support for logs stored in tmpfs (Traceback error seen while issuing show interface commands with if_names sonic-net#2641) (16 hours ago) [mihirpat1] bbacb91a - [system-health] Fix issue: show system-health CLI crashes (Updating deb package for platform and sai sonic-net#2635) (16 hours ago) [Junchao-Mellanox] 8d724024 - [sai_failure_dump]Invoking dump during SAI failure ([dockers]: Upgrade LLDP docker to stretch build sonic-net#2633) (16 hours ago) [Sudharsan Dhamal Gopalarathnam] 3c3be526 - Add transceiver info CLI support to show output from TRANSCEIVER_INFO for ZR ([submodule]: Update sonic-sairedis pointer sonic-net#2630) (16 hours ago) [mihirpat1] 37f41666 - [show] add support for gRPC show commands for active-active ([bitmap-vnet]: Bitmap vnet test image [DO NOT MERGE] sonic-net#2629) (16 hours ago) [vdahiya12] b06d7fe4 - [show_bfd] add local discriminator in show bfd command ([Pmon] Selectively load pmon container daemons sonic-net#2625) (16 hours ago) [Baorong Liu] 6adcd3e8 - [GCU] Ignore bgpraw table in GCU operation ([Mellanox] Fix SAI version sonic-net#2628) (16 hours ago) [jingwenxie] c65bdc35 - [muxcable][config] Add support to enable/disable ceasing to be an advertisement interface when radv service is stopped (Add knob in ConfigDB to enable/disable telemetry container sonic-net#2622) (16 hours ago) [Jing Zhang] 91e9457f - Add Transceiver PM basic CLI support to show output from TRANSCEIVER_PM table for ZR ([201803] Restart SwSS, syncd and dependent services if a critical process in syncd container exits sonic-net#2615) (16 hours ago) [longhuan-cisco] 54cc8c5a - Remove TODO comment which is no longer relevant (Warm-reboot: teamd warm restart caused neighbor deleted and learned again. sonic-net#2600) (16 hours ago) [Lior Avramov] 6891b4fb - Making 'show feature autorestart' more resilient to missing auto_restart config in CONFIG_DB ([submodule] update mellanox hw-mgmgt pointer (V.2.0.0061) sonic-net#2592) (16 hours ago) [kartik-arista] 1e8bea37 - [storyteller] add link prober state change to story teller ([sonic-buildimage] New feature managementVRF(L3mdev) sonic-net#2585) (16 hours ago) [Jing Zhang] 7481a20f - Extend fast-reboot STATE_DB entry timer ([submodule]: update sonic-swss-common, sonic-py-swsssdk, sonic-snmpagent sonic-net#2577) (16 hours ago) [Aryeh Feigin] 0e08701c - [sonic_installer] use /etc/resolv.conf from the host when migrating packages (Set a rate limit on syslog messages from all Docker containers sonic-net#2573) (16 hours ago) [Stepan Blyshchak] 06096780 - Fixed admin state config CLI for Backport interfaces (Prior to install a new ONIE SONiC image, delete all partitions except EFI/ONIE sonic-net#2557) (16 hours ago) [anamehra] 9f1f13e4 - [show] Add bgpraw to show run all (Fixed typo on paragraph sonic-net#40 sonic-net#2537) (16 hours ago) [jingwenxie] 98bc8bd2 - [chassis][voq] Add "show fabric reachability" command. ([ntp]: Build 4.2.6 locally. sonic-net#2528) (16 hours ago) [jfeng-arista] 3a50b63f - Preserve copp tables through DB migration ([docker-radvd]: upgrade docker radvd to stretch based sonic-net#2524) (16 hours ago) [Aryeh Feigin] 28f6b127 - [masic] 'show interfaces counters' reminds to use '-d all' option to check for internal links (solve dependency issue sonic-net#2466) (16 hours ago) [wenyiz2021] 15026e14 - suppport multi asic for show queue counter ([dockers] Prevent old supervisord messages from gettting re-logged to syslog sonic-net#2439) (16 hours ago) [zhixzhu] 2d773e17 - [masic support] 'show run bgp' support for multi-asic (lo address not synced to the asic sonic-net#2427) (16 hours ago) [wenyiz2021] sonic-swss 4f304bc - [EVPN]Handling race condition when remote VNI arrives before tunnel map entry ([sonic-quagga] Function defect, do NOT cancel route while connect IP down sonic-net#2642) (15 hours ago) [Sudharsan Dhamal Gopalarathnam] 34fc615 - [sai_failure_dump]Invoking dump during SAI failure (Add hook to allow customizing link cable lengths sonic-net#2644) (15 hours ago) [Sudharsan Dhamal Gopalarathnam] b817695 - [autoneg]Fixing adv interface types to be set when AN is disabled (Fix issue with platform file path name sonic-net#2638) (15 hours ago) [Sudharsan Dhamal Gopalarathnam] ab36bd4 - [bfdorch] add local discriminator to state DB ([bitmap-vnet]: Bitmap vnet test image [DO NOT MERGE] sonic-net#2629) (15 hours ago) [Baorong Liu] 6343471 - Remove TODO comments that are no longer relevant (Add knob in ConfigDB to enable/disable telemetry container sonic-net#2622) (15 hours ago) [Lior Avramov] 2b1869c - [refactor]Refactoring sai handle status (Rollback kernel submodule update. sonic-net#2621) (15 hours ago) [Sudharsan Dhamal Gopalarathnam] c41a1b7 - Fix issue ARP entry is out of sync between kernel and APPL_DB after warm reboot if the ARP entry is updated more than once during warm reboot in PFC watchdog warm reboot test sonic-net#13341 ARP entry can be out of sync between kernel and APPL_DB if multiple updates are received from RTNL ([sub module] advance sonic-utilities sub module for 201811 branch sonic-net#2619) (15 hours ago) [Stephen Sun] da0cf7a - Changed the BFD default detect multiplier to 10x ("failed to load plugin io.containerd.snapshotter..." seen during linux boot up sonic-net#2614) (15 hours ago) [siqbal1986] 13b5adf - [vstest] Only collect stdout of orchagent_restart_check in vstest ([submodules] update swss and utilities pointers sonic-net#2597) (15 hours ago) [bingwang-ms] 2b9d94d - Avoid aborting orchagent when setting TUNNEL attributes (build failing for PLATFORM=p4 sonic-net#2591) (15 hours ago) [Stephen Sun] 99b7d3b - Only collect stdout of orchagent_restart_check in vstest ( [saibcm-modules]: import new bcm modules sonic-net#2578) (15 hours ago) [bingwang-ms] 5209c42 - dereg acl-rule counters during acl-table del ([201803] Set a rate limit on syslog messages from all Docker containers sonic-net#2574) (15 hours ago) [Vivek] ae68054 - Fixed set mtu for deleted subintf due to late notification ([vs]: Add option to specify platform name for DVS orchagent sonic-net#2571) (15 hours ago) [EdenGri] ab13dfa - Remove TODO comments which are no longer needed (support set timezone in ConfigDB sonic-net#2568) (15 hours ago) [Junchao-Mellanox] a3545cf - Modify coppmgr mergeConfig to support preserving copp tables through reboot. (Added new SN3700/SN3700C Mellanox platforms sonic-net#2548) (15 hours ago) [Aryeh Feigin] be16e79 - Use github code scanning instead of LGTM ([201803] [services] Restart SwSS service upon unexpected critical process exit sonic-net#2546) (15 hours ago) [Liu Shilong] 63c0234 - Updated handling of VRF_VNI mapping and VLAN_VNI mapping for same VNI ID (Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABL… sonic-net#2538) (15 hours ago) [Tapash Das] 4844111 - Fix potential risks ([mlnx] Fix sai xml path for boxer platform sonic-net#2516) (15 hours ago) [Liran-Ar] 6420808 - [p4orch]: PINS Extension tables support ([build] When generating image version, handle case where current commit has no reachable tags sonic-net#2506) (15 hours ago) [svshah-intel] sonic-swss-common 1badd46 - Increase the netlink buffer size from 3MB to 16MB. (arp_update doesn't sleep 300 between each execution sonic-net#739) (14 hours ago) [KISHORE KUNAL] 6555057 - Refactor eventpublisher deinit ([acl] Add default deny rule for l3 table sonic-net#734) (14 hours ago) [Zain Budhwani] f4d6de7 - Use github code scanning instead of LGTM ([sonic-quagga]:update submodule sonic-net#718) (14 hours ago) [Liu Shilong] sonic-linux-kernel 74f9a8f - Update linux kernel for hw-mgmt V.7.0020.4104 (Move template files to /usr/share/sonic/templates sonic-net#305) (14 hours ago) [Stephen Sun] 6365701 - Fixes for emmc unreliability ([build_debian.sh]: Integrate system dump script sonic-net#270) (14 hours ago) [Samuel Angebault] How I did it How to verify it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: parameterize testcase test_lag_2
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
lag2 test loop through all lags to run various testcase. There is no visibility what test case is running/passing/failing on which lag.
How did you do it?
Parameterize testcase lag_2 so that we can see which testcase is passing or failing.
Also attempted to make it multi-dut ready.
Signed-off-by: Ying Xie ying.xie@microsoft.com
How did you verify/test it?
================================================================================== test session starts ===================================================================================
platform linux2 -- Python 2.7.12, pytest-4.6.5, py-1.9.0, pluggy-0.13.1
ansible: 2.8.12
rootdir: /var/src/sonic-mgmt/tests, inifile: pytest.ini
plugins: ansible-2.2.2, xdist-1.28.0, metadata-1.10.0, forked-1.3.0, html-1.22.1, repeat-0.8.0
collected 24 items
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0005-single_lag] PASSED [ 4%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0005-lacp_rate] PASSED [ 8%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0005-fallback] SKIPPED [ 12%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0008-single_lag] PASSED [ 16%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0008-lacp_rate] PASSED [ 20%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0008-fallback] SKIPPED [ 25%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0002-single_lag] PASSED [ 29%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0002-lacp_rate] PASSED [ 33%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0002-fallback] SKIPPED [ 37%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0023-single_lag] PASSED [ 41%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0023-lacp_rate] PASSED [ 45%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0023-fallback] SKIPPED [ 50%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0020-single_lag] PASSED [ 54%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0020-lacp_rate] PASSED [ 58%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0020-fallback] SKIPPED [ 62%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0017-single_lag] PASSED [ 66%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0017-lacp_rate] PASSED [ 70%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0017-fallback] SKIPPED [ 75%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0014-single_lag] PASSED [ 79%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0014-lacp_rate] PASSED [ 83%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0014-fallback] SKIPPED [ 87%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0011-single_lag] PASSED [ 91%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0011-lacp_rate] PASSED [ 95%]
pc/test_lag_2.py::test_lag[str-dx010-acs-1|PortChannel0011-fallback] SKIPPED [100%]
------------------------------------------------------------------------ generated xml file: /tmp/logs-01/tr.xml -------------------------------------------------------------------------