[acl] Refactor test_acl.py and add t0 support#2401
Merged
daall merged 3 commits intosonic-net:masterfrom Nov 3, 2020
Merged
Conversation
- Generalize setup to work for t0 and t1 - Add arp_responder to support forwarding to VLAN members - Add helper methods for duplicate code - Clean up linter errors Signed-off-by: Danny Allen <[email protected]>
yxieca
reviewed
Nov 2, 2020
yxieca
reviewed
Nov 2, 2020
yxieca
reviewed
Nov 2, 2020
yxieca
approved these changes
Nov 2, 2020
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
Left a few cosmetic issues. You can choose to address them in another PR.
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…-net#11929) Include following new kernel commits: - 815cb34 [patch]: Add accept_untracked_na kernel param (sonic-net#291) - fbb76cc Remove kernel config SERIAL_8250_RUNTIME_UARTS (sonic-net#286) Introduce following SWSS commits: - eedf59d [intfmgr]: Enable `accept_untracked_na` kernel param (sonic-net#2439) - bbd4eb7 [BFD]Clean up state_db BFD entries on swss restart (sonic-net#2434) (sonic-net#2435) - aa7b546 [FDB] [202012] Fix fbdorch to properly handle syncd FDB FLUSH Notif (sonic-net#2401) - 4190c13 Support for platforms based on Clounix Networks' device (sonic-net#2399) Signed-off-by: Lawrence Lee <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen [email protected]
Description of PR
Summary: [acl] Refactor test_acl.py
Type of change
Approach
What is the motivation for this PR?
Currently we are not able to run the ACL tests on
t0testbeds. This PR makes that possible, and it cleans up the existing code to meet pep8 standards.How did you do it?
I generalized the test setup to handle interfaces as "upstream" or "downstream" instead of just spine vs. tor. To make this work for T0, I also set up the arp_responder so that we can forward to VLAN members correctly.
How did you verify/test it?
Ran the test on multiple platforms (2 that do not support egress mirroring and 1 that does), against 201911 and master branch images, and finally with a variety of topologies (t1, t1-lag, t1-64-lag, and t0).
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
t0support added.Documentation