Skip to content

[T2 IXIA] Update show queue counters api to use -n#15944

Merged
yejianquan merged 1 commit intosonic-net:masterfrom
auspham:austinpham/15856-update-get-egress-queue-count-show-queue-counters
Dec 11, 2024
Merged

[T2 IXIA] Update show queue counters api to use -n#15944
yejianquan merged 1 commit intosonic-net:masterfrom
auspham:austinpham/15856-update-get-egress-queue-count-show-queue-counters

Conversation

@auspham
Copy link
Contributor

@auspham auspham commented Dec 8, 2024

Description of PR

Previously we're using sudo ip netns exec asic0 show queue counter for showing the queue counter in multi-asic. However with the new apis, -n is supported natively in show queue counter -n asic0

This PR updates so that in get_egress_queue_count will use the new queue counters.

The queue counter support was added in the original PR:

Cherry-pick to 202205:

Summary:
Fixes # (issue) #15856

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

How did you do it?

Adjust the command to use the new format show queue counter -n asic0

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@auspham auspham requested a review from Copilot December 8, 2024 22:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

@auspham auspham requested a review from sdszhang December 8, 2024 22:49
@auspham
Copy link
Contributor Author

auspham commented Dec 8, 2024

@amitpawar12 @sdszhang for viz

Copy link
Contributor

@sdszhang sdszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auspham auspham changed the title chore: update show queue counters api to use -n [T2 IXIA] Update show queue counters api to use -n Dec 9, 2024
@auspham auspham self-assigned this Dec 10, 2024
@auspham auspham force-pushed the austinpham/15856-update-get-egress-queue-count-show-queue-counters branch from 98aca77 to 62bc10e Compare December 11, 2024 01:29
@yejianquan
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan yejianquan merged commit 12f5da6 into sonic-net:master Dec 11, 2024
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Dec 11, 2024
Description of PR
Previously we're using sudo ip netns exec asic0 show queue counter for showing the queue counter in multi-asic. However with the new apis, -n is supported natively in show queue counter -n asic0

This PR updates so that in get_egress_queue_count will use the new queue counters.

The queue counter support was added in the original PR:

suppport multi asic for show queue counter sonic-utilities#2439
Cherry-pick to 202205:

Double commit sonic-net#2439 suppport multi asic for show queue counter sonic-utilities#2647
Summary:
Fixes # (issue) sonic-net#15856

Approach
What is the motivation for this PR?
How did you do it?
Adjust the command to use the new format show queue counter -n asic0

Signed-off-by: Austin Pham <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #16010

mssonicbld pushed a commit that referenced this pull request Dec 11, 2024
Description of PR
Previously we're using sudo ip netns exec asic0 show queue counter for showing the queue counter in multi-asic. However with the new apis, -n is supported natively in show queue counter -n asic0

This PR updates so that in get_egress_queue_count will use the new queue counters.

The queue counter support was added in the original PR:

suppport multi asic for show queue counter sonic-utilities#2439
Cherry-pick to 202205:

Double commit #2439 suppport multi asic for show queue counter sonic-utilities#2647
Summary:
Fixes # (issue) #15856

Approach
What is the motivation for this PR?
How did you do it?
Adjust the command to use the new format show queue counter -n asic0

Signed-off-by: Austin Pham <[email protected]>
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 2, 2025
Description of PR
Previously we're using sudo ip netns exec asic0 show queue counter for showing the queue counter in multi-asic. However with the new apis, -n is supported natively in show queue counter -n asic0

This PR updates so that in get_egress_queue_count will use the new queue counters.

The queue counter support was added in the original PR:

suppport multi asic for show queue counter sonic-utilities#2439
Cherry-pick to 202205:

Double commit sonic-net#2439 suppport multi asic for show queue counter sonic-utilities#2647
Summary:
Fixes # (issue) sonic-net#15856

Approach
What is the motivation for this PR?
How did you do it?
Adjust the command to use the new format show queue counter -n asic0

Signed-off-by: Austin Pham <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #16308

mssonicbld pushed a commit that referenced this pull request Jan 3, 2025
Description of PR
Previously we're using sudo ip netns exec asic0 show queue counter for showing the queue counter in multi-asic. However with the new apis, -n is supported natively in show queue counter -n asic0

This PR updates so that in get_egress_queue_count will use the new queue counters.

The queue counter support was added in the original PR:

suppport multi asic for show queue counter sonic-utilities#2439
Cherry-pick to 202205:

Double commit #2439 suppport multi asic for show queue counter sonic-utilities#2647
Summary:
Fixes # (issue) #15856

Approach
What is the motivation for this PR?
How did you do it?
Adjust the command to use the new format show queue counter -n asic0

Signed-off-by: Austin Pham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants