Skip to content

[202505] Backport recent PRs and update skip condition for test_duplicate_routes#21030

Merged
yejianquan merged 5 commits intosonic-net:202505from
lizhijianrd:202505-backport-test-dup-route
Oct 23, 2025
Merged

[202505] Backport recent PRs and update skip condition for test_duplicate_routes#21030
yejianquan merged 5 commits intosonic-net:202505from
lizhijianrd:202505-backport-test-dup-route

Conversation

@lizhijianrd
Copy link
Contributor

Description of PR

Summary:
test_duplicate_routes is expected to run and pass on 202505 branch

  1. Backport PR Revert "Update expect_regex in test_duplicate_route to support bulk update mode" #20334 and Update ignore_regex in test_duplicate_route to support bulk update mode #20357
  2. Update skip condition to Regression: test_duplicate_route.py failing log checks after sairedis update #20231

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Verified on Arista-7050CX3 M1 testbed.

route/test_duplicate_route.py::test_duplicate_routes[4-Loopback-bjw3-can-7050c-6-None] SKIPPED (Temporarily skip this test until testcase regression is fixed)        [ 25%]
route/test_duplicate_route.py::test_duplicate_routes[4-Vlan-bjw3-can-7050c-6-None] SKIPPED (Temporarily skip this test until testcase regression is fixed)            [ 50%]
route/test_duplicate_route.py::test_duplicate_routes[6-Loopback-bjw3-can-7050c-6-None] SKIPPED (Temporarily skip this test until testcase regression is fixed)        [ 75%]
route/test_duplicate_route.py::test_duplicate_routes[6-Vlan-bjw3-can-7050c-6-None] SKIPPED (Temporarily skip this test until testcase regression is fixed)            [100%]

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

xwjiang-ms and others added 3 commits October 20, 2025 06:46
…de (sonic-net#20357)

The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks.

The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list.
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 2b32689 into sonic-net:202505 Oct 23, 2025
17 checks passed
@lizhijianrd lizhijianrd deleted the 202505-backport-test-dup-route branch October 23, 2025 11:46
lizhijianrd added a commit to Azure/sonic-mgmt.msft that referenced this pull request Nov 4, 2025
**What's the motivation?**
Remove the conditional skip to expose the issue. (PR for 202505:
sonic-net/sonic-mgmt#21030)

**How did you do?**
Remove the conditional mark.

**How did you verify?**
Verified on M1 testbed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants