Skip to content

Fix get impact area parameter missing issue#20335

Merged
wangxin merged 1 commit intosonic-net:masterfrom
xwjiang-ms:fix_impact_area_not_working
Aug 21, 2025
Merged

Fix get impact area parameter missing issue#20335
wangxin merged 1 commit intosonic-net:masterfrom
xwjiang-ms:fix_impact_area_not_working

Conversation

@xwjiang-ms
Copy link
Contributor

@xwjiang-ms xwjiang-ms commented Aug 20, 2025

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

PR #20002 refined PR test template, but forgot to pass build branch param to get impact area yaml, which led to impact area not working

How did you do it?

Pass build branch to impact area yaml

How did you verify/test it?

Before:

  • DIFF_FOLDERS=
    After:
  • DIFF_FOLDERS='.azure-pipelines '

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@xwjiang-ms xwjiang-ms requested a review from wangxin as a code owner August 20, 2025 06:01
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wangxin wangxin merged commit b97edc1 into sonic-net:master Aug 21, 2025
20 checks passed
@xwjiang-ms xwjiang-ms deleted the fix_impact_area_not_working branch August 21, 2025 04:18
xwjiang-ms added a commit to xwjiang-ms/sonic-mgmt that referenced this pull request Aug 22, 2025
StormLiangMS pushed a commit that referenced this pull request Aug 25, 2025
echuawu pushed a commit to echuawu/sonic-mgmt that referenced this pull request Aug 25, 2025
What is the motivation for this PR?
PR sonic-net#20002 refined PR test template, but forgot to pass build branch param to get impact area yaml, which led to impact area not working

How did you do it?
Pass build branch to impact area yaml

How did you verify/test it?
Before:

DIFF_FOLDERS=
After:
DIFF_FOLDERS='.azure-pipelines '
xixuej pushed a commit to xixuej/sonic-mgmt that referenced this pull request Sep 17, 2025
What is the motivation for this PR?
PR sonic-net#20002 refined PR test template, but forgot to pass build branch param to get impact area yaml, which led to impact area not working

How did you do it?
Pass build branch to impact area yaml

How did you verify/test it?
Before:

DIFF_FOLDERS=
After:
DIFF_FOLDERS='.azure-pipelines '
xixuej pushed a commit to xixuej/sonic-mgmt that referenced this pull request Sep 17, 2025
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
What is the motivation for this PR?
PR sonic-net#20002 refined PR test template, but forgot to pass build branch param to get impact area yaml, which led to impact area not working

How did you do it?
Pass build branch to impact area yaml

How did you verify/test it?
Before:

DIFF_FOLDERS=
After:
DIFF_FOLDERS='.azure-pipelines '
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
What is the motivation for this PR?
PR sonic-net#20002 refined PR test template, but forgot to pass build branch param to get impact area yaml, which led to impact area not working

How did you do it?
Pass build branch to impact area yaml

How did you verify/test it?
Before:

DIFF_FOLDERS=
After:
DIFF_FOLDERS='.azure-pipelines '

Signed-off-by: opcoder0 <[email protected]>
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
What is the motivation for this PR?
PR sonic-net#20002 refined PR test template, but forgot to pass build branch param to get impact area yaml, which led to impact area not working

How did you do it?
Pass build branch to impact area yaml

How did you verify/test it?
Before:

DIFF_FOLDERS=
After:
DIFF_FOLDERS='.azure-pipelines '

Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
What is the motivation for this PR?
PR sonic-net#20002 refined PR test template, but forgot to pass build branch param to get impact area yaml, which led to impact area not working

How did you do it?
Pass build branch to impact area yaml

How did you verify/test it?
Before:

DIFF_FOLDERS=
After:
DIFF_FOLDERS='.azure-pipelines '

Signed-off-by: Aharon Malkin <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
What is the motivation for this PR?
PR sonic-net#20002 refined PR test template, but forgot to pass build branch param to get impact area yaml, which led to impact area not working

How did you do it?
Pass build branch to impact area yaml

How did you verify/test it?
Before:

DIFF_FOLDERS=
After:
DIFF_FOLDERS='.azure-pipelines '

Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
What is the motivation for this PR?
PR sonic-net#20002 refined PR test template, but forgot to pass build branch param to get impact area yaml, which led to impact area not working

How did you do it?
Pass build branch to impact area yaml

How did you verify/test it?
Before:

DIFF_FOLDERS=
After:
DIFF_FOLDERS='.azure-pipelines '
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
What is the motivation for this PR?
PR sonic-net#20002 refined PR test template, but forgot to pass build branch param to get impact area yaml, which led to impact area not working

How did you do it?
Pass build branch to impact area yaml

How did you verify/test it?
Before:

DIFF_FOLDERS=
After:
DIFF_FOLDERS='.azure-pipelines '

Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
What is the motivation for this PR?
PR sonic-net#20002 refined PR test template, but forgot to pass build branch param to get impact area yaml, which led to impact area not working

How did you do it?
Pass build branch to impact area yaml

How did you verify/test it?
Before:

DIFF_FOLDERS=
After:
DIFF_FOLDERS='.azure-pipelines '

Signed-off-by: Yael Tzur <[email protected]>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants