Revert "Fix get impact area parameter missing issue"#20384
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Aug 25, 2025
Merged
Conversation
This reverts commit b97edc1.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xixuej
pushed a commit
to xixuej/sonic-mgmt
that referenced
this pull request
Sep 17, 2025
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
sonic-net#20384) This reverts commit b97edc1. Signed-off-by: opcoder0 <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
sonic-net#20384) This reverts commit b97edc1. Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
sonic-net#20384) This reverts commit b97edc1. Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
sonic-net#20384) This reverts commit b97edc1. Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
sonic-net#20384) This reverts commit b97edc1. Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
sonic-net#20384) This reverts commit b97edc1. Signed-off-by: Yael Tzur <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…net#20384) Why I did it CLI crashes without sudo permission on Dell 6000 platform How I did it Add check to read eeprom only if user has root permission How to verify it Verified the CLI "show interface status" does not crash if user is not root Signed-off-by: Prince George <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…net#20384) Why I did it CLI crashes without sudo permission on Dell 6000 platform How I did it Add check to read eeprom only if user has root permission How to verify it Verified the CLI "show interface status" does not crash if user is not root Signed-off-by: Prince George <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #20335
Although it fixed impact area not working issue, it exposed another issue that the job condition
contains(dependencies.get_impacted_area.outputs['SetVariableTask.PR_CHECKERS'], variables['CHECKER'])is not working. For example, even if TEST_SCRIPTS do not contain t0 tests, t0 PR checker will not be skipped, but continue to run, then it will get issue in finding test scripts.