[PR Test] Pass BUILD_BRANCH to get-impacted-area.yml#20182
Closed
wangxin wants to merge 1 commit intosonic-net:masterfrom
Closed
[PR Test] Pass BUILD_BRANCH to get-impacted-area.yml#20182wangxin wants to merge 1 commit intosonic-net:masterfrom
wangxin wants to merge 1 commit intosonic-net:masterfrom
Conversation
PR sonic-net#20002 improved the PR test templates. However, parameter BUILD_BRANCH was not passed down to the template impacted_area_testing/get-impacted-area.yml as before. This change added code to pass down $(BUILD_BRANCH) as parameter BUILD_BRANCH to the tempate impacted_area_testing/get-impacted-area.yml. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ZhaohuiS
approved these changes
Aug 11, 2025
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
Issue fixed by #20335. Close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
PR #20002 improved the PR test templates. However, parameter BUILD_BRANCH was not passed down to the template impacted_area_testing/get-impacted-area.yml as before.
How did you do it?
This change added code to pass down $(BUILD_BRANCH) as parameter BUILD_BRANCH to the tempate impacted_area_testing/get-impacted-area.yml.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation