[Mellanox] Fix for 'sfp_ethtool' regression test to support QSFP-DD cable type and SPC3 devices#1902
Merged
wangxin merged 3 commits intosonic-net:masterfrom Jul 16, 2020
shlomibitton:shlomi_ethtool_test_fix
Merged
[Mellanox] Fix for 'sfp_ethtool' regression test to support QSFP-DD cable type and SPC3 devices#1902wangxin merged 3 commits intosonic-net:masterfrom shlomibitton:shlomi_ethtool_test_fix
wangxin merged 3 commits intosonic-net:masterfrom
shlomibitton:shlomi_ethtool_test_fix
Conversation
… SPC3 devices Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com>
keboliu
approved these changes
Jul 14, 2020
wangxin
requested changes
Jul 15, 2020
wangxin
approved these changes
Jul 15, 2020
Collaborator
|
@shlomibitton Could you please help resolve the merge conflicts? |
Contributor
Author
|
@wangxin resolved. |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
* c3691d3 [202012][pfcwd] Convert polling interval from ms to us in LUA scripts (sonic-net#1909) * 549c804 Mux state order change (sonic-net#1902) * 6b0b2c4 Update acl type check logic (sonic-net#1886) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
sonic-swss: bb69ca2 [portsorch] Avoid orchagent crash when set invalid interface types to port (sonic-net#1906) 6e1bacc [pfcwd] Fix the polling interval time granularity (sonic-net#1912) 564785b [teammgrd]: Improve LAGs cleanup on shutdown: send SIGTERM directly to PID. (sonic-net#1841) 7ee8d26 [tlm teamd] Add retry mechanism before logging the ERR in get_dumps. (sonic-net#1629) 7f57d3d [fgnhgorch] Enable packet flow when no FG ECMP neighbors are resolved (sonic-net#1900) 08d009f Mux state order change (sonic-net#1902) sonic-utilities: 1bc0f07 Provide support to install platform extensions (sonic-net#1578) 968c781 [config reload] Removed job-mode for sonic.target restart (sonic-net#1820)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
swss 73caba3 Allow interface type value none (sonic-net#1991) utilities 32e530f Allow interface type value none (sonic-net#1902) 53f066c Fix log_ssd_health hang issue (sonic-net#1904)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton shlomibi@mellanox.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Current implementation of 'ethtool' is not supporting QSFP-DD EEPROM parser.
The test is checking amount of lines returned when calling the tool to show EEPROM data parsed.
How did you do it?
If EEPROM reading succesiding and there is only one line returned (ethtool current output for QSFP-DD) then checking the Identifier code will result as success.
How did you verify/test it?
Run sfp_ethtool test with a QSFP-DD cable connected.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation