[copp] Fix COPP test failures and make clean-up more robust#1904
Merged
daall merged 2 commits intosonic-net:masterfrom Jul 16, 2020
Merged
[copp] Fix COPP test failures and make clean-up more robust#1904daall merged 2 commits intosonic-net:masterfrom
daall merged 2 commits intosonic-net:masterfrom
Conversation
- Add minig_bgp var introduced by 1171 - Disable loganalyzer by default for LLDP messages - Updates default swap_syncd behavior to match qos_sai - Remove docker images after test Signed-off-by: Danny Allen <daall@microsoft.com>
|
This pull request introduces 2 alerts and fixes 2 when merging a69d389 into e3652ee - view on LGTM.com new alerts:
fixed alerts:
|
yxieca
approved these changes
Jul 15, 2020
tahmed-dev
reviewed
Jul 15, 2020
tests/copp/test_copp.py
Outdated
|
|
||
| pytestmark = [ | ||
| pytest.mark.topology('t1') | ||
| pytest.mark.disable_loganalyzer, # TODO: Figure out how to *only* ignore LLDP log messages. |
Contributor
There was a problem hiding this comment.
log analyzer was extended to support such a case in qos test
|
This pull request introduces 2 alerts and fixes 2 when merging e03598d into e048d8f - view on LGTM.com new alerts:
fixed alerts:
|
tahmed-dev
approved these changes
Jul 16, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule update for sonic-utilties ``` 48035d75 [202012] [techsupport] Techsupport Error Reporting pending fixes (sonic-net#1854) 8b2ec09a Fix log_ssd_health hang issue (sonic-net#1904) ac9c4254 Fix the option missing in kernel config issue (sonic-net#1888) 5cc9417a disk_check: Script updated to run good in 201811 & 201911 (sonic-net#1747) ```
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
swss 73caba3 Allow interface type value none (sonic-net#1991) utilities 32e530f Allow interface type value none (sonic-net#1902) 53f066c Fix log_ssd_health hang issue (sonic-net#1904)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
Description of PR
Summary: Fix COPP test failures and make clean-up process more robust.
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
There are a few problems we found:
This PR addresses all 4 of those issues, which should make the COPP tests more reliable and stable.
How did you do it?
I addressed each issue in turn:
minig_bgpvariable from Wrong DIP on packet #1171 to the ptf runner paramsHow did you verify/test it?
Tests pass locally, and the RPC docker image is not present on the DUT after the tests complete.
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation