[QoS] Support generating QoS test parameters according to configuration on Mellanox platform#1886
Merged
liat-grozovik merged 10 commits intosonic-net:masterfrom Aug 6, 2020
stephenxs:generate-qos-param-from-config
Merged
[QoS] Support generating QoS test parameters according to configuration on Mellanox platform#1886liat-grozovik merged 10 commits intosonic-net:masterfrom stephenxs:generate-qos-param-from-config
liat-grozovik merged 10 commits intosonic-net:masterfrom
stephenxs:generate-qos-param-from-config
Conversation
…on on Mellanox platform 1. Add a plugin which generate QoS test parameters according to configuration for Mellanox platform. The plugin will be load fixture dutQosConfig 2. Sometimes a deviation cab be introduced by calculating test parameters automatically. Support passing margin from the qos_params for the purpose of convering the deviation. 3. Support passing packet size from the qos_params for lossy queue and queue shared watermark test. Signed-off-by: Stephen Sun <stephens@mellanox.com>
|
This pull request introduces 2 alerts when merging 3804b93 into 01f4a98 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 7c48158 into 01f4a98 - view on LGTM.com new alerts:
|
added 2 commits
July 13, 2020 14:58
For the functions where packet_size is fetched from test parameters
Collaborator
|
retest vsimage please |
added 2 commits
July 15, 2020 12:32
Signed-off-by: Stephen Sun <stephens@mellanox.com>
3 tasks
neethajohn
requested changes
Aug 3, 2020
Contributor
neethajohn
left a comment
neethajohn
left a comment
There was a problem hiding this comment.
Has this code been tested with the new single ingress pool changes?
Correct typo
…t in QSharedWatermarkTest Signed-off-by: Stephen Sun <stephens@mellanox.com>
…iQSharedWatermark or testQosSaiPgSharedWatermark Signed-off-by: Stephen Sun <stephens@mellanox.com>
neethajohn
reviewed
Aug 4, 2020
Signed-off-by: Stephen Sun <stephens@mellanox.com>
neethajohn
approved these changes
Aug 5, 2020
liat-grozovik
approved these changes
Aug 6, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
* c3691d3 [202012][pfcwd] Convert polling interval from ms to us in LUA scripts (sonic-net#1909) * 549c804 Mux state order change (sonic-net#1902) * 6b0b2c4 Update acl type check logic (sonic-net#1886) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule update for sonic-utilities with following change: ec9e5ee Backport [generate_dump] remove secrets from dump files sonic-net#1886 to 202012 (sonic-net#1938) ce3b856 [fdbshow]: Handle FDB cleanup gracefully. (sonic-net#1926) 1437bf2 [202012] Add DHCPv6 Relay counter and ipv6 helper CLI (sonic-net#1917)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
The plugin will be load fixture dutQosConfig
Support passing margin from the qos_params for the purpose of covering the deviation.
Signed-off-by: Stephen Sun stephens@mellanox.com
Type of change
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation