Skip to content

[test_watchdog.py] Change the condition for wait_for and align watchd…#1912

Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom
stepanblyschak:wd_fixes
Aug 3, 2020
Merged

[test_watchdog.py] Change the condition for wait_for and align watchd…#1912
liat-grozovik merged 1 commit intosonic-net:masterfrom
stepanblyschak:wd_fixes

Conversation

@stepanblyschak
Copy link
Contributor

…og parameters for Mellanox platforms

* On some of our sonic-mgmt nodes it is observed that localhost.wait_for
  does not return 'exception' in result and does not set is_failed flag,
  thus let's not rely on that. Instead, wait_for always returns a message
  with ''Timeout waiting for ...' which can be used instead.
* Modify watchdog test parameters per platform according to recent CPLD
  update which implements watchdog type 3

Signed-off-by: Stepan Blyschak stepanb@mellanox.com

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wangxin wangxin requested a review from jleveque July 20, 2020 09:07
@jleveque jleveque requested a review from sujinmkang July 20, 2020 15:52
@sujinmkang
Copy link
Contributor

Can you please rebase the PR? I will approve the PR once it's rebased.

…og parameters for Mellanox platforms

    * On some of our sonic-mgmt nodes it is observed that localhost.wait_for
      does not return 'exception' in result and does not set is_failed flag,
      thus let's not rely on that. Instead, wait_for always returns a message
      with ''Timeout waiting for ...' which can be used instead.
    * Modify watchdog test parameters per platform according to recent CPLD
      update which implements watchdog type 3

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
@liat-grozovik
Copy link
Collaborator

liat-grozovik commented Aug 3, 2020

verified on top of mellanox master and found to solve the problem.

@liat-grozovik liat-grozovik merged commit d982cdf into sonic-net:master Aug 3, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Commits on Sep 18, 2021
[pfcwd] Fix the polling interval time granularity (sonic-net#1912) 98a3ae8

Commits on Sep 20, 2021
[202012][teammgrd]: Improve LAGs cleanup on shutdown (sonic-net#1916) 5a4678e 

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
sonic-swss:

bb69ca2 [portsorch] Avoid orchagent crash when set invalid interface types to port (sonic-net#1906)
6e1bacc [pfcwd] Fix the polling interval time granularity (sonic-net#1912)
564785b [teammgrd]: Improve LAGs cleanup on shutdown: send SIGTERM directly to PID. (sonic-net#1841)
7ee8d26 [tlm teamd] Add retry mechanism before logging the ERR in get_dumps. (sonic-net#1629)
7f57d3d [fgnhgorch] Enable packet flow when no FG ECMP neighbors are resolved (sonic-net#1900)
08d009f Mux state order change (sonic-net#1902)

sonic-utilities:

1bc0f07 Provide support to install platform extensions (sonic-net#1578)
968c781 [config reload] Removed job-mode for sonic.target restart (sonic-net#1820)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants