Stop/start correct BGP agent for model on cEOSLab peers#18748
Merged
yxieca merged 1 commit intosonic-net:masterfrom Jun 4, 2025
Merged
Stop/start correct BGP agent for model on cEOSLab peers#18748yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
…tart the appropriate agent.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Jun 3, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 4, 2025
…tart the (sonic-net#18748) What is the motivation for this PR? Addressing this bug means that the test bgp/test_bgp_gr_helper.py will restart the correct "bgpd" agent and pass irrespective of the version of cEOSLab being run on the docker peers. How did you do it? The test runs the command "show ip route summary | json" on the cEOSLab peer instance and parses the output to identify whether or not the instance is running in "multi-agent" mode. This information is then used to start/stop either the "Bgp" or "Rib" processes. How did you verify/test it? Verified by running the same bgp/test_bgp_gr_helper.py with and without the fix. With the fix the correct "bgpd" agent is restarted by the test.
Collaborator
|
Cherry-pick PR to 202505: #18803 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jun 5, 2025
…tart the (#18748) What is the motivation for this PR? Addressing this bug means that the test bgp/test_bgp_gr_helper.py will restart the correct "bgpd" agent and pass irrespective of the version of cEOSLab being run on the docker peers. How did you do it? The test runs the command "show ip route summary | json" on the cEOSLab peer instance and parses the output to identify whether or not the instance is running in "multi-agent" mode. This information is then used to start/stop either the "Bgp" or "Rib" processes. How did you verify/test it? Verified by running the same bgp/test_bgp_gr_helper.py with and without the fix. With the fix the correct "bgpd" agent is restarted by the test.
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
11 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#383 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
Contributor
|
@kperumalbfn could you pls help add this in 202411 as well? |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 8, 2025
…tart the (sonic-net#18748) What is the motivation for this PR? Addressing this bug means that the test bgp/test_bgp_gr_helper.py will restart the correct "bgpd" agent and pass irrespective of the version of cEOSLab being run on the docker peers. How did you do it? The test runs the command "show ip route summary | json" on the cEOSLab peer instance and parses the output to identify whether or not the instance is running in "multi-agent" mode. This information is then used to start/stop either the "Bgp" or "Rib" processes. How did you verify/test it? Verified by running the same bgp/test_bgp_gr_helper.py with and without the fix. With the fix the correct "bgpd" agent is restarted by the test.
Collaborator
|
Cherry-pick PR to 202411: #19473 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jul 9, 2025
…tart the (#18748) What is the motivation for this PR? Addressing this bug means that the test bgp/test_bgp_gr_helper.py will restart the correct "bgpd" agent and pass irrespective of the version of cEOSLab being run on the docker peers. How did you do it? The test runs the command "show ip route summary | json" on the cEOSLab peer instance and parses the output to identify whether or not the instance is running in "multi-agent" mode. This information is then used to start/stop either the "Bgp" or "Rib" processes. How did you verify/test it? Verified by running the same bgp/test_bgp_gr_helper.py with and without the fix. With the fix the correct "bgpd" agent is restarted by the test.
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Aug 2, 2025
Code sync sonic-net/sonic-mgmt:202411 => 202412 ``` * 3124d52 (HEAD -> code-sync-202412, origin/code-sync-202412) r12f 250710:1626 - Merge remote-tracking branch 'base/202411' into code-sync-202412 |\ | * b1b95dc (base/202411) zitingguo-ms 250513:1848 - Fix PortChannel name matching in verify_attr_change to handle leading spaces (sonic-net#18301) | * 7461bf3 wrideout-arista 250604:1542 - Determine if the eos switch is running in multiagent mode, and stop/start the (sonic-net#18748) | * 4346afd Dashuai Zhang 250411:0103 - update d18u8s4 PT0 ASN to 4 bytes (sonic-net#17888) | * de1b1b4 Ryangwaite 250709:1028 - Skip multi-hop upgrade tests on non-T0 testbeds (sonic-net#19078) (sonic-net#19326) | * 573d42d Cong Hou 250709:0232 - Update the skip for test test_qos_dscp_mapping.py (sonic-net#19381) | * 3eb65b9 Yawen 250708:1743 - Unskip test_qos_sai for dualtor-aa-64-breakout (sonic-net#19363) | * f0c9705 Cong Hou 250707:2351 - xfail generic hash test on dualtor (sonic-net#19383) | * d378110 eyakubch 250707:0546 - Reduce flakiness of test_l2_configure.py. (sonic-net#18831) | * 043dba8 ShiyanWangMS 250703:0935 - Fix the ignore pattern - leapsecond file expired warning (sonic-net#19332) | * 92af38f zitingguo-ms 250703:1958 - Unskip testQosSaiHeadroomPoolWatermark on t0-d18u8s4 (sonic-net#19287) (sonic-net#19342) | * 0b7e4de Chuan Wu 250704:0334 - Add background traffic for test_pfc_pause_extra_lossless test (sonic-net#19218) ```
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…tart the (sonic-net#18748) What is the motivation for this PR? Addressing this bug means that the test bgp/test_bgp_gr_helper.py will restart the correct "bgpd" agent and pass irrespective of the version of cEOSLab being run on the docker peers. How did you do it? The test runs the command "show ip route summary | json" on the cEOSLab peer instance and parses the output to identify whether or not the instance is running in "multi-agent" mode. This information is then used to start/stop either the "Bgp" or "Rib" processes. How did you verify/test it? Verified by running the same bgp/test_bgp_gr_helper.py with and without the fix. With the fix the correct "bgpd" agent is restarted by the test. Signed-off-by: opcoder0 <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…tart the (sonic-net#18748) What is the motivation for this PR? Addressing this bug means that the test bgp/test_bgp_gr_helper.py will restart the correct "bgpd" agent and pass irrespective of the version of cEOSLab being run on the docker peers. How did you do it? The test runs the command "show ip route summary | json" on the cEOSLab peer instance and parses the output to identify whether or not the instance is running in "multi-agent" mode. This information is then used to start/stop either the "Bgp" or "Rib" processes. How did you verify/test it? Verified by running the same bgp/test_bgp_gr_helper.py with and without the fix. With the fix the correct "bgpd" agent is restarted by the test. Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…tart the (sonic-net#18748) What is the motivation for this PR? Addressing this bug means that the test bgp/test_bgp_gr_helper.py will restart the correct "bgpd" agent and pass irrespective of the version of cEOSLab being run on the docker peers. How did you do it? The test runs the command "show ip route summary | json" on the cEOSLab peer instance and parses the output to identify whether or not the instance is running in "multi-agent" mode. This information is then used to start/stop either the "Bgp" or "Rib" processes. How did you verify/test it? Verified by running the same bgp/test_bgp_gr_helper.py with and without the fix. With the fix the correct "bgpd" agent is restarted by the test. Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…tart the (sonic-net#18748) What is the motivation for this PR? Addressing this bug means that the test bgp/test_bgp_gr_helper.py will restart the correct "bgpd" agent and pass irrespective of the version of cEOSLab being run on the docker peers. How did you do it? The test runs the command "show ip route summary | json" on the cEOSLab peer instance and parses the output to identify whether or not the instance is running in "multi-agent" mode. This information is then used to start/stop either the "Bgp" or "Rib" processes. How did you verify/test it? Verified by running the same bgp/test_bgp_gr_helper.py with and without the fix. With the fix the correct "bgpd" agent is restarted by the test.
Contributor
|
Need to backport to msft-202503 |
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…tart the (sonic-net#18748) What is the motivation for this PR? Addressing this bug means that the test bgp/test_bgp_gr_helper.py will restart the correct "bgpd" agent and pass irrespective of the version of cEOSLab being run on the docker peers. How did you do it? The test runs the command "show ip route summary | json" on the cEOSLab peer instance and parses the output to identify whether or not the instance is running in "multi-agent" mode. This information is then used to start/stop either the "Bgp" or "Rib" processes. How did you verify/test it? Verified by running the same bgp/test_bgp_gr_helper.py with and without the fix. With the fix the correct "bgpd" agent is restarted by the test. Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…tart the (sonic-net#18748) What is the motivation for this PR? Addressing this bug means that the test bgp/test_bgp_gr_helper.py will restart the correct "bgpd" agent and pass irrespective of the version of cEOSLab being run on the docker peers. How did you do it? The test runs the command "show ip route summary | json" on the cEOSLab peer instance and parses the output to identify whether or not the instance is running in "multi-agent" mode. This information is then used to start/stop either the "Bgp" or "Rib" processes. How did you verify/test it? Verified by running the same bgp/test_bgp_gr_helper.py with and without the fix. With the fix the correct "bgpd" agent is restarted by the test. Signed-off-by: Yael Tzur <[email protected]>
11 tasks
Collaborator
|
Cherry-pick PR to msft-202503: Azure/sonic-mgmt.msft#999 |
mssonicbld
added
Included in msft-202503 Branch
and removed
Created PR to msft-202503 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Depending on the version of cEOSLab being run, the docker peer devices to the SONiC DUT may be running in "multi-agent" mode. This means that the agent referred to as "bgpd" in testing may differ based on the mode. When running in "multi-agent" mode, the "Bgp" agent needs to be stopped, instead of "Rib". The mode is determined based on the output of a CLI show-command run on the cEOSLab docker peer.
Type of change
Back port request
Approach
What is the motivation for this PR?
Addressing this bug means that the test bgp/test_bgp_gr_helper.py will restart the correct "bgpd" agent and pass irrespective of the version of cEOSLab being run on the docker peers.
How did you do it?
The test runs the command "show ip route summary | json" on the cEOSLab peer instance and parses the output to identify whether or not the instance is running in "multi-agent" mode. This information is then used to start/stop either the "Bgp" or "Rib" processes.
How did you verify/test it?
Verified by running the same bgp/test_bgp_gr_helper.py with and without the fix. With the fix the correct "bgpd" agent is restarted by the test.
Any platform specific information?
None.
Supported testbed topology if it's a new test case?
No new test case.
Documentation