[action] [PR:18748] Stop/start correct BGP agent for model on cEOSLab peers#383
Merged
mssonicbld merged 1 commit intoAzure:202412from Jun 11, 2025
Merged
Conversation
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) Depending on the version of cEOSLab being run, the docker peer devices to the SONiC DUT may be running in "multi-agent" mode. This means that the agent referred to as "bgpd" in testing may differ based on the mode. When running in "multi-agent" mode, the "Bgp" agent needs to be stopped, instead of "Rib". The mode is determined based on the output of a CLI show-command run on the cEOSLab docker peer. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? Addressing this bug means that the test bgp/test_bgp_gr_helper.py will restart the correct "bgpd" agent and pass irrespective of the version of cEOSLab being run on the docker peers. #### How did you do it? The test runs the command "show ip route summary | json" on the cEOSLab peer instance and parses the output to identify whether or not the instance is running in "multi-agent" mode. This information is then used to start/stop either the "Bgp" or "Rib" processes. #### How did you verify/test it? Verified by running the same bgp/test_bgp_gr_helper.py with and without the fix. With the fix the correct "bgpd" agent is restarted by the test. #### Any platform specific information? None. #### Supported testbed topology if it's a new test case? No new test case. ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
Collaborator
Author
|
Original PR: sonic-net/sonic-mgmt#18748 |
Collaborator
Author
|
/azp run |
11 tasks
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Depending on the version of cEOSLab being run, the docker peer devices to the SONiC DUT may be running in "multi-agent" mode. This means that the agent referred to as "bgpd" in testing may differ based on the mode. When running in "multi-agent" mode, the "Bgp" agent needs to be stopped, instead of "Rib". The mode is determined based on the output of a CLI show-command run on the cEOSLab docker peer.
Type of change
Back port request
Approach
What is the motivation for this PR?
Addressing this bug means that the test bgp/test_bgp_gr_helper.py will restart the correct "bgpd" agent and pass irrespective of the version of cEOSLab being run on the docker peers.
How did you do it?
The test runs the command "show ip route summary | json" on the cEOSLab peer instance and parses the output to identify whether or not the instance is running in "multi-agent" mode. This information is then used to start/stop either the "Bgp" or "Rib" processes.
How did you verify/test it?
Verified by running the same bgp/test_bgp_gr_helper.py with and without the fix. With the fix the correct "bgpd" agent is restarted by the test.
Any platform specific information?
None.
Supported testbed topology if it's a new test case?
No new test case.
Documentation