Skip to content

Skip multi-hop upgrade tests on non-T0 testbeds#19078

Merged
StormLiangMS merged 2 commits intosonic-net:masterfrom
Ryangwaite:skip-multi-hop-test-on-non-t0-topos
Jun 24, 2025
Merged

Skip multi-hop upgrade tests on non-T0 testbeds#19078
StormLiangMS merged 2 commits intosonic-net:masterfrom
Ryangwaite:skip-multi-hop-test-on-non-t0-topos

Conversation

@Ryangwaite
Copy link
Copy Markdown
Contributor

@Ryangwaite Ryangwaite commented Jun 18, 2025

Description of PR

Only T0 testbeds perform warm-reboots, hence only these support the multi-hop warmboot test case.

MSFT ADO: 33256099

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Skip running tests on topologies that don't support it causing redundant test runs.

How did you do it?

Added a check to skip the test on non-T0 testbeds.

How did you verify/test it?

Any platform specific information?

Only run it on t0 testbeds from now on.

Supported testbed topology if it's a new test case?

Documentation

Only T0 testbeds perform warm-reboots, hence only these support the
multi-hop warmboot test case.
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 13aa2e9 into sonic-net:master Jun 24, 2025
20 checks passed
@mssonicbld
Copy link
Copy Markdown
Collaborator

@Ryangwaite PR conflicts with 202411 branch

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jun 25, 2025
What is the motivation for this PR?
Skip running tests on topologies that don't support it causing redundant test runs.

How did you do it?
Added a check to skip the test on non-T0 testbeds.

How did you verify/test it?
Any platform specific information?
Only run it on t0 testbeds from now on.
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202505: #19184

mssonicbld pushed a commit that referenced this pull request Jun 25, 2025
What is the motivation for this PR?
Skip running tests on topologies that don't support it causing redundant test runs.

How did you do it?
Added a check to skip the test on non-T0 testbeds.

How did you verify/test it?
Any platform specific information?
Only run it on t0 testbeds from now on.
Ryangwaite added a commit to Ryangwaite/sonic-mgmt that referenced this pull request Jul 2, 2025
What is the motivation for this PR?
Skip running tests on topologies that don't support it causing redundant test runs.

How did you do it?
Added a check to skip the test on non-T0 testbeds.

How did you verify/test it?
Any platform specific information?
Only run it on t0 testbeds from now on.
Ryangwaite added a commit to Ryangwaite/sonic-mgmt that referenced this pull request Jul 4, 2025
What is the motivation for this PR?
Skip running tests on topologies that don't support it causing redundant test runs.

How did you do it?
Added a check to skip the test on non-T0 testbeds.

How did you verify/test it?
Any platform specific information?
Only run it on t0 testbeds from now on.
StormLiangMS pushed a commit that referenced this pull request Jul 9, 2025
What is the motivation for this PR?
Skip running tests on topologies that don't support it causing redundant test runs.

How did you do it?
Added a check to skip the test on non-T0 testbeds.

How did you verify/test it?
Any platform specific information?
Only run it on t0 testbeds from now on.
sdszhang pushed a commit to sdszhang/sonic-mgmt that referenced this pull request Aug 2, 2025
Code sync sonic-net/sonic-mgmt:202411 => 202412

```
*   3124d52 (HEAD -> code-sync-202412, origin/code-sync-202412) r12f 250710:1626 - Merge remote-tracking branch 'base/202411' into code-sync-202412
|\
| * b1b95dc (base/202411) zitingguo-ms 250513:1848 - Fix PortChannel name matching in verify_attr_change to handle leading spaces (sonic-net#18301)
| * 7461bf3 wrideout-arista 250604:1542 - Determine if the eos switch is running in multiagent mode, and stop/start the (sonic-net#18748)
| * 4346afd Dashuai Zhang 250411:0103 - update d18u8s4 PT0 ASN to 4 bytes (sonic-net#17888)
| * de1b1b4 Ryangwaite 250709:1028 - Skip multi-hop upgrade tests on non-T0 testbeds (sonic-net#19078) (sonic-net#19326)
| * 573d42d Cong Hou 250709:0232 - Update the skip for test test_qos_dscp_mapping.py (sonic-net#19381)
| * 3eb65b9 Yawen 250708:1743 - Unskip test_qos_sai for dualtor-aa-64-breakout (sonic-net#19363)
| * f0c9705 Cong Hou 250707:2351 - xfail generic hash test on dualtor (sonic-net#19383)
| * d378110 eyakubch 250707:0546 - Reduce flakiness of test_l2_configure.py. (sonic-net#18831)
| * 043dba8 ShiyanWangMS 250703:0935 - Fix the ignore pattern - leapsecond file expired warning (sonic-net#19332)
| * 92af38f zitingguo-ms 250703:1958 - Unskip testQosSaiHeadroomPoolWatermark on t0-d18u8s4 (sonic-net#19287) (sonic-net#19342)
| * 0b7e4de Chuan Wu 250704:0334 - Add background traffic for test_pfc_pause_extra_lossless test (sonic-net#19218)
```
nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Aug 7, 2025
What is the motivation for this PR?
Skip running tests on topologies that don't support it causing redundant test runs.

How did you do it?
Added a check to skip the test on non-T0 testbeds.

How did you verify/test it?
Any platform specific information?
Only run it on t0 testbeds from now on.
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
What is the motivation for this PR?
Skip running tests on topologies that don't support it causing redundant test runs.

How did you do it?
Added a check to skip the test on non-T0 testbeds.

How did you verify/test it?
Any platform specific information?
Only run it on t0 testbeds from now on.

Signed-off-by: opcoder0 <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
What is the motivation for this PR?
Skip running tests on topologies that don't support it causing redundant test runs.

How did you do it?
Added a check to skip the test on non-T0 testbeds.

How did you verify/test it?
Any platform specific information?
Only run it on t0 testbeds from now on.

Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
What is the motivation for this PR?
Skip running tests on topologies that don't support it causing redundant test runs.

How did you do it?
Added a check to skip the test on non-T0 testbeds.

How did you verify/test it?
Any platform specific information?
Only run it on t0 testbeds from now on.

Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
What is the motivation for this PR?
Skip running tests on topologies that don't support it causing redundant test runs.

How did you do it?
Added a check to skip the test on non-T0 testbeds.

How did you verify/test it?
Any platform specific information?
Only run it on t0 testbeds from now on.

Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
What is the motivation for this PR?
Skip running tests on topologies that don't support it causing redundant test runs.

How did you do it?
Added a check to skip the test on non-T0 testbeds.

How did you verify/test it?
Any platform specific information?
Only run it on t0 testbeds from now on.
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
What is the motivation for this PR?
Skip running tests on topologies that don't support it causing redundant test runs.

How did you do it?
Added a check to skip the test on non-T0 testbeds.

How did you verify/test it?
Any platform specific information?
Only run it on t0 testbeds from now on.

Signed-off-by: Guy Shemesh <[email protected]>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
What is the motivation for this PR?
Skip running tests on topologies that don't support it causing redundant test runs.

How did you do it?
Added a check to skip the test on non-T0 testbeds.

How did you verify/test it?
Any platform specific information?
Only run it on t0 testbeds from now on.

Signed-off-by: Yael Tzur <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
What is the motivation for this PR?
Skip running tests on topologies that don't support it causing redundant test runs.

How did you do it?
Added a check to skip the test on non-T0 testbeds.

How did you verify/test it?
Any platform specific information?
Only run it on t0 testbeds from now on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants