Add check and waiting for exabgp http server#1813
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Jun 28, 2020
Merged
Add check and waiting for exabgp http server#1813bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms merged 1 commit intosonic-net:masterfrom
Conversation
wangxin
requested changes
Jun 28, 2020
tests/common/utilities.py
Outdated
Collaborator
There was a problem hiding this comment.
Please align the code and remove extra spaces around =.
Collaborator
There was a problem hiding this comment.
Please add argument module_ignore_errors=True. Otherwise this step will raise exception after PR #1786 is merged.
Collaborator
Author
There was a problem hiding this comment.
Done.
Thank you so much!
a405ab6 to
0ed6962
Compare
0ed6962 to
af541ab
Compare
wangxin
approved these changes
Jun 28, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
linkmgrrd: * d6518dd 2022-06-14 | Fix IP header checksum in handleSendSwitchCommand (sonic-net#88) (HEAD -> 202205, github/202205) [Jing Zhang] swss: * 4430445 2022-06-03 | Add port counter sanity check (sonic-net#2300) (HEAD -> 202205, github/202205) [Junhua Zhai] * 01b017c 2022-05-28 | [counter] Support gearbox counters (sonic-net#2218) [Junhua Zhai] utilities: * ce96543 2022-05-26 | [subinterface]Avoid removing the subinterface when last configured ip is removed (sonic-net#2181) (HEAD -> 202205, github/202205) [Sudharsan Dhamal Gopalarathnam] * ed97c6f 2022-05-26 | [subinterface] Fix route add command to accept subinterface as dev (sonic-net#2180) [Sudharsan Dhamal Gopalarathnam] * 53ff644 2022-06-09 | [gendump] Add Support to dump BCM-DNX commands (sonic-net#1813) [saksarav-nokia] * 0e31790 2022-06-15 | [config][muxcable] fix minor config DB logic issue (sonic-net#2210) [vdahiya12] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
#### Why I did it Update submodule pointer for swss to include recent changes 4f1d726 [portsorch] fix errors when moving port from one lag to another. (sonic-net#1797) ae44701 [orchagent] Put port configuration to APPL_DB according to autoneg mode (sonic-net#1769) 5295f91 Add failure handling for SAI get operations (sonic-net#1768) 7c7c451 Revert recirc port change (sonic-net#1813) 5528ebf Cleanup code (sonic-net#1814)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Add check and waiting for exabgp http server to get ready.
Type of change
Approach
What is the motivation for this PR?
The exabgp plugin has a problem in handling 'started' state:
The start_exabgp method only checks the status returned by supervisorctl,
However, the http service (implemented in http_api.py) may be not ready at that time. As a result, the following call announce_route raises an exception.
Actually, it takes more than 20 seconds for http server gets ready after running http_api.py in vtestbed.
How did you do it?
Add an End-to-End check and wait after exabgp('started'), until http server is ready.
How did you verify/test it?
Run test_bgp_speaker.py and test_announce_routes.py in my vtestbed.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
No.
Documentation
No.