Fix test failure in test_cont_link_flap.py#8128
Merged
wsycqyz merged 3 commits intosonic-net:masterfrom Apr 25, 2023
Merged
Conversation
xwjiang-ms
approved these changes
Apr 25, 2023
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 3, 2023
Fixes test failure in test_cont_link_flap.py caused by sonic-net#7968 What is the motivation for this PR? Test failed with error: File "/azp/_work/6/s/tests/platform_tests/link_flap/test_cont_link_flap.py", line 145, in test_cont_link_flap incr_redis_memory = float(end_time_redis_memory) - float(start_time_redis_memory) ValueError: could not convert string to float: '\1' How did you do it? Correct reg express. How did you verify/test it? Manually run test case: test_cont_link_flap.py
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
Fixes test failure in test_cont_link_flap.py caused by sonic-net#7968 What is the motivation for this PR? Test failed with error: File "/azp/_work/6/s/tests/platform_tests/link_flap/test_cont_link_flap.py", line 145, in test_cont_link_flap incr_redis_memory = float(end_time_redis_memory) - float(start_time_redis_memory) ValueError: could not convert string to float: '\1' How did you do it? Correct reg express. How did you verify/test it? Manually run test case: test_cont_link_flap.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes test failure in test_cont_link_flap.py caused by #7968
Type of change
Back port request
Approach
What is the motivation for this PR?
Test failed with error:
File "/azp/_work/6/s/tests/platform_tests/link_flap/test_cont_link_flap.py", line 145, in test_cont_link_flap
incr_redis_memory = float(end_time_redis_memory) - float(start_time_redis_memory)
ValueError: could not convert string to float: '\1'
How did you do it?
Correct reg express.
How did you verify/test it?
Manually run test case: test_cont_link_flap.py
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation