Skip to content

Fix testQosSaiDwrr issue#11158

Closed
JibinBao wants to merge 1 commit intosonic-net:202205from
JibinBao:fix_testQosSaiDwrr_issue_202205
Closed

Fix testQosSaiDwrr issue#11158
JibinBao wants to merge 1 commit intosonic-net:202205from
JibinBao:fix_testQosSaiDwrr_issue_202205

Conversation

@JibinBao
Copy link
Contributor

Description of PR

Fix issue:#11156

  1. When sending a burst packet, sometimes packets will lost on the server side, which will cause a test fail, so change the port speed to decrease the burst rate
  2. When the previous test case just sends a large of packets only by one queue such as queue1, then Dwrr test might fail, because queue1 has got much chance to send packets before, so it will get less chance to send packets than expected. Therefore add one first run as a dry run, and it will not check Dwrr function. After the dry run, all tested queues can be scheduled so that all queues are at the same start.

Summary:
Fixes # (issue)#11156

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305

Approach

What is the motivation for this PR?

Fix testQosSaiDwrr issue: #11156

How did you do it?

  1. Add one parameter port_target_speed. when port_target_speed is set, change the port speed to the specified one.
  2. Dry run before real test

How did you verify/test it?

Run testQosSaiDwrr

Any platform specific information?

Any

Supported testbed topology if it's a new test case?

Documentation

@JibinBao JibinBao marked this pull request as draft December 29, 2023 09:35
1. When sending a burst packet, sometimes packets will lost on the server side, which will cause a test fail, so change the port speed to decrease the burst rate
2. When the previous test case just sends a large of packets only by one queue such as queue1, then Dwrr test might fail, because queue1 has got much chance to send packets before, so it will get less chance to send packets than expected. Therefore add one first run as a dry run, and it will not check Dwrr function. After the dry run, all tested queues can be scheduled so that all queues are at the same start.

Change-Id: Iba88491b537b54650d87bae3521625fc661e092e
@JibinBao JibinBao force-pushed the fix_testQosSaiDwrr_issue_202205 branch from ea39156 to c876956 Compare December 29, 2023 10:30
@JibinBao JibinBao closed this Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant