Skip to content

[loganalyzer] Enhance Loganalyzer Fixture With Custom Regex#1797

Merged
tahmed-dev merged 1 commit intosonic-net:masterfrom
tahmed-dev:taahme/add-custom-regex-loganalyzer
Jun 23, 2020
Merged

[loganalyzer] Enhance Loganalyzer Fixture With Custom Regex#1797
tahmed-dev merged 1 commit intosonic-net:masterfrom
tahmed-dev:taahme/add-custom-regex-loganalyzer

Conversation

@tahmed-dev
Copy link
Contributor

Description of PR

Summary:
Loganalyzer has build int regex to match log files against. Some
test cases while appropriately disabling some services, they fail
loganalyzer scrutiny if it happens to match one of those regex's.
This PR add ability for individual test cases to manipulate
loganalyzer regex's.

signed-of-by: Tamer Ahmed [email protected]
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Loganalyzer has build int regex to match log files against. Some
test cases while appropriately disabling some services, they fail
loganalyzer scrutiny if it happend to match one of those regex's.
This PR add ability for individual test cases to manipulate
loganalyzer regex's.

signed-of-by: Tamer Ahmed <[email protected]>
@tahmed-dev tahmed-dev requested a review from a team June 19, 2020 22:42
@neethajohn
Copy link
Contributor

I do not understand this change. I think the existing code correctly loads the built in list if there is no disable_loganalyzer present in the testcases. If a testcase needs to manipulate the loganalyzer regex, there is an option to do so in loganalyzer.py.. (ignore_regex, expect_regex, match_regexp)

@tahmed-dev
Copy link
Contributor Author

I do not understand this change. I think the existing code correctly loads the built in list if there is no disable_loganalyzer present in the testcases. If a testcase needs to manipulate the loganalyzer regex, there is an option to do so in loganalyzer.py.. (ignore_regex, expect_regex, match_regexp)

There is another PR that make user of this change. The point is to have the step that loads the regex's before yield in the object such that test cases can add/remove to/from these regex.

@tahmed-dev tahmed-dev marked this pull request as ready for review June 19, 2020 23:18
@neethajohn
Copy link
Contributor

Discussed offline, Tamer will put in another PR to init the loganalyzer only if its not disabled

@tahmed-dev tahmed-dev merged commit 662d25b into sonic-net:master Jun 23, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
#### Why I did it
Update submodule pointer for swss to include recent changes

4f1d726 [portsorch] fix errors when moving port from one lag to another. (sonic-net#1797)
ae44701 [orchagent] Put port configuration to APPL_DB according to autoneg mode (sonic-net#1769)
5295f91 Add failure handling for SAI get operations (sonic-net#1768)
7c7c451 Revert recirc port change (sonic-net#1813)
5528ebf Cleanup code (sonic-net#1814)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
sonic-swss
29a0483 Cache routes for single nexthop for faster retrieval (sonic-net#1922)

sonic-utilities
9bc6500 Modified the 'show ipv6 link-local-mode' command to display all interfaces by default (sonic-net#1797)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants