sonic-host-services changes for gNOI Warm Reboot by rkavitha-hcl · Pull Request #191 · sonic-net/sonic-host-services

rkavitha-hcl · 2024-11-29T13:39:58Z

Adding sonic-host-services changes for warm reboot .
Adding HALT method support for sonic-host-services

linux-foundation-easycla · 2024-11-29T13:40:02Z

The committers listed above are authorized under a signed CLA.

✅ login: rkavitha-hcl (c4a5013, 8773883)

host_modules/gnoi_reboot.py

tests/gnoi_reboot_test.py

kishanps · 2024-12-06T02:00:05Z

@github76543 Joh, can you PTAL and signoff.

hdwhdw

Can you please look at ff73070 and see if this is something you can reuse?

host_modules/gnoi_reboot.py

kishanps · 2024-12-26T19:47:13Z

Can you please look at ff73070 and see if this is something you can reuse?

Thanks @hdwhdw for the reference. The reboot dbus service also needs a request/response framework which is what this PR does and IIUC @vvolam went with the other one as a stop gap solution.

Adding @github76543 (John) for additional inputs.

hdwhdw · 2024-12-27T07:13:51Z

@kishanps thanks for clarifying. If so consider renaming the service to something more general than gnoi_reboot. Maybe 'async_system'? Having one module for each gnoi service can clutter the dbus codebase.

Also does it make sense to add your api to systemd service and call it async reboot, alongside @vvolam API?

mssonicbld · 2025-01-06T13:00:06Z

/azp run

azure-pipelines · 2025-01-06T13:00:28Z

Azure Pipelines successfully started running 1 pipeline(s).

kishanps · 2025-01-10T19:50:24Z

@kishanps thanks for clarifying. If so consider renaming the service to something more general than gnoi_reboot. Maybe 'async_system'? Having one module for each gnoi service can clutter the dbus codebase.

Also does it make sense to add your api to systemd service and call it async reboot, alongside @vvolam API?

@hdwhdw @github76543 @rkavitha-hcl @jaanah-hcl

I discussed with John, Dawei Huang & @vvolam and we all agree that reboot will be a separate dbus service and hence rename gnoi_reboot to just reboot. And remove the commit id ff73070 alongwith this PR to avoid the duplication.

mssonicbld · 2025-01-27T10:06:39Z

/azp run

azure-pipelines · 2025-01-27T10:06:47Z

Pull request contains merge conflicts.

mssonicbld · 2025-01-27T11:13:13Z

/azp run

azure-pipelines · 2025-01-27T11:13:22Z

Azure Pipelines successfully started running 1 pipeline(s).

host_modules/reboot.py

mssonicbld · 2025-02-06T15:21:48Z

/azp run

azure-pipelines · 2025-02-06T15:21:57Z

Azure Pipelines successfully started running 1 pipeline(s).

host_modules/reboot.py

mssonicbld · 2025-02-12T14:06:43Z

/azp run

azure-pipelines · 2025-02-27T05:32:38Z

Azure Pipelines successfully started running 1 pipeline(s).

rkavitha-hcl · 2025-02-27T05:38:46Z

@kishanps @rkavitha-hcl Could you fix build failures as well?

Build is fixed and branch is rebased

mssonicbld · 2025-02-27T10:39:32Z

/azp run

azure-pipelines · 2025-02-27T10:39:40Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-02-27T11:06:42Z

/azp run

azure-pipelines · 2025-02-27T11:06:50Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-02-27T11:25:30Z

/azp run

azure-pipelines · 2025-02-27T11:25:38Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-02-27T11:27:14Z

/azp run

azure-pipelines · 2025-02-27T11:27:26Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-02-28T16:12:25Z

/azp run

azure-pipelines · 2025-02-28T16:12:34Z

Azure Pipelines successfully started running 1 pipeline(s).

vvolam

Other than those minor changes, remaining LGTM. Thank you.

host_modules/reboot.py

mssonicbld · 2025-03-03T14:06:00Z

/azp run

azure-pipelines · 2025-03-03T14:06:08Z

Azure Pipelines successfully started running 1 pipeline(s).

host_modules/reboot.py

mssonicbld · 2025-03-03T18:56:10Z

/azp run

azure-pipelines · 2025-03-03T18:56:20Z

Azure Pipelines successfully started running 1 pipeline(s).

rkavitha-hcl force-pushed the gnoi_wr_hs_new branch from e42ae0a to 76f70db Compare November 29, 2024 13:43

kishanps reviewed Dec 6, 2024

View reviewed changes

host_modules/gnoi_reboot.py Outdated Show resolved Hide resolved

tests/gnoi_reboot_test.py Outdated Show resolved Hide resolved

rkavitha-hcl force-pushed the gnoi_wr_hs_new branch 2 times, most recently from a230e6e to f71371e Compare December 6, 2024 06:23

rkavitha-hcl mentioned this pull request Dec 13, 2024

Warmboot Manager HLD for warm reboot improvement sonic-net/SONiC#1485

Merged

hdwhdw self-requested a review December 26, 2024 00:56

hdwhdw requested changes Dec 26, 2024

View reviewed changes

host_modules/gnoi_reboot.py Outdated Show resolved Hide resolved

hdwhdw requested a review from vvolam December 27, 2024 07:14

rkavitha-hcl force-pushed the gnoi_wr_hs_new branch from f71371e to 12e3f91 Compare January 6, 2025 13:00

rkavitha-hcl force-pushed the gnoi_wr_hs_new branch from 12e3f91 to f568f97 Compare January 27, 2025 10:06

hdwhdw mentioned this pull request Jan 31, 2025

Add testcases for Reboot sonic-net/sonic-mgmt#16576

Closed

11 tasks

kishanps reviewed Feb 3, 2025

View reviewed changes

host_modules/reboot.py Outdated Show resolved Hide resolved

rkavitha-hcl force-pushed the gnoi_wr_hs_new branch from 2f86ace to 24b587c Compare February 6, 2025 15:21

rkavitha-hcl mentioned this pull request Feb 7, 2025

sonic-host-services changes for gNOI Cold Reboot #181

Open

vvolam reviewed Feb 7, 2025

View reviewed changes

host_modules/reboot.py Outdated Show resolved Hide resolved

rkavitha-hcl force-pushed the gnoi_wr_hs_new branch from 24b587c to 61e547d Compare February 12, 2025 14:06

rkavitha-hcl force-pushed the gnoi_wr_hs_new branch from 7eb5420 to 4e4a719 Compare February 27, 2025 10:39

sonic-host-services changes for gNOI Cold Reboot

8773883

rkavitha-hcl force-pushed the gnoi_wr_hs_new branch from 4e4a719 to f24657e Compare February 27, 2025 11:06

rkavitha-hcl force-pushed the gnoi_wr_hs_new branch from f24657e to e60d9f2 Compare February 27, 2025 11:25

rkavitha-hcl force-pushed the gnoi_wr_hs_new branch from e60d9f2 to 9872013 Compare February 27, 2025 11:27

rkavitha-hcl force-pushed the gnoi_wr_hs_new branch from 9872013 to 6acda57 Compare February 28, 2025 16:12

vvolam reviewed Feb 28, 2025

View reviewed changes

host_modules/reboot.py Outdated Show resolved Hide resolved

host_modules/reboot.py Outdated Show resolved Hide resolved

rkavitha-hcl force-pushed the gnoi_wr_hs_new branch from 6acda57 to 4988fc8 Compare March 3, 2025 14:05

vvolam approved these changes Mar 3, 2025

View reviewed changes

host_modules/reboot.py Outdated Show resolved Hide resolved

sonic-host-services changes for gNOI Warm Reboot

c4a5013

rkavitha-hcl force-pushed the gnoi_wr_hs_new branch from 4988fc8 to c4a5013 Compare March 3, 2025 18:56

hdwhdw merged commit 84c7d72 into sonic-net:master Mar 3, 2025
5 checks passed

hdwhdw mentioned this pull request Mar 10, 2025

Bug: test_gnmi_config_db.py::test_gnmi_configdb_full_01 uses wrong implementation of GNOI Reboot. sonic-net/sonic-mgmt#17436

Closed

jkmar mentioned this pull request May 6, 2025

Regression: gNOI reboot without message fails sonic-net/sonic-buildimage#22545

Closed

Conversation

rkavitha-hcl commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linux-foundation-easycla bot commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kishanps commented Dec 6, 2024

Uh oh!

hdwhdw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kishanps commented Dec 26, 2024

Uh oh!

hdwhdw commented Dec 27, 2024

Uh oh!

mssonicbld commented Jan 6, 2025

Uh oh!

azure-pipelines bot commented Jan 6, 2025

Uh oh!

kishanps commented Jan 10, 2025

Uh oh!

mssonicbld commented Jan 27, 2025

Uh oh!

azure-pipelines bot commented Jan 27, 2025

Uh oh!

mssonicbld commented Jan 27, 2025

Uh oh!

azure-pipelines bot commented Jan 27, 2025

Uh oh!

Uh oh!

mssonicbld commented Feb 6, 2025

Uh oh!

azure-pipelines bot commented Feb 6, 2025

Uh oh!

Uh oh!

mssonicbld commented Feb 12, 2025

Uh oh!

azure-pipelines bot commented Feb 27, 2025

Uh oh!

rkavitha-hcl commented Feb 27, 2025

Uh oh!

mssonicbld commented Feb 27, 2025

Uh oh!

azure-pipelines bot commented Feb 27, 2025

Uh oh!

mssonicbld commented Feb 27, 2025

Uh oh!

azure-pipelines bot commented Feb 27, 2025

Uh oh!

mssonicbld commented Feb 27, 2025

Uh oh!

azure-pipelines bot commented Feb 27, 2025

Uh oh!

mssonicbld commented Feb 27, 2025

Uh oh!

azure-pipelines bot commented Feb 27, 2025

Uh oh!

mssonicbld commented Feb 28, 2025

Uh oh!

azure-pipelines bot commented Feb 28, 2025

Uh oh!

vvolam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Mar 3, 2025

Uh oh!

azure-pipelines bot commented Mar 3, 2025

Uh oh!

Uh oh!

mssonicbld commented Mar 3, 2025

Uh oh!

azure-pipelines bot commented Mar 3, 2025

Uh oh!

Uh oh!

rkavitha-hcl commented Nov 29, 2024 •

edited

Loading

linux-foundation-easycla bot commented Nov 29, 2024 •

edited

Loading