gNOI Warm Reboot - Added tests by rkavitha-hcl · Pull Request #20801 · sonic-net/sonic-buildimage

rkavitha-hcl · 2024-11-14T11:16:46Z

Why I did it

Work item tracking

Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Added test cases for warm reboot.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

src/sonic-framework/tests/reboot_thread_test.cpp

src/sonic-framework/tests/rebootbe_test.cpp

src/sonic-framework/tests/test_utils_common.cpp

kishanps · 2024-12-06T01:53:54Z

@github76543 Joh, can you PTAL and signoff.

mssonicbld · 2024-12-13T11:26:41Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2024-12-13T11:26:48Z

Pull request contains merge conflicts.

mssonicbld · 2024-12-13T11:43:52Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2024-12-13T11:43:59Z

Pull request contains merge conflicts.

mssonicbld · 2024-12-13T12:23:38Z

/azp run Azure.sonic-buildimage

mssonicbld · 2025-01-27T10:37:03Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-01-27T10:37:09Z

Pull request contains merge conflicts.

mssonicbld · 2025-01-27T12:35:18Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-01-27T12:35:24Z

Pull request contains merge conflicts.

rkavitha-hcl · 2025-01-30T16:24:56Z

Test results:

~/reboot_feature/sonic-buildimage/src/sonic-framework/tests$ ./tests
[==========] Running 41 tests from 4 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from RebootBETest
[ RUN      ] RebootBETest.WarmbootInProgressBlocksNewWarmboot
NOTICE:- Start: --- Starting rebootbackend ---
.
.
.
[       OK ] TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest.TestWarmFailureFollowedByColdBoot/1 (5103 ms)
[----------] 26 tests from TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest (63060 ms total)

[----------] Global test environment tear-down
[==========] 41 tests from 4 test suites ran. (68474 ms total)
[  PASSED  ] 41 tests.

~/reboot_feature/sonic-buildimage/src/sonic-framework/tests$ ./tests_asan 
[==========] Running 41 tests from 4 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from RebootBETest
[ RUN      ] RebootBETest.WarmbootInProgressBlocksNewWarmboot
.
.
.
[       OK ] TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest.TestWarmFailureFollowedByColdBoot/1 (5105 ms)
[----------] 26 tests from TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest (63103 ms total)

[----------] Global test environment tear-down
[==========] 41 tests from 4 test suites ran. (68527 ms total)
[  PASSED  ] 41 tests.

~/reboot_feature/sonic-buildimage/src/sonic-framework/tests$ ./tests_tsan 
[==========] Running 41 tests from 4 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from RebootBETest
[ RUN      ] RebootBETest.WarmbootInProgressBlocksNewWarmboot
NOTICE:- Start: --- Starting rebootbackend ---
.
.
.
[       OK ] TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest.TestWarmFailureFollowedByColdBoot/1 (5105 ms)
[----------] 26 tests from TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest (63119 ms total)

[----------] Global test environment tear-down
[==========] 41 tests from 4 test suites ran. (68746 ms total)
[  PASSED  ] 41 tests.

~/reboot_feature/sonic-buildimage/src/sonic-framework/tests$ ./tests_usan 
[==========] Running 41 tests from 4 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from RebootBETest
[ RUN      ] RebootBETest.WarmbootInProgressBlocksNewWarmboot
.
.
.
[       OK ] TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest.TestWarmFailureFollowedByColdBoot/1 (5103 ms)
[----------] 26 tests from TestWithStartupWarmbootEnabledState/RebootBEAutoStartTest (63062 ms total)

[----------] Global test environment tear-down
[==========] 41 tests from 4 test suites ran. (68473 ms total)
[  PASSED  ] 41 tests.

mssonicbld · 2025-02-12T13:54:43Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-02-12T13:54:55Z

Azure Pipelines successfully started running 1 pipeline(s).

dockers/docker-framework/start.sh

files/build/versions/dockers/docker-framework/versions-deb-bookworm

files/build_templates/init_cfg.json.j2

platform/vs/docker-sonic-vs/start.sh

.gitmodules

src/sonic-framework/rebootbackend/interfaces.cpp

src/sonic-framework/rebootbackend/interfaces.h

src/sonic-framework/rebootbackend/reboot_thread.cpp

qiluo-msft · 2025-02-18T23:56:20Z

rules/framework.mk

@@ -0,0 +1,19 @@
+# framework package
+
+FRAMEWORK = framework_1.0.0_$(CONFIGURED_ARCH).deb


framework

framework is a confusing name, according to HLD, you want to name it as 'WarmbootManager' ? #Pending

Shared the alternative names in the other thread, can we go with sysmgr ?

qiluo-msft · 2025-02-18T23:58:15Z

src/sonic-framework/tests/Makefile.am

+                test_main.cpp
+
+tests_CFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(CFLAGS_GTEST) $(CFLAGS_COVERAGE) $(CFLAGS_SAI)
+tests_CPPFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(CFLAGS_GTEST) $(CFLAGS_COVERAGE) $(CFLAGS_SAI)


COVERAGE

Could you share the coverage data? even better, you can refine build pipeline to expose the coverage data.

Our internal tools show 90% coverage, we will look at refining the build pipeline to expose this as a followup item.

rkavitha-hcl requested review from lguohan, qiluo-msft and xumia as code owners November 14, 2024 11:16

rkavitha-hcl force-pushed the gnoi_wr_PR2 branch 2 times, most recently from b5f6845 to 9dd208a Compare November 15, 2024 12:49

rkavitha-hcl force-pushed the gnoi_wr_PR2 branch 3 times, most recently from 165ac73 to 2bfdab7 Compare November 26, 2024 11:22

kishanps reviewed Nov 27, 2024

View reviewed changes

rkavitha-hcl force-pushed the gnoi_wr_PR2 branch 6 times, most recently from 4194e72 to c3b6888 Compare December 4, 2024 07:39

rkavitha-hcl force-pushed the gnoi_wr_PR2 branch 2 times, most recently from c11590c to ad96646 Compare December 5, 2024 10:44

rkavitha-hcl force-pushed the gnoi_wr_PR2 branch 3 times, most recently from 26e2ea9 to 4b6bfbb Compare December 12, 2024 07:04

rkavitha-hcl mentioned this pull request Dec 13, 2024

Warmboot Manager HLD for warm reboot improvement sonic-net/SONiC#1485

Merged

rkavitha-hcl force-pushed the gnoi_wr_PR2 branch from 4b6bfbb to 2c1d1b3 Compare December 13, 2024 11:26

rkavitha-hcl force-pushed the gnoi_wr_PR2 branch from 2c1d1b3 to b304ab0 Compare December 13, 2024 11:43

rkavitha-hcl force-pushed the gnoi_wr_PR2 branch from b304ab0 to ff82c8b Compare December 13, 2024 12:03

GNOI Cold Reboot

9179ab0

rkavitha-hcl force-pushed the gnoi_wr_PR2 branch 2 times, most recently from 0918d69 to b7f84ed Compare January 27, 2025 10:37

rkavitha-hcl added 6 commits January 27, 2025 11:54

Integrated Rebootbackend changes

7c5edad

gNOI Cold Reboot - Integrated tests

50996eb

gNOI Cold Reboot - Integrated gNOI repository

326aae1

gNOI Cold Reboot - Integrated Docker and Makefile changes

1a2db82

gNOI Warm Reboot - rebootbackend changes

3580ea1

gNOI Warm Reboot - Added tests

b5294f6

rkavitha-hcl force-pushed the gnoi_wr_PR2 branch from b7f84ed to b5294f6 Compare January 27, 2025 12:26

hdwhdw mentioned this pull request Jan 31, 2025

Add testcases for Reboot sonic-net/sonic-mgmt#16576

Closed

11 tasks

Merge branch 'master' into gnoi_wr_PR2

52fe2c8

qiluo-msft reviewed Feb 18, 2025

View reviewed changes

dockers/docker-framework/start.sh Show resolved Hide resolved

qiluo-msft reviewed Feb 18, 2025

View reviewed changes

files/build/versions/dockers/docker-framework/versions-deb-bookworm Show resolved Hide resolved

qiluo-msft requested a review from wen587 February 18, 2025 21:26

qiluo-msft reviewed Feb 18, 2025

View reviewed changes

files/build_templates/init_cfg.json.j2 Show resolved Hide resolved

qiluo-msft reviewed Feb 18, 2025

View reviewed changes

platform/vs/docker-sonic-vs/start.sh Show resolved Hide resolved

qiluo-msft requested a review from hdwhdw February 18, 2025 23:32

qiluo-msft reviewed Feb 18, 2025

View reviewed changes

.gitmodules Show resolved Hide resolved

hdwhdw reviewed Feb 18, 2025

View reviewed changes

qiluo-msft reviewed Feb 18, 2025

View reviewed changes

rkavitha-hcl closed this Apr 25, 2025

		@@ -0,0 +1,19 @@
		# framework package

		FRAMEWORK = framework_1.0.0_$(CONFIGURED_ARCH).deb

Conversation

rkavitha-hcl commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kishanps commented Dec 6, 2024

Uh oh!

mssonicbld commented Dec 13, 2024

Uh oh!

azure-pipelines bot commented Dec 13, 2024

Uh oh!

mssonicbld commented Dec 13, 2024

Uh oh!

azure-pipelines bot commented Dec 13, 2024

Uh oh!

mssonicbld commented Dec 13, 2024

Uh oh!

mssonicbld commented Jan 27, 2025

Uh oh!

azure-pipelines bot commented Jan 27, 2025

Uh oh!

mssonicbld commented Jan 27, 2025

Uh oh!

azure-pipelines bot commented Jan 27, 2025

Uh oh!

rkavitha-hcl commented Jan 30, 2025

Uh oh!

mssonicbld commented Feb 12, 2025

Uh oh!

azure-pipelines bot commented Feb 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qiluo-msft Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kishanps Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

kishanps Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rkavitha-hcl commented Nov 14, 2024 •

edited

Loading

qiluo-msft Feb 18, 2025 •

edited

Loading