gNOI Cold Reboot - Integrated tests#20711
gNOI Cold Reboot - Integrated tests#20711rkavitha-hcl wants to merge 3 commits intosonic-net:masterfrom
Conversation
rkavitha-hcl
force-pushed
the
gnoi_cr_PR3
branch
3 times, most recently
from
d4ba3f9 to
ad91226
Compare
|
@hdwhdw @vvolam @qiluo-msft Pls review |
rkavitha-hcl
force-pushed
the
gnoi_cr_PR3
branch
from
ad91226 to
ee29b8b
Compare
rkavitha-hcl
force-pushed
the
gnoi_cr_PR3
branch
4 times, most recently
from
8c4cb6c to
efa4a2b
Compare
rkavitha-hcl
force-pushed
the
gnoi_cr_PR3
branch
5 times, most recently
from
663ac61 to
8d52b9b
Compare
rkavitha-hcl
force-pushed
the
gnoi_cr_PR3
branch
from
8d52b9b to
446d015
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
gnoi_cr_PR3
branch
from
446d015 to
00176e7
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
gnoi_cr_PR3
branch
from
00176e7 to
2253140
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
gnoi_cr_PR3
branch
from
2253140 to
e9bfc38
Compare
|
/azp run Azure.sonic-buildimage |
|
@kishanps , could you pls review |
1 similar comment
|
@kishanps , could you pls review |
|
@vvolam , could you please review. |
|
@hdwhdw , could you please review |
hdwhdw
left a comment
hdwhdw
left a comment
There was a problem hiding this comment.
An honest question: has this changes be continuously run internally in Google? There are many hard timeout here in the test and I am curious whether they are generous enough to allow different performance in different environments, so we don't flake.
hdwhdw
left a comment
hdwhdw
left a comment
There was a problem hiding this comment.
Let's leave styling to future work.
rkavitha-hcl
force-pushed
the
gnoi_cr_PR3
branch
from
a70389c to
56f2919
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
gnoi_cr_PR3
branch
from
56f2919 to
894cc17
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
gnoi_cr_PR3
branch
from
894cc17 to
6af51ad
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
gnoi_cr_PR3
branch
from
6af51ad to
80c2e34
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
gnoi_cr_PR3
branch
from
80c2e34 to
ab3ffbe
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@rkavitha-hcl could you please point me to the change in the code where we are waiting for HALT method, only for pmon container to be killed? Also, could you modify the code such a way that if container is killed before timeout, can we return success? Please don't force push the changes. Thank you! |
The pmon container wait is in the sonic-host-services |
Thank you @kishanps |
6 participants
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Added UT cases for Cold Reboot feature.
Added component tests for warm reboot.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)