Skip to content

[GCU] [MA] Adding support in existing tests - Common changes #15182

Merged
judyjoseph merged 20 commits intosonic-net:masterfrom
okaravasi:master-gcu_t2_support_common
Apr 25, 2025
Merged

[GCU] [MA] Adding support in existing tests - Common changes #15182
judyjoseph merged 20 commits intosonic-net:masterfrom
okaravasi:master-gcu_t2_support_common

Conversation

@okaravasi
Copy link
Contributor

Description of PR

This PR adds the common changes for adding Multi-ASIC support for generic config updater (GCU) in existing suites.
Original ticket #14070

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • [ X] Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • [ x] 202405

Approach

What is the motivation for this PR?

To add common test code so as to support Multi-ASIC testing in existing GCU suites.

How did you do it?

Two new fixtures where introduced that return random tuple of asic namespace, asic index.

How did you verify/test it?

Ran in vs-kvm-t0 testbed. Ran in t2 MA platform.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@okaravasi okaravasi changed the title Master gcu t2 support common [GCU] [MA] Adding support in existing tests: Common changes Oct 25, 2024
@okaravasi okaravasi changed the title [GCU] [MA] Adding support in existing tests: Common changes [GCU] [MA] Adding support in existing tests - Common changes Oct 25, 2024
@okaravasi okaravasi marked this pull request as ready for review October 25, 2024 14:08
…le setup, compatible with both frontend and any type of DUT host test suites.
okaravasi added a commit to okaravasi/sonic-mgmt that referenced this pull request Oct 31, 2024
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
…c-net#15234)

* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* namespace_prefixes modifications to be called without namespace argument
* adding asic namespace when calling json_formatting for multi_asics
* Adding cli namespace prefix in newly added function get_wred_objects
cyw233 pushed a commit to cyw233/sonic-mgmt that referenced this pull request Nov 19, 2025
cyw233 pushed a commit to cyw233/sonic-mgmt that referenced this pull request Nov 19, 2025
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
…et#15182)

* Common changes for adding GCU MA/T2 support
* Adding an intermediate fixture to support generic_config_updater module setup, compatible with both frontend and any type of DUT host test suites.
* Starting gcu feature support for t2 from 202405, Removing fixture rand_asic_namespace as functionality can be covered by fixture enum_rand_one_frontend_asic_index
* Added fixture that transparently gets asic id from called fixture either for frontend or any asic id
* Adding fixtures for namespace prefixes
* Refactoring wrapper fixture 'selected_asic_index' to explore if enum_asic fixtures are already initialized and return their value otherwise returns 'None' for compatibility with the single-asic platforms. Purpose is to avoid initializing a second enum_asic fixture as we will hit error since the number of asic.
* adding t2 support in separate test suites under generic_config_updater
* standalone definitions for ip_netns and cli prefix namespaces fixtures in order to avoid cached values if both fixtures are called from same function. Also skipping dhcp relay suite for t2

Signed-off-by: opcoder0 <[email protected]>
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
* GCU Adding multi-asic support in existing test suites pfcwd
* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* Replacing rand_asic_namespace fixture with existing enum_rand_one_frontend_asic_index
* Adding namespace in check_config_update
* Adding arguments for ip_netns and cli namespaces prefixes
* Reading flex db counters for interface based on where port belongs and not based on naemspace prefix
* adding namespaces in format_json_patch_for_multiasic

Signed-off-by: opcoder0 <[email protected]>
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
…c-net#15234)

* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* namespace_prefixes modifications to be called without namespace argument
* adding asic namespace when calling json_formatting for multi_asics
* Adding cli namespace prefix in newly added function get_wred_objects

Signed-off-by: opcoder0 <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
…c-net#15234)

* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* namespace_prefixes modifications to be called without namespace argument
* adding asic namespace when calling json_formatting for multi_asics
* Adding cli namespace prefix in newly added function get_wred_objects

Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
…et#15182)

* Common changes for adding GCU MA/T2 support
* Adding an intermediate fixture to support generic_config_updater module setup, compatible with both frontend and any type of DUT host test suites.
* Starting gcu feature support for t2 from 202405, Removing fixture rand_asic_namespace as functionality can be covered by fixture enum_rand_one_frontend_asic_index
* Added fixture that transparently gets asic id from called fixture either for frontend or any asic id
* Adding fixtures for namespace prefixes
* Refactoring wrapper fixture 'selected_asic_index' to explore if enum_asic fixtures are already initialized and return their value otherwise returns 'None' for compatibility with the single-asic platforms. Purpose is to avoid initializing a second enum_asic fixture as we will hit error since the number of asic.
* adding t2 support in separate test suites under generic_config_updater
* standalone definitions for ip_netns and cli prefix namespaces fixtures in order to avoid cached values if both fixtures are called from same function. Also skipping dhcp relay suite for t2
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
* GCU Adding multi-asic support in existing test suites pfcwd
* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* Replacing rand_asic_namespace fixture with existing enum_rand_one_frontend_asic_index
* Adding namespace in check_config_update
* Adding arguments for ip_netns and cli namespaces prefixes
* Reading flex db counters for interface based on where port belongs and not based on naemspace prefix
* adding namespaces in format_json_patch_for_multiasic

Signed-off-by: Aharon Malkin <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
…c-net#15234)

* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* namespace_prefixes modifications to be called without namespace argument
* adding asic namespace when calling json_formatting for multi_asics
* Adding cli namespace prefix in newly added function get_wred_objects

Signed-off-by: Aharon Malkin <[email protected]>
okaravasi added a commit to okaravasi/sonic-mgmt that referenced this pull request Dec 16, 2025
okaravasi added a commit to okaravasi/sonic-mgmt that referenced this pull request Dec 16, 2025
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
…et#15182)

* Common changes for adding GCU MA/T2 support
* Adding an intermediate fixture to support generic_config_updater module setup, compatible with both frontend and any type of DUT host test suites.
* Starting gcu feature support for t2 from 202405, Removing fixture rand_asic_namespace as functionality can be covered by fixture enum_rand_one_frontend_asic_index
* Added fixture that transparently gets asic id from called fixture either for frontend or any asic id
* Adding fixtures for namespace prefixes
* Refactoring wrapper fixture 'selected_asic_index' to explore if enum_asic fixtures are already initialized and return their value otherwise returns 'None' for compatibility with the single-asic platforms. Purpose is to avoid initializing a second enum_asic fixture as we will hit error since the number of asic.
* adding t2 support in separate test suites under generic_config_updater
* standalone definitions for ip_netns and cli prefix namespaces fixtures in order to avoid cached values if both fixtures are called from same function. Also skipping dhcp relay suite for t2

Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
* GCU Adding multi-asic support in existing test suites pfcwd
* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* Replacing rand_asic_namespace fixture with existing enum_rand_one_frontend_asic_index
* Adding namespace in check_config_update
* Adding arguments for ip_netns and cli namespaces prefixes
* Reading flex db counters for interface based on where port belongs and not based on naemspace prefix
* adding namespaces in format_json_patch_for_multiasic

Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
…c-net#15234)

* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* namespace_prefixes modifications to be called without namespace argument
* adding asic namespace when calling json_formatting for multi_asics
* Adding cli namespace prefix in newly added function get_wred_objects

Signed-off-by: Guy Shemesh <[email protected]>
arlakshm pushed a commit that referenced this pull request Jan 8, 2026
Description of PR
Summary:
This PR adds Multi-ASIC new tests for generic config updater (GCU).
The changes of this PR have dependency on below PRs:

#15182 - merged
#20913 - open
#20914 - merged

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
[X ] Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
[X ] 202405
Approach
What is the motivation for this PR?
To add new tests for Multi-ASIC/Chassis test support for GCU functionality.

How did you do it?
How did you verify/test it?
Verified new tests in t2 testbeds.
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
…c-net#15234)

* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* namespace_prefixes modifications to be called without namespace argument
* adding asic namespace when calling json_formatting for multi_asics
* Adding cli namespace prefix in newly added function get_wred_objects
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
Description of PR
Summary:
This PR adds Multi-ASIC new tests for generic config updater (GCU).
The changes of this PR have dependency on below PRs:

sonic-net#15182 - merged
sonic-net#20913 - open
sonic-net#20914 - merged

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
[X ] Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
[X ] 202405
Approach
What is the motivation for this PR?
To add new tests for Multi-ASIC/Chassis test support for GCU functionality.

How did you do it?
How did you verify/test it?
Verified new tests in t2 testbeds.
yifan-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Jan 14, 2026
Description of PR
Summary:
This PR adds Multi-ASIC new tests for generic config updater (GCU).
The changes of this PR have dependency on below PRs:

sonic-net#15182 - merged
sonic-net#20913 - open
sonic-net#20914 - merged

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
[X ] Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
[X ] 202405
Approach
What is the motivation for this PR?
To add new tests for Multi-ASIC/Chassis test support for GCU functionality.

How did you do it?
How did you verify/test it?
Verified new tests in t2 testbeds.

Signed-off-by: YiFan Wang <[email protected]>
PriyanshTratiya pushed a commit to PriyanshTratiya/sonic-mgmt that referenced this pull request Jan 21, 2026
Description of PR
Summary:
This PR adds Multi-ASIC new tests for generic config updater (GCU).
The changes of this PR have dependency on below PRs:

sonic-net#15182 - merged
sonic-net#20913 - open
sonic-net#20914 - merged

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
[X ] Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
[X ] 202405
Approach
What is the motivation for this PR?
To add new tests for Multi-ASIC/Chassis test support for GCU functionality.

How did you do it?
How did you verify/test it?
Verified new tests in t2 testbeds.

Signed-off-by: Priyansh Tratiya <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
…et#15182)

* Common changes for adding GCU MA/T2 support
* Adding an intermediate fixture to support generic_config_updater module setup, compatible with both frontend and any type of DUT host test suites.
* Starting gcu feature support for t2 from 202405, Removing fixture rand_asic_namespace as functionality can be covered by fixture enum_rand_one_frontend_asic_index
* Added fixture that transparently gets asic id from called fixture either for frontend or any asic id
* Adding fixtures for namespace prefixes
* Refactoring wrapper fixture 'selected_asic_index' to explore if enum_asic fixtures are already initialized and return their value otherwise returns 'None' for compatibility with the single-asic platforms. Purpose is to avoid initializing a second enum_asic fixture as we will hit error since the number of asic.
* adding t2 support in separate test suites under generic_config_updater
* standalone definitions for ip_netns and cli prefix namespaces fixtures in order to avoid cached values if both fixtures are called from same function. Also skipping dhcp relay suite for t2

Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
* GCU Adding multi-asic support in existing test suites pfcwd
* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* Replacing rand_asic_namespace fixture with existing enum_rand_one_frontend_asic_index
* Adding namespace in check_config_update
* Adding arguments for ip_netns and cli namespaces prefixes
* Reading flex db counters for interface based on where port belongs and not based on naemspace prefix
* adding namespaces in format_json_patch_for_multiasic

Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
…c-net#15234)

* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* namespace_prefixes modifications to be called without namespace argument
* adding asic namespace when calling json_formatting for multi_asics
* Adding cli namespace prefix in newly added function get_wred_objects

Signed-off-by: Guy Shemesh <[email protected]>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
…c-net#15234)

* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* namespace_prefixes modifications to be called without namespace argument
* adding asic namespace when calling json_formatting for multi_asics
* Adding cli namespace prefix in newly added function get_wred_objects

Signed-off-by: Yael Tzur <[email protected]>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
Description of PR
Summary:
This PR adds Multi-ASIC new tests for generic config updater (GCU).
The changes of this PR have dependency on below PRs:

sonic-net#15182 - merged
sonic-net#20913 - open
sonic-net#20914 - merged

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
[X ] Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
[X ] 202405
Approach
What is the motivation for this PR?
To add new tests for Multi-ASIC/Chassis test support for GCU functionality.

How did you do it?
How did you verify/test it?
Verified new tests in t2 testbeds.

Signed-off-by: Yael Tzur <[email protected]>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Feb 6, 2026
Description of PR
Summary:
This PR adds Multi-ASIC new tests for generic config updater (GCU).
The changes of this PR have dependency on below PRs:

sonic-net#15182 - merged
sonic-net#20913 - open
sonic-net#20914 - merged

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
[X ] Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
[X ] 202405
Approach
What is the motivation for this PR?
To add new tests for Multi-ASIC/Chassis test support for GCU functionality.

How did you do it?
How did you verify/test it?
Verified new tests in t2 testbeds.
nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request Feb 12, 2026
Description of PR
Summary:
This PR adds Multi-ASIC new tests for generic config updater (GCU).
The changes of this PR have dependency on below PRs:

sonic-net#15182 - merged
sonic-net#20913 - open
sonic-net#20914 - merged

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
[X ] Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
[X ] 202405
Approach
What is the motivation for this PR?
To add new tests for Multi-ASIC/Chassis test support for GCU functionality.

How did you do it?
How did you verify/test it?
Verified new tests in t2 testbeds.

Signed-off-by: nnelluri-cisco <[email protected]>
rraghav-cisco pushed a commit to rraghav-cisco/sonic-mgmt that referenced this pull request Feb 13, 2026
Description of PR
Summary:
This PR adds Multi-ASIC new tests for generic config updater (GCU).
The changes of this PR have dependency on below PRs:

sonic-net#15182 - merged
sonic-net#20913 - open
sonic-net#20914 - merged

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
[X ] Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
[X ] 202405
Approach
What is the motivation for this PR?
To add new tests for Multi-ASIC/Chassis test support for GCU functionality.

How did you do it?
How did you verify/test it?
Verified new tests in t2 testbeds.

Signed-off-by: Raghavendran Ramanathan <[email protected]>
anilal-amd pushed a commit to anilal-amd/anilal-forked-sonic-mgmt that referenced this pull request Feb 19, 2026
Description of PR
Summary:
This PR adds Multi-ASIC new tests for generic config updater (GCU).
The changes of this PR have dependency on below PRs:

sonic-net#15182 - merged
sonic-net#20913 - open
sonic-net#20914 - merged

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
[X ] Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
[X ] 202405
Approach
What is the motivation for this PR?
To add new tests for Multi-ASIC/Chassis test support for GCU functionality.

How did you do it?
How did you verify/test it?
Verified new tests in t2 testbeds.

Signed-off-by: Zhuohui Tan <[email protected]>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Mar 17, 2026
Description of PR
Summary:
This PR adds Multi-ASIC new tests for generic config updater (GCU).
The changes of this PR have dependency on below PRs:

sonic-net#15182 - merged
sonic-net#20913 - open
sonic-net#20914 - merged

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
[X ] Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
[X ] 202405
Approach
What is the motivation for this PR?
To add new tests for Multi-ASIC/Chassis test support for GCU functionality.

How did you do it?
How did you verify/test it?
Verified new tests in t2 testbeds.

Signed-off-by: Abhishek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants