Skip to content

[GCU] [MA] Adding support in existing tests - PFCWD #15183

Merged
judyjoseph merged 12 commits intosonic-net:masterfrom
okaravasi:master-gcu_t2_support_pfcwd
May 20, 2025
Merged

[GCU] [MA] Adding support in existing tests - PFCWD #15183
judyjoseph merged 12 commits intosonic-net:masterfrom
okaravasi:master-gcu_t2_support_pfcwd

Conversation

@okaravasi
Copy link
Contributor

Description of PR

This PR adds the common changes for adding Multi-ASIC support for generic config updater (GCU) in existing suites.
Original ticket that got splitted: #14070
This change has a dependency on common changes added via #15182

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • [X ] Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • [ X] 202405

Approach

What is the motivation for this PR?

To add support for Multi-ASIC testing in existing PFCWD GCU suites.

How did you do it?

How did you verify/test it?

Ran in vs-kvm-t0 testbed. Ran in t2 MA platform.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@okaravasi okaravasi marked this pull request as ready for review October 25, 2024 14:08
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/generic_config_updater/test_pfcwd_interval.py:107:1: E302 expected 2 blank lines, found 1
tests/generic_config_updater/test_pfcwd_status.py:211:9: E122 continuation line missing indentation or outdented
tests/generic_config_updater/test_pfcwd_status.py:212:9: E131 continuation line unaligned for hanging indent

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@okaravasi
Copy link
Contributor Author

@xincunli-sonic Could you please review?

@xincunli-sonic
Copy link
Contributor

This PR could be dup with #14098, please double check, but you can left non namespace related changes. Thanks!

@okaravasi okaravasi marked this pull request as draft February 5, 2025 00:14
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@okaravasi okaravasi marked this pull request as ready for review February 11, 2025 15:20
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@okaravasi okaravasi marked this pull request as draft February 14, 2025 18:00
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@okaravasi okaravasi marked this pull request as ready for review February 20, 2025 16:19
@xincunli-sonic xincunli-sonic self-requested a review April 12, 2025 21:36
Copy link
Contributor

@xincunli-sonic xincunli-sonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@judyjoseph judyjoseph merged commit 3f3ef3a into sonic-net:master May 20, 2025
12 checks passed
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
* GCU Adding multi-asic support in existing test suites pfcwd
* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* Replacing rand_asic_namespace fixture with existing enum_rand_one_frontend_asic_index
* Adding namespace in check_config_update
* Adding arguments for ip_netns and cli namespaces prefixes
* Reading flex db counters for interface based on where port belongs and not based on naemspace prefix
* adding namespaces in format_json_patch_for_multiasic

Signed-off-by: opcoder0 <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
* GCU Adding multi-asic support in existing test suites pfcwd
* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* Replacing rand_asic_namespace fixture with existing enum_rand_one_frontend_asic_index
* Adding namespace in check_config_update
* Adding arguments for ip_netns and cli namespaces prefixes
* Reading flex db counters for interface based on where port belongs and not based on naemspace prefix
* adding namespaces in format_json_patch_for_multiasic

Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
* GCU Adding multi-asic support in existing test suites pfcwd
* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* Replacing rand_asic_namespace fixture with existing enum_rand_one_frontend_asic_index
* Adding namespace in check_config_update
* Adding arguments for ip_netns and cli namespaces prefixes
* Reading flex db counters for interface based on where port belongs and not based on naemspace prefix
* adding namespaces in format_json_patch_for_multiasic

Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
* GCU Adding multi-asic support in existing test suites pfcwd
* Update ASIC namespace fixture following changes in dependent PR sonic-net#15182
* Replacing rand_asic_namespace fixture with existing enum_rand_one_frontend_asic_index
* Adding namespace in check_config_update
* Adding arguments for ip_netns and cli namespaces prefixes
* Reading flex db counters for interface based on where port belongs and not based on naemspace prefix
* adding namespaces in format_json_patch_for_multiasic

Signed-off-by: Guy Shemesh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants