[GCU] [MA] Adding support in existing tests - ecn config update by okaravasi · Pull Request #15234 · sonic-net/sonic-mgmt

okaravasi · 2024-10-29T11:08:16Z

Description of PR

This PR adds changes for adding Multi-ASIC support for generic config updater (GCU) in existing test_ecn_config_update suite.
Original ticket that got splitted: #14070
This change has a dependency on common changes added via #15182

Summary:
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
[X ] Test case(new/improvement)

Back port request

202012
202205
202305
202311
[ X] 202405

Approach

What is the motivation for this PR?

To add support for Multi-ASIC testing in existing GCU suite generic_config_updater/test_ecn_config_update.py.

How did you do it?

How did you verify/test it?

Ran in vs-kvm-t0 testbed. Ran in t2 MA platform.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

okaravasi · 2024-11-26T15:45:50Z

@xincunli-sonic Could you please review?

…rt_ecn_config

…-net#15182

xincunli-sonic · 2024-12-02T22:21:05Z

This PR could be dup with #14098, please double check, but you can keep wred object related change. Thanks!

…rt_ecn_config

mssonicbld · 2025-02-07T15:41:33Z

/azp run

azure-pipelines · 2025-02-07T15:41:46Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-02-07T15:52:04Z

/azp run

azure-pipelines · 2025-02-07T15:52:17Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-02-13T23:25:54Z

/azp run

azure-pipelines · 2025-02-13T23:26:06Z

Azure Pipelines successfully started running 1 pipeline(s).

…rt_ecn_config

mssonicbld · 2025-02-20T09:00:36Z

/azp run

azure-pipelines · 2025-02-20T09:01:15Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-02-20T15:27:28Z

/azp run

tests/generic_config_updater/test_ecn_config_update.py

xincunli-sonic

LGTM

judyjoseph · 2025-04-29T15:55:29Z

/azp run

azure-pipelines · 2025-04-29T15:55:35Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

…rt_ecn_config

mssonicbld · 2025-07-11T15:20:57Z

/azp run

azure-pipelines · 2025-07-11T15:21:12Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-07-11T15:29:08Z

/azp run

azure-pipelines · 2025-07-11T15:29:22Z

Azure Pipelines successfully started running 1 pipeline(s).

…c-net#15234) * Update ASIC namespace fixture following changes in dependent PR sonic-net#15182 * namespace_prefixes modifications to be called without namespace argument * adding asic namespace when calling json_formatting for multi_asics * Adding cli namespace prefix in newly added function get_wred_objects

…c-net#15234) * Update ASIC namespace fixture following changes in dependent PR sonic-net#15182 * namespace_prefixes modifications to be called without namespace argument * adding asic namespace when calling json_formatting for multi_asics * Adding cli namespace prefix in newly added function get_wred_objects Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>

…c-net#15234) * Update ASIC namespace fixture following changes in dependent PR sonic-net#15182 * namespace_prefixes modifications to be called without namespace argument * adding asic namespace when calling json_formatting for multi_asics * Adding cli namespace prefix in newly added function get_wred_objects Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…c-net#15234) * Update ASIC namespace fixture following changes in dependent PR sonic-net#15182 * namespace_prefixes modifications to be called without namespace argument * adding asic namespace when calling json_formatting for multi_asics * Adding cli namespace prefix in newly added function get_wred_objects Signed-off-by: Aharon Malkin <amalkin@nvidia.com>

…c-net#15234) * Update ASIC namespace fixture following changes in dependent PR sonic-net#15182 * namespace_prefixes modifications to be called without namespace argument * adding asic namespace when calling json_formatting for multi_asics * Adding cli namespace prefix in newly added function get_wred_objects Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…c-net#15234) * Update ASIC namespace fixture following changes in dependent PR sonic-net#15182 * namespace_prefixes modifications to be called without namespace argument * adding asic namespace when calling json_formatting for multi_asics * Adding cli namespace prefix in newly added function get_wred_objects

…c-net#15234) * Update ASIC namespace fixture following changes in dependent PR sonic-net#15182 * namespace_prefixes modifications to be called without namespace argument * adding asic namespace when calling json_formatting for multi_asics * Adding cli namespace prefix in newly added function get_wred_objects Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…c-net#15234) * Update ASIC namespace fixture following changes in dependent PR sonic-net#15182 * namespace_prefixes modifications to be called without namespace argument * adding asic namespace when calling json_formatting for multi_asics * Adding cli namespace prefix in newly added function get_wred_objects Signed-off-by: Yael Tzur <ytzur@nvidia.com>

[GCU] [MA] Adding support in existing tests - ecn config update

8ec5866

okaravasi added 2 commits November 29, 2024 11:58

Merge remote-tracking branch 'origin/master' into master-gcu_t2_suppo…

cb87d4c

…rt_ecn_config

Update ASIC namespace fixture following changes in dependent PR sonic…

cc94f75

…-net#15182

okaravasi marked this pull request as draft February 5, 2025 00:15

Merge remote-tracking branch 'origin/master' into master-gcu_t2_suppo…

7b25e18

…rt_ecn_config

Adding fixtures for specific namespace verifications in db, cli commands

4373a40

okaravasi marked this pull request as ready for review February 7, 2025 15:52

namespace_prefixes modifications to be called without namespace argument

60be531

okaravasi marked this pull request as draft February 14, 2025 18:00

Merge remote-tracking branch 'origin/master' into master-gcu_t2_suppo…

c8e1ade

…rt_ecn_config

adding asic namespace when calling json_formatting for multi_asics

e2c559b

okaravasi marked this pull request as ready for review February 20, 2025 15:40

judyjoseph reviewed Feb 25, 2025

View reviewed changes

tests/generic_config_updater/test_ecn_config_update.py Show resolved Hide resolved

xincunli-sonic approved these changes Apr 12, 2025

View reviewed changes

judyjoseph approved these changes Apr 28, 2025

View reviewed changes

judyjoseph self-requested a review May 10, 2025 00:52

judyjoseph previously approved these changes May 10, 2025

View reviewed changes

judyjoseph enabled auto-merge (squash) May 20, 2025 20:05

Merge remote-tracking branch 'origin/master' into master-gcu_t2_suppo…

80401ab

…rt_ecn_config

auto-merge was automatically disabled July 11, 2025 15:20
Head branch was pushed to by a user without write access

okaravasi dismissed judyjoseph’s stale review via 80401ab July 11, 2025 15:20

Adding cli namespace prefix in newly added function get_wred_objects

9a28021

judyjoseph approved these changes Jul 21, 2025

View reviewed changes

judyjoseph merged commit 986fc8c into sonic-net:master Jul 21, 2025
13 checks passed

okaravasi mentioned this pull request Oct 3, 2025

Test Gap: GCU PRs back-porting in 2405 #20915

Closed

Conversation

okaravasi commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

okaravasi commented Nov 26, 2024

Uh oh!

xincunli-sonic commented Dec 2, 2024

Uh oh!

mssonicbld commented Feb 7, 2025

Uh oh!

azure-pipelines bot commented Feb 7, 2025

Uh oh!

mssonicbld commented Feb 7, 2025

Uh oh!

azure-pipelines bot commented Feb 7, 2025

Uh oh!

mssonicbld commented Feb 13, 2025

Uh oh!

azure-pipelines bot commented Feb 13, 2025

Uh oh!

mssonicbld commented Feb 20, 2025

Uh oh!

azure-pipelines bot commented Feb 20, 2025

Uh oh!

mssonicbld commented Feb 20, 2025

Uh oh!

Uh oh!

xincunli-sonic left a comment

Choose a reason for hiding this comment

Uh oh!

judyjoseph commented Apr 29, 2025

Uh oh!

azure-pipelines bot commented Apr 29, 2025

Uh oh!

mssonicbld commented Jul 11, 2025

Uh oh!

azure-pipelines bot commented Jul 11, 2025

Uh oh!

mssonicbld commented Jul 11, 2025

Uh oh!

azure-pipelines bot commented Jul 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

okaravasi commented Oct 29, 2024 •

edited

Loading